Attachment 406810 Details for Bug 215627 – Patch

[patch] Patch

bug-215627-20200818173545.patch (text/plain), 5.32 KB, created by Aakash Jain on 2020-08-18 14:35:47 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2020-08-18 14:35:47 PDT

Size: 5.32 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 265833)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,18 @@
>+2020-08-18  Aakash Jain  <aakash_jain@apple.com>
>+
>+        [ews] Handle bugs with unicode characters in title in ews emails
>+        https://bugs.webkit.org/show_bug.cgi?id=215627
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/ews-build/steps.py:
>+        (AnalyzeCompileWebKitResults.send_email_for_new_build_failure): Ensure email_subject is unicode.
>+        (AnalyzeCompileWebKitResults.send_email_for_preexisting_build_failure): Ditto.
>+        (ReRunWebKitTests.send_email_for_flaky_failure): Ditto.
>+        (AnalyzeLayoutTestsResults.send_email_for_flaky_failure): Ditto.
>+        (AnalyzeLayoutTestsResults.send_email_for_pre_existing_failure): Ditto.
>+        (AnalyzeLayoutTestsResults.send_email_for_new_test_failures): Ditto.
>+
> 2020-08-17  Aakash Jain  <aakash_jain@apple.com>
> 
>         Develop a mechanism to unsubscribe from ews emails
>Index: Tools/BuildSlaveSupport/ews-build/steps.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-build/steps.py	(revision 265833)
>+++ Tools/BuildSlaveSupport/ews-build/steps.py	(working copy)
>@@ -1481,7 +1481,7 @@ class AnalyzeCompileWebKitResults(builds
>             else:
>                 logs = self.filter_logs_containing_error(logs)
> 
>-            email_subject = 'Build failure for Patch {}: {}'.format(patch_id, bug_title)
>+            email_subject = u'Build failure for Patch {}: {}'.format(patch_id, bug_title)
>             email_text = 'EWS has detected build failure on {}'.format(builder_name)
>             email_text += ' while testing <a href="{}">Patch {}</a>'.format(Bugzilla.patch_url(patch_id), patch_id)
>             email_text += ' for <a href="{}">Bug {}</a>.'.format(Bugzilla.bug_url(bug_id), bug_id)
>@@ -1506,7 +1506,7 @@ class AnalyzeCompileWebKitResults(builds
>             else:
>                 logs = self.filter_logs_containing_error(logs)
> 
>-            email_subject = 'Build failure on trunk on {}'.format(builder_name)
>+            email_subject = u'Build failure on trunk on {}'.format(builder_name)
>             email_text = 'Failed to build WebKit without patch in {}\n\nBuilder: {}\n\nWorker: {}'.format(build_url, builder_name, worker_name)
>             if logs:
>                 logs = logs.replace('&', '&amp;').replace('<', '&lt;').replace('>', '&gt;')
>@@ -2024,7 +2024,7 @@ class ReRunWebKitTests(RunWebKitTests):
>             build_url = '{}#/builders/{}/builds/{}'.format(self.master.config.buildbotURL, self.build._builderid, self.build.number)
>             history_url = '{}?suite=layout-tests&test={}'.format(RESULTS_DB_URL, test_name)
> 
>-            email_subject = 'Flaky test: {}'.format(test_name)
>+            email_subject = u'Flaky test: {}'.format(test_name)
>             email_text = 'Test {} flaked in {}\n\nBuilder: {}'.format(test_name, build_url, builder_name)
>             email_text = 'Flaky test: {}\n\nBuild: {}\n\nBuilder: {}\n\nWorker: {}\n\nHistory: {}'.format(test_name, build_url, builder_name, worker_name, history_url)
>             send_email_to_bot_watchers(email_subject, email_text)
>@@ -2123,7 +2123,7 @@ class AnalyzeLayoutTestsResults(buildste
>             build_url = '{}#/builders/{}/builds/{}'.format(self.master.config.buildbotURL, self.build._builderid, self.build.number)
>             history_url = '{}?suite=layout-tests&test={}'.format(RESULTS_DB_URL, test_name)
> 
>-            email_subject = 'Flaky test: {}'.format(test_name)
>+            email_subject = u'Flaky test: {}'.format(test_name)
>             email_text = 'Flaky test: {}\n\nBuild: {}\n\nBuilder: {}\n\nWorker: {}\n\nHistory: {}'.format(test_name, build_url, builder_name, worker_name, history_url)
>             send_email_to_bot_watchers(email_subject, email_text)
>         except Exception as e:
>@@ -2136,7 +2136,7 @@ class AnalyzeLayoutTestsResults(buildste
>             build_url = '{}#/builders/{}/builds/{}'.format(self.master.config.buildbotURL, self.build._builderid, self.build.number)
>             history_url = '{}?suite=layout-tests&test={}'.format(RESULTS_DB_URL, test_name)
> 
>-            email_subject = 'Pre-existing test failure: {}'.format(test_name)
>+            email_subject = u'Pre-existing test failure: {}'.format(test_name)
>             email_text = 'Test {} failed on clean tree run in {}.\n\nBuilder: {}\n\nWorker: {}\n\nHistory: {}'.format(test_name, build_url, builder_name, worker_name, history_url)
>             send_email_to_bot_watchers(email_subject, email_text)
>         except Exception as e:
>@@ -2157,7 +2157,7 @@ class AnalyzeLayoutTestsResults(buildste
>                 test_names_string += '\n- {} (<a href="{}">test history</a>)'.format(test_name, history_url)
> 
>             pluralSuffix = 's' if len(test_names) > 1 else ''
>-            email_subject = 'Layout test failure for Patch {}: {} '.format(patch_id, bug_title)
>+            email_subject = u'Layout test failure for Patch {}: {} '.format(patch_id, bug_title)
>             email_text = 'EWS has detected layout test failure{} on {}'.format(pluralSuffix, builder_name)
>             email_text += ' while testing <a href="{}">Patch {}</a>'.format(Bugzilla.patch_url(patch_id), patch_id)
>             email_text += ' for <a href="{}">Bug {}</a>.'.format(Bugzilla.bug_url(bug_id), bug_id)

Actions: View | Formatted Diff | Diff

Attachments on bug 215627: 406810