Attachment 403582 Details for Bug 213881 – Patch

[patch] Patch

wk2-storage-access-tests.diff (text/plain), 3.76 KB, created by Carlos Garcia Campos on 2020-07-06 01:54:36 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Carlos Garcia Campos

Created: 2020-07-06 01:54:36 PDT

Size: 3.76 KB

patch

obsolete

>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 17d30e3d7657..01b4cd4d97b4 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,14 @@
>+2020-07-06  Carlos Garcia Campos  <cgarcia@igalia.com>
>+
>+        [GTK][WPE] Enable storageAccess tests
>+        https://bugs.webkit.org/show_bug.cgi?id=213881
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Enable storageAccess tests and mark expected failures.
>+
>+        * platform/glib/TestExpectations:
>+
> 2020-07-03  Youenn Fablet  <youenn@apple.com>
> 
>         MediaRecorder should support peer connection remote video tracks
>diff --git a/LayoutTests/platform/glib/TestExpectations b/LayoutTests/platform/glib/TestExpectations
>index 508797a2ad15..0c200f802707 100644
>--- a/LayoutTests/platform/glib/TestExpectations
>+++ b/LayoutTests/platform/glib/TestExpectations
>@@ -589,6 +589,16 @@ fast/scrolling/rtl-scrollbars-positioning.html [ Pass ]
> fast/scrolling/rtl-scrollbars-simple.html [ Pass ]
> fast/scrolling/rtl-scrollbars.html [ Pass ]
> 
>+http/tests/storageAccess/ [ Pass ]
>+http/tests/storageAccess/deny-with-prompt-does-not-preserve-gesture.html [ Skip ]
>+http/tests/storageAccess/deny-with-prompt-does-not-preserve-gesture-database.html [ Skip ]
>+webkit.org/b/208400 http/tests/storageAccess/has-storage-access-true-if-third-party-has-cookies-ephemeral-database.html [ Failure ]
>+webkit.org/b/208400 http/tests/storageAccess/has-storage-access-true-if-third-party-has-cookies-ephemeral.html [ Failure ]
>+webkit.org/b/213954 http/tests/storageAccess/request-and-grant-access-then-navigate-cross-site-should-not-have-access-database.html [ Failure ]
>+webkit.org/b/213954 http/tests/storageAccess/request-and-grant-access-then-navigate-cross-site-should-not-have-access.html [ Failure ]
>+webkit.org/b/213954 http/tests/storageAccess/request-and-grant-access-then-navigate-same-site-should-have-access-database.html [ Failure ]
>+webkit.org/b/213954 http/tests/storageAccess/request-and-grant-access-then-navigate-same-site-should-have-access.html [ Failure ]
>+
> webkit.org/b/172056 fast/text/multiglyph-characters.html [ Pass ]
> 
> imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property.html [ DumpJSConsoleLogInStdErr ]
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 57301234c248..5e1b99d0d249 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,13 @@
>+2020-07-06  Carlos Garcia Campos  <cgarcia@igalia.com>
>+
>+        [GTK][WPE] Enable storageAccess tests
>+        https://bugs.webkit.org/show_bug.cgi?id=213881
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebKitTestRunner/TestController.cpp:
>+        (WTR::TestController::getAllStorageAccessEntries): Use the right website data store.
>+
> 2020-06-29  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         [GTK][WPE] Change the cookies accept policy when ITP is enabled
>diff --git a/Tools/WebKitTestRunner/TestController.cpp b/Tools/WebKitTestRunner/TestController.cpp
>index 2bd7918626c0..6804c992656a 100644
>--- a/Tools/WebKitTestRunner/TestController.cpp
>+++ b/Tools/WebKitTestRunner/TestController.cpp
>@@ -3205,12 +3205,11 @@ void getAllStorageAccessEntriesCallback(void* userData, WKArrayRef domainList)
> 
> void TestController::getAllStorageAccessEntries()
> {
>-    auto dataStore = WKContextGetWebsiteDataStore(platformContext());
>     GetAllStorageAccessEntriesCallbackContext context(*this, [this] (Vector<String>&& domains) {
>         m_currentInvocation->didReceiveAllStorageAccessEntries(WTFMove(domains));
>     });
> 
>-    WKWebsiteDataStoreGetAllStorageAccessEntries(dataStore, m_mainWebView->page(), &context, getAllStorageAccessEntriesCallback);
>+    WKWebsiteDataStoreGetAllStorageAccessEntries(websiteDataStore(), m_mainWebView->page(), &context, getAllStorageAccessEntriesCallback);
>     runUntil(context.done, noTimeout);
> }
>

Flags:

aperez: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 213881: 403582