Attachment 402781 Details for Bug 213307 – Patch

[patch] Patch

bug-213307-20200625120856.patch (text/plain), 1.85 KB, created by Yusuke Suzuki on 2020-06-25 12:08:56 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Yusuke Suzuki

Created: 2020-06-25 12:08:56 PDT

Size: 1.85 KB

patch

obsolete

>Subversion Revision: 263521
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index facfa04429286502ccf8ca162d7d13c9a23c3664..0b390aaae55613a96a9d1cc92f8d5ff1c0d70526 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2020-06-25  Yusuke Suzuki  <ysuzuki@apple.com>
>+
>+        REGRESSION(r263035): stress/get-prototype-of.js broken on s390x
>+        https://bugs.webkit.org/show_bug.cgi?id=213307
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Structure::m_outOfLineTypeFlags is uint16_t. If we access this field as 32bit field, we have different value in big endian architectures.
>+        Since we do not have half-size-load branch instructions, we should load this uint16_t value via `loadh` (which zero-extends the loaded value)
>+        and perform branch onto that value.
>+
>+        * llint/LowLevelInterpreter64.asm:
>+
> 2020-06-24  Ross Kirsling  <ross.kirsling@sony.com>
> 
>         [Intl] Disprefer using ICU enums directly as instance variables
>diff --git a/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm b/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm
>index 9ff931c25e489308995aa5841e36e5e25dd5e50d..061745f1e85fe58f9930bc35e8393ba8bb2c731a 100644
>--- a/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm
>+++ b/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm
>@@ -1509,7 +1509,8 @@ llintOpWithProfile(op_get_prototype_of, OpGetPrototypeOf, macro (size, get, disp
>     bbb JSCell::m_type[t0], ObjectType, .opGetPrototypeOfSlow
> 
>     loadStructureWithScratch(t0, t2, t1, t3)
>-    btinz Structure::m_outOfLineTypeFlags[t2], OverridesGetPrototypeOutOfLine, .opGetPrototypeOfSlow
>+    loadh Structure::m_outOfLineTypeFlags[t2], t3
>+    btinz t3, OverridesGetPrototypeOutOfLine, .opGetPrototypeOfSlow
> 
>     loadq Structure::m_prototype[t2], t2
>     btqz t2, .opGetPrototypeOfPolyProto

Flags:

ross.kirsling: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 213307: 402766 | 402781 | 402795 | 402797