Attachment 396542 Details for Bug 210552 – Patch

[patch] Patch

wkgtk-gtk4-npapi.diff (text/plain), 1.20 KB, created by Carlos Garcia Campos on 2020-04-15 09:33:58 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Carlos Garcia Campos

Created: 2020-04-15 09:33:58 PDT

Size: 1.20 KB

patch

obsolete

>diff --git a/ChangeLog b/ChangeLog
>index 996d226571b5..e363ec6da17e 100644
>--- a/ChangeLog
>+++ b/ChangeLog
>@@ -1,3 +1,14 @@
>+2020-04-15  Carlos Garcia Campos  <cgarcia@igalia.com>
>+
>+        [GTK4] Disable netscape plugins API
>+        https://bugs.webkit.org/show_bug.cgi?id=210552
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Because GTK4 is the future and NPAPI plugins the past.
>+
>+        * Source/cmake/OptionsGTK.cmake:
>+
> 2020-04-15  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         Unreviewed. Do not run gtk-doc when building with GTK4
>diff --git a/Source/cmake/OptionsGTK.cmake b/Source/cmake/OptionsGTK.cmake
>index fa68f7849d95..ba17e3ce5a5d 100644
>--- a/Source/cmake/OptionsGTK.cmake
>+++ b/Source/cmake/OptionsGTK.cmake
>@@ -186,6 +186,10 @@ WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_PAINTING_API PRIVATE ${ENABLE_EXPERI
> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_TYPED_OM PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_CONIC_GRADIENTS PRIVATE ON)
> 
>+if (USE_GTK4)
>+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_NETSCAPE_PLUGIN_API PRIVATE OFF)
>+endif ()
>+
> include(GStreamerDependencies)
> 
> # Finalize the value for all options. Do not attempt to use an option before

Flags:

aperez: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 210552: 396542