Attachment 394213 Details for Bug 146729 – Patch

[patch] Patch

bug-146729-20200322101846.patch (text/plain), 1.62 KB, created by Michael Catanzaro on 2020-03-22 08:18:47 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Catanzaro

Created: 2020-03-22 08:18:47 PDT

Size: 1.62 KB

patch

obsolete

>Subversion Revision: 258797
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 4063d1ca52a3be6e0750bb663180c5a3be3c2cb6..04052c091e81b992662b9d16b48a21c3d54a8687 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,18 @@
>+2020-03-22  Michael Catanzaro  <mcatanzaro@gnome.org>
>+
>+        Syscall param sendmsg(msg.msg_iov[0]) points to uninitialised byte(s) in IPC::Connection::sendOutgoingMessage
>+        https://bugs.webkit.org/show_bug.cgi?id=146729
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        We need to pack the MessageInfo struct to avoid writing uninitialized struct padding on the
>+        wire protocol. It's not causing any correctness problems because the uninitialized memory is
>+        just going to become struct padding when it's deserialized in the receiving process, but
>+        it's bad form to pass uninitialized memory to a syscall and makes debugging real problems
>+        with valgrind more difficult.
>+
>+        * Platform/IPC/unix/UnixMessage.h:
>+
> 2020-03-20  Daniel Bates  <dabates@apple.com>
> 
>         Have insertDictatedTextAsync() take an InsertTextOptions
>diff --git a/Source/WebKit/Platform/IPC/unix/UnixMessage.h b/Source/WebKit/Platform/IPC/unix/UnixMessage.h
>index 6e98a7374023846edb2d43b06fde2784f1a81ac3..cd81f7a1154e022151c541f5d39f4ec0ead90f63 100644
>--- a/Source/WebKit/Platform/IPC/unix/UnixMessage.h
>+++ b/Source/WebKit/Platform/IPC/unix/UnixMessage.h
>@@ -58,7 +58,7 @@ private:
>     size_t m_bodySize { 0 };
>     size_t m_attachmentCount { 0 };
>     bool m_isBodyOutOfLine { false };
>-};
>+} __attribute__((packed));
> 
> class UnixMessage {
>     WTF_MAKE_FAST_ALLOCATED;

Actions: View | Formatted Diff | Diff

Attachments on bug 146729: 393967 | 394213 | 394282 | 394283