Attachment 389325 Details for Bug 207026 – Patch

[patch] Patch

bug-207026-20200130220131.patch (text/plain), 1.80 KB, created by Aakash Jain on 2020-01-30 19:01:32 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2020-01-30 19:01:32 PST

Size: 1.80 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 255482)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2020-01-30  Aakash Jain  <aakash_jain@apple.com>
>+
>+        [ews] add build step to set custom build summary
>+        https://bugs.webkit.org/show_bug.cgi?id=207026
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/ews-build/steps.py:
>+        (SetBuildSummary.doStepIf): Run this step only if build_summary property is set.
>+        (SetBuildSummary.hideStepIf): Hide this step if it is not executed.
>+        (SetBuildSummary.start):
>+
> 2020-01-30  Jiewen Tan  <jiewen_tan@apple.com>
> 
>         Unreviewed, another speculative test fix after r255041
>Index: Tools/BuildSlaveSupport/ews-build/steps.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-build/steps.py	(revision 255482)
>+++ Tools/BuildSlaveSupport/ews-build/steps.py	(working copy)
>@@ -2000,3 +2000,23 @@ class ApplyWatchList(shell.ShellCommand)
>         if self.results != SUCCESS:
>             return {u'step': u'Failed to apply watchlist'}
>         return super(ApplyWatchList, self).getResultSummary()
>+
>+
>+class SetBuildSummary(buildstep.BuildStep):
>+    name = "set-build-summary"
>+    descriptionDone = ['Set build summary']
>+    alwaysRun = True
>+    haltOnFailure = False
>+    flunkOnFailure = False
>+
>+    def doStepIf(self, step):
>+        return self.getProperty('build_summary', False)
>+
>+    def hideStepIf(self, results, step):
>+        return not self.doStepIf(step)
>+
>+    def start(self):
>+        build_summary = self.getProperty('build_summary', 'build successful')
>+        self.finished(SUCCESS)
>+        self.build.buildFinished([build_summary], self.build.results)
>+        return defer.succeed(None)

Actions: View | Formatted Diff | Diff

Attachments on bug 207026: 389325