Attachment 384937 Details for Bug 204901 – Patch

[patch] Patch

bug-204901-20191205131019.patch (text/plain), 3.79 KB, created by Yury Semikhatsky on 2019-12-05 13:10:20 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Yury Semikhatsky

Created: 2019-12-05 13:10:20 PST

Size: 3.79 KB

patch

obsolete

>Subversion Revision: 253155
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 0fc6016b7196582a3922b027a8dfd05c26a73691..5a8e2c01ebfe3a8e45426ec321b0e9d1f6be0ba5 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-12-05  Yury Semikhatsky  <yurys@chromium.org>
>+
>+        Web Inspector: http/tests/inspector/target/pause-on-inline-debugger-statement.html is crashing in debug
>+        https://bugs.webkit.org/show_bug.cgi?id=204901
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Restructured the test to avoid inadvertent alert() when navigating to a new
>+        process. New logs are printed after inspected page has navigated.
>+
>+        * http/tests/inspector/target/pause-on-inline-debugger-statement-expected.txt:
>+        * http/tests/inspector/target/pause-on-inline-debugger-statement.html:
>+
> 2019-12-05  youenn fablet  <youenn@apple.com>
> 
>         maplike should define a set method
>diff --git a/LayoutTests/http/tests/inspector/target/pause-on-inline-debugger-statement-expected.txt b/LayoutTests/http/tests/inspector/target/pause-on-inline-debugger-statement-expected.txt
>index b2f668e4f99655cc5507811cab4c647bb0939dae..58f6521db27c8ce9fb98ff0ef2a4db81dd8920c9 100644
>--- a/LayoutTests/http/tests/inspector/target/pause-on-inline-debugger-statement-expected.txt
>+++ b/LayoutTests/http/tests/inspector/target/pause-on-inline-debugger-statement-expected.txt
>@@ -1,2 +1,7 @@
>-ALERT: PASS: Should pause on debugger statement.
> Test page used to check that execution will break on inline 'debugger' statement after cross-origin navigation.
>+
>+
>+== Running test suite: Target.PSON
>+-- Running test case: InlineDebuggerStatement
>+PASS: Should pause on debugger statement.
>+
>diff --git a/LayoutTests/http/tests/inspector/target/pause-on-inline-debugger-statement.html b/LayoutTests/http/tests/inspector/target/pause-on-inline-debugger-statement.html
>index a694dd27c2b0dbf3f040d78cd8c1c93525daff8c..9d0d8e9dc7e0cee1bf21ee5b145df013bf4833d6 100644
>--- a/LayoutTests/http/tests/inspector/target/pause-on-inline-debugger-statement.html
>+++ b/LayoutTests/http/tests/inspector/target/pause-on-inline-debugger-statement.html
>@@ -11,24 +11,19 @@ function test()
>     suite.addTestCase({
>         name: "InlineDebuggerStatement",
>         description: "Check that new provisional page can be paused before navigation.",
>-        test(resolve, reject) {
>-            WI.debuggerManager.awaitEvent(WI.DebuggerManager.Event.Paused)
>-            .then(() => {
>-                InspectorTest.pass(`Should pause on debugger statement.`);
>+        async test() {
>+            const url = "http://localhost:8000/inspector/target/resources/inline-debugger-statement.html";
>+            WI.mainTarget.PageAgent.navigate(url);
> 
>-                // Wait for page reload event to avoid race between test results flushing and the test completion.
>-                let pageLoadPromise = InspectorTest.awaitEvent(FrontendTestHarness.Event.TestPageDidLoad);
>-                //WI.mainTarget.DebuggerAgent.
>-                Promise.resolve().then(() => {
>-                    WI.debuggerManager.resume();
>-                });
>-                return pageLoadPromise;
>-            })
>-            .then(resolve);
>+            await WI.debuggerManager.awaitEvent(WI.DebuggerManager.Event.Paused);
> 
>+            // Wait for page reload event to avoid race between test results flushing and the test completion.
>+            await Promise.all([
>+                InspectorTest.awaitEvent(FrontendTestHarness.Event.TestPageDidLoad),
>+                WI.debuggerManager.resume()
>+            ]);
> 
>-            const url = "http://localhost:8000/inspector/target/resources/inline-debugger-statement.html";
>-            WI.mainTarget.PageAgent.navigate(url);
>+            InspectorTest.pass(`Should pause on debugger statement.`);
>         }
>     });
>

Actions: View | Formatted Diff | Diff

Attachments on bug 204901: 384937