Attachment 384761 Details for Bug 204485 – Patch

[patch] Patch

bug-204485-20191203150346.patch (text/plain), 3.79 KB, created by Doug Kelly on 2019-12-03 15:03:47 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Doug Kelly

Created: 2019-12-03 15:03:47 PST

Size: 3.79 KB

patch

obsolete

>Subversion Revision: 252755
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 1afff4dc5f4276529e92e64562bbd09cf9d21ac7..d97dbde5a03d3190b7365d40bf7c266ec1da0be0 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,19 @@
>+2019-11-21  Doug Kelly  <dougk@apple.com>
>+
>+        Assertion when encountering U_OTHER_NEUTRAL in createBidiRunsForLine at end of run
>+        https://bugs.webkit.org/show_bug.cgi?id=204485
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Comment out the assert for the default case when setting direction at
>+        the end of a bidirectional run.  The current algorithm may not fully
>+        support UAX #9, but this assert also isn't helpful in development.
>+
>+        Test: fast/text/international/unicode-bidi-other-neutrals.html
>+
>+        * platform/text/BidiResolver.h:
>+        (WebCore::DerivedClass>::createBidiRunsForLine):
>+
> 2019-11-21  Peng Liu  <peng.liu6@apple.com>
> 
>         Ignore the requests to enter/exit video fullscreen/picture-in-picture if the requesting mode is the same as the current mode
>diff --git a/Source/WebCore/platform/text/BidiResolver.h b/Source/WebCore/platform/text/BidiResolver.h
>index aafed3de79b99aac4769c76b55f6c1cbb661b8f3..69d9e46e086568dc907ab584dc426685705fdcf0 100644
>--- a/Source/WebCore/platform/text/BidiResolver.h
>+++ b/Source/WebCore/platform/text/BidiResolver.h
>@@ -896,7 +896,8 @@ void BidiResolverBase<Iterator, Run, DerivedClass>::createBidiRunsForLine(const
>                         m_direction = m_status.lastStrong == U_LEFT_TO_RIGHT ? U_LEFT_TO_RIGHT : U_EUROPEAN_NUMBER;
>                         break;
>                     default:
>-                        ASSERT_NOT_REACHED();
>+                        // FIXME: handle neutrals in this case. See https://bugs.webkit.org/show_bug.cgi?id=204817
>+                        break;
>                 }
>                 appendRun();
>             }
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index c3aa7d8ca143bc8ea5d52aa3cf9347ce956fa829..6d94cfd0016377b918d80095d5f807cfe6396c5b 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-11-21  Doug Kelly  <dougk@apple.com>
>+
>+        Assertion when encountering U_OTHER_NEUTRAL in createBidiRunsForLine at end of run
>+        https://bugs.webkit.org/show_bug.cgi?id=204485
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Add a simple test case which illustrates a neutral at the end of a
>+        Unicode bidirectional run.
>+
>+        * fast/text/international/unicode-bidi-other-neutrals-expected.html: Added.
>+        * fast/text/international/unicode-bidi-other-neutrals.html: Added.
>+
> 2019-11-21  Yusuke Suzuki  <ysuzuki@apple.com>
> 
>         Unreviewed, rolling in again, regression is not caused by it
>diff --git a/LayoutTests/fast/text/international/unicode-bidi-other-neutrals-expected.html b/LayoutTests/fast/text/international/unicode-bidi-other-neutrals-expected.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..2f77bec789de2d6663bb5fcc244ee9c4f5ff02fc
>--- /dev/null
>+++ b/LayoutTests/fast/text/international/unicode-bidi-other-neutrals-expected.html
>@@ -0,0 +1,10 @@
>+<!DOCTYPE html>
>+<html>
>+  <head>
>+    <meta charset="utf-8"/>
>+  </head>
>+  <body>
>+    <font dir="ltr">a</font>
>+    <marquee>b</marquee>
>+  </body>
>+</html>
>diff --git a/LayoutTests/fast/text/international/unicode-bidi-other-neutrals.html b/LayoutTests/fast/text/international/unicode-bidi-other-neutrals.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..2f77bec789de2d6663bb5fcc244ee9c4f5ff02fc
>--- /dev/null
>+++ b/LayoutTests/fast/text/international/unicode-bidi-other-neutrals.html
>@@ -0,0 +1,10 @@
>+<!DOCTYPE html>
>+<html>
>+  <head>
>+    <meta charset="utf-8"/>
>+  </head>
>+  <body>
>+    <font dir="ltr">a</font>
>+    <marquee>b</marquee>
>+  </body>
>+</html>

Actions: View | Formatted Diff | Diff

Attachments on bug 204485: 384119 | 384249 | 384675 | 384760 | 384761