Attachment 383130 Details for Bug 203995 – Patch

[patch] Patch

bug-203995-20191108091511.patch (text/plain), 1.51 KB, created by Chris Dumez on 2019-11-08 09:15:12 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Dumez

Created: 2019-11-08 09:15:12 PST

Size: 1.51 KB

patch

obsolete

>Subversion Revision: 252238
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 81267f857f1d3106a8f3873f318fb260931bea47..f91eaf0b451ed045d2b0e0de865d2e88fb9308a3 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,19 @@
>+2019-11-08  Chris Dumez  <cdumez@apple.com>
>+
>+        Regression r252209: Layout Test fast/workers/worker-close-more.html is failing
>+        https://bugs.webkit.org/show_bug.cgi?id=203995
>+        <rdar://problem/57020558>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        We should not dispatch events on a MessagePort objects in a WorkerGlobalScope which is
>+        closing (i.e. WorkerGlobalScope.close() has been called).
>+
>+        No new tests, covered by fast/workers/worker-close-more.html.
>+
>+        * dom/MessagePort.cpp:
>+        (WebCore::MessagePort::dispatchEvent):
>+
> 2019-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         'Strikethrough' editing command reported as 'formatUnderline'
>diff --git a/Source/WebCore/dom/MessagePort.cpp b/Source/WebCore/dom/MessagePort.cpp
>index 24449497d3cc15565e5bbdfa739eca05dcd809be..d43b262b7226758eb6159b28b6bce6186b962d3e 100644
>--- a/Source/WebCore/dom/MessagePort.cpp
>+++ b/Source/WebCore/dom/MessagePort.cpp
>@@ -288,6 +288,9 @@ void MessagePort::dispatchEvent(Event& event)
>     if (m_closed)
>         return;
> 
>+    if (is<WorkerGlobalScope>(*m_scriptExecutionContext) && downcast<WorkerGlobalScope>(*m_scriptExecutionContext).isClosing())
>+        return;
>+
>     EventTarget::dispatchEvent(event);
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 203995: 383130