Attachment 377913 Details for Bug 201425 – Patch

[patch] Patch

bug-201425-20190903124116.patch (text/plain), 1.72 KB, created by Said Abou-Hallawa on 2019-09-03 12:41:16 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Said Abou-Hallawa

Created: 2019-09-03 12:41:16 PDT

Size: 1.72 KB

patch

obsolete

>Index: LayoutTests/ChangeLog
>===================================================================
>--- LayoutTests/ChangeLog	(revision 249437)
>+++ LayoutTests/ChangeLog	(working copy)
>@@ -1,3 +1,21 @@
>+2019-09-03  Said Abou-Hallawa  <sabouhallawa@apple.com>
>+
>+        REGRESSION (r249364): Layout Test webgpu/texture-triangle-strip.html is Failing
>+        https://bugs.webkit.org/show_bug.cgi?id=201425
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        The orientation of webgpu/resources/blue-checkered.png is OriginRightTop.
>+        Because r249364 made the image orientation respected everywhere including
>+        the canvas drawImage(), the expected result does not match the output of
>+        the test anymore.
>+
>+        The fix is to change the the expected result to match the image drawing
>+        when the image orientation is respected.
>+
>+        * webgpu/js/webgpu-functions.js:
>+        (drawGreenAndBlueCheckerboardInSoftware):
>+
> 2019-09-03  Jiewen Tan  <jiewen_tan@apple.com>
> 
>         [WebAuthn] Enable WebAuthn by default for MobileSafari and SafariViewService
>Index: LayoutTests/webgpu/js/webgpu-functions.js
>===================================================================
>--- LayoutTests/webgpu/js/webgpu-functions.js	(revision 249431)
>+++ LayoutTests/webgpu/js/webgpu-functions.js	(working copy)
>@@ -38,7 +38,7 @@ function drawGreenAndBlueCheckerboardInS
>     context.fillStyle = 'rgb(0, 0, 255)';
>     for (let x = 0; x < numColumns; ++x) {
>         for (let y = 0; y < numRows; ++y) {
>-            if (x % 2 == 0 && y % 2 == 0 || x % 2 == 1 && y % 2 == 1)
>+            if ((x + y) % 2 == 1)
>                 context.rect(
>                     x * canvas.width / numColumns,
>                     y * canvas.height / numRows,

Actions: View | Formatted Diff | Diff

Attachments on bug 201425: 377900 | 377913