Attachment 377515 Details for Bug 201253 – Patch

[patch] Patch

bug-201253-20190828202412.patch (text/plain), 2.93 KB, created by Aakash Jain on 2019-08-28 17:24:13 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2019-08-28 17:24:13 PDT

Size: 2.93 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 249226)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,16 @@
>+2019-08-28  Aakash Jain  <aakash_jain@apple.com>
>+
>+        EWS bubbles should indicate builder vs tester
>+        https://bugs.webkit.org/show_bug.cgi?id=201253
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
>+        (StatusBubble):
>+        (StatusBubble._build_bubble): Add the builder and/or tester symbols in the tool-tip.
>+        (StatusBubble._is_builder_queue): Method to determine if the build is from a builder queue.
>+        (StatusBubble._is_tester_queue): Method to determine if the build is from a tester queue.
>+
> 2019-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
> 
>         WKAttachmentTests.DropFolderAsAttachmentAndMoveByDragging fails in some iOS simulator configurations
>Index: Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py	(revision 249226)
>+++ Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py	(working copy)
>@@ -53,6 +53,8 @@ class StatusBubble(View):
>         'mac-debug-wk1': 'mac-debug',
>     }
> 
>+    BUILD_STEPS = ['compiled webkit']
>+    TEST_STEPS = ['api-tests', 'bindings-tests', 'layout-tests', 'webkitperl-tests', 'webkitpy tests']
>     STEPS_TO_HIDE = ['Killed old processes', 'Configured build', '^OS:.*Xcode:', '(skipped)']
>     DAYS_TO_CHECK = 3
> 
>@@ -75,6 +77,10 @@ class StatusBubble(View):
> 
>         bubble['url'] = 'https://{}/#/builders/{}/builds/{}'.format(config.BUILDBOT_SERVER_HOST, build.builder_id, build.number)
>         builder_full_name = build.builder_name.replace('-', ' ')
>+        if self._is_tester_queue(build):
>+            builder_full_name = u'\U0001f9ea' + '  ' + builder_full_name
>+        if self._is_builder_queue(build):
>+            builder_full_name = u'\U0001f6e0' + '  ' + builder_full_name
> 
>         if build.result is None:  # In-progress build
>             if self._does_build_contains_any_failed_step(build):
>@@ -136,6 +142,26 @@ class StatusBubble(View):
> 
>         return bubble
> 
>+    def _is_builder_queue(self, build):
>+        if 'build' in build.builder_name.lower():
>+            return True
>+
>+        for step in build.step_set.all():
>+            if any(build_step.lower() in step.state_string.lower() for build_step in StatusBubble.BUILD_STEPS):
>+                return True
>+
>+        return False
>+
>+    def _is_tester_queue(self, build):
>+        if 'test' in build.builder_name.lower():
>+            return True
>+
>+        for step in build.step_set.all():
>+            if any(test_step.lower() in step.state_string.lower() for test_step in StatusBubble.TEST_STEPS):
>+                return True
>+
>+        return False
>+
>     def _get_parent_queue(self, queue):
>         return StatusBubble.QUEUE_TRIGGERS.get(queue)
>

Actions: View | Formatted Diff | Diff

Attachments on bug 201253: 377515 | 377531 | 377972 | 377985