Attachment 375611 Details for Bug 200465 – Patch

[patch] Patch

bug-200465-20190806162234.patch (text/plain), 3.20 KB, created by Fujii Hironori on 2019-08-06 00:22:35 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Fujii Hironori

Created: 2019-08-06 00:22:35 PDT

Size: 3.20 KB

patch

obsolete

>Subversion Revision: 248286
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index fffc477290165106a0ea39369eb7b8ec6254b9a2..da094adc859732b5a0b31500d5fa15bc03287a7c 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,18 @@
>+2019-08-06  Fujii Hironori  <Hironori.Fujii@sony.com>
>+
>+        ASSERTION FAILED: m_observers.isEmpty() if WKPageSetPageStateClient is used
>+        https://bugs.webkit.org/show_bug.cgi?id=200465
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        PageLoadState::Observer should be removed before destructing
>+        WebPageProxy.
>+
>+        * UIProcess/WebPageProxy.cpp:
>+        (WebKit::WebPageProxy::~WebPageProxy): Call
>+        setPageLoadStateObserver with nullptr to remove
>+        PageLoadState::Observer.
>+
> 2019-08-05  Youenn Fablet  <youenn@apple.com>
> 
>         Support RTCRtpSender.dtmf
>diff --git a/Source/WebKit/UIProcess/WebPageProxy.cpp b/Source/WebKit/UIProcess/WebPageProxy.cpp
>index 6609ae1ed8148e4079c97ffeb0592d791ff71ae9..82eb2ac565114eb61fd9524fd66c473ec4b0eff6 100644
>--- a/Source/WebKit/UIProcess/WebPageProxy.cpp
>+++ b/Source/WebKit/UIProcess/WebPageProxy.cpp
>@@ -500,6 +500,8 @@ WebPageProxy::~WebPageProxy()
>         ASSERT(page != this);
> #endif
> 
>+    setPageLoadStateObserver(nullptr);
>+
>     if (!m_isClosed)
>         close();
> 
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 0707e163c06cd50dfd40e2a6693477799597adb0..63319e1765bb77b8fbd4a6638f6f49f99a047993 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-08-06  Fujii Hironori  <Hironori.Fujii@sony.com>
>+
>+        ASSERTION FAILED: m_observers.isEmpty() if WKPageSetPageStateClient is used
>+        https://bugs.webkit.org/show_bug.cgi?id=200465
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * TestWebKitAPI/Tests/WebKit/PageLoadState.cpp:
>+        (TestWebKitAPI::WebKit.PageLoadState): Set PageStateClient before
>+        finishing the test.
>+        * TestWebKitAPI/win/PlatformWebViewWin.cpp:
>+        (TestWebKitAPI::PlatformWebView::~PlatformWebView): Release m_view.
>+
> 2019-08-05  Simon Fraser  <simon.fraser@apple.com>
> 
>         iOS 13: Overflow:hidden on body prevents PDF scroll
>diff --git a/Tools/TestWebKitAPI/Tests/WebKit/PageLoadState.cpp b/Tools/TestWebKitAPI/Tests/WebKit/PageLoadState.cpp
>index e6514c2c0c143cc1cc53f24da24755bd2edd1d94..12e9872ccf621977242c130948a43ffbe7e33b77 100644
>--- a/Tools/TestWebKitAPI/Tests/WebKit/PageLoadState.cpp
>+++ b/Tools/TestWebKitAPI/Tests/WebKit/PageLoadState.cpp
>@@ -295,6 +295,8 @@ TEST(WebKit, PageLoadState)
>     Util::run(&test1Done);
> 
>     EXPECT_EQ(state.didChangeActiveURL, 4);
>+
>+    WKPageSetPageStateClient(webView.page(), &stateClient.base);
> }
> 
> } // namespace TestWebKitAPI
>diff --git a/Tools/TestWebKitAPI/win/PlatformWebViewWin.cpp b/Tools/TestWebKitAPI/win/PlatformWebViewWin.cpp
>index 3eb6d5c8366529e86ec93e495863d2ed7dc99b4b..fbd7c093ba153043643ddf348a4dba37c7fa53b4 100644
>--- a/Tools/TestWebKitAPI/win/PlatformWebViewWin.cpp
>+++ b/Tools/TestWebKitAPI/win/PlatformWebViewWin.cpp
>@@ -93,6 +93,7 @@ void PlatformWebView::initialize(WKPageConfigurationRef configuration)
> PlatformWebView::~PlatformWebView()
> {
>     ::DestroyWindow(m_window);
>+    WKRelease(m_view);
> }
> 
> WKPageRef PlatformWebView::page() const

Actions: View | Formatted Diff | Diff

Attachments on bug 200465: 375611