Attachment 365335 Details for Bug 195995 – Patch

[patch] Patch

bug-195995-20190320070903.patch (text/plain), 1.34 KB, created by Aakash Jain on 2019-03-20 04:08:34 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2019-03-20 04:08:34 PDT

Size: 1.34 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 243196)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,13 @@
>+2019-03-20  Aakash Jain  <aakash_jain@apple.com>
>+
>+        [ews-build] Improve failure summary string for ApplyPatch step
>+        https://bugs.webkit.org/show_bug.cgi?id=195995
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/ews-build/steps.py:
>+        (ApplyPatch.getResultSummary): Override getResultSummary.
>+
> 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
> 
>         [WebAuthN] Implement FIDO AppID extension
>Index: Tools/BuildSlaveSupport/ews-build/steps.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-build/steps.py	(revision 243196)
>+++ Tools/BuildSlaveSupport/ews-build/steps.py	(working copy)
>@@ -135,6 +135,11 @@ class ApplyPatch(shell.ShellCommand, Com
>         d.addCallback(lambda _: self.downloadFileContentToWorker('.buildbot-patched', 'patched\n'))
>         d.addCallback(lambda res: shell.ShellCommand.start(self))
> 
>+    def getResultSummary(self):
>+        if self.results != SUCCESS:
>+            return {u'step': u'Patch does not apply'}
>+        return super(ApplyPatch, self).getResultSummary()
>+
> 
> class CheckPatchRelevance(buildstep.BuildStep):
>     name = 'check-patch-relevance'

Flags:

dewei_zhu: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 195995: 365335