Attachment 357139 Details for Bug 192449 – patch - part1

[patch] patch - part1

patch (text/plain), 5.88 KB, created by chris fleizach on 2018-12-12 09:33:14 PST

(hide)

Description:

Filename:

MIME Type:

Creator: chris fleizach

Created: 2018-12-12 09:33:14 PST

Size: 5.88 KB

patch

obsolete

>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 239107)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,21 @@
>+2018-12-12  Chris Fleizach  <cfleizach@apple.com>
>+
>+        [meta][WebKit] Remove using namespace WebCore and WebKit in the global scope for unified source builds
>+        https://bugs.webkit.org/show_bug.cgi?id=192449
>+        <rdar://problem/46595508>
>+
>+        Reviewed by Darin Adler.
>+
>+        Part 1: Files in NetworkProcess.
>+
>+        * NetworkProcess/Cookies/mac/WebCookieManagerMac.mm:
>+        * NetworkProcess/IndexedDB/WebIDBConnectionToClient.cpp:
>+        * NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:
>+        * NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp:
>+        * NetworkProcess/ios/NetworkProcessIOS.mm:
>+        * NetworkProcess/mac/NetworkProcessMac.mm:
>+        * NetworkProcess/mac/RemoteNetworkingContext.mm:
>+
> 2018-12-09  Darin Adler  <darin@apple.com>
> 
>         [iOS] Zero memory containing the password for PDF documents when a WKPDFView is deallocated
>Index: Source/WebKit/NetworkProcess/Cookies/mac/WebCookieManagerMac.mm
>===================================================================
>--- Source/WebKit/NetworkProcess/Cookies/mac/WebCookieManagerMac.mm	(revision 239075)
>+++ Source/WebKit/NetworkProcess/Cookies/mac/WebCookieManagerMac.mm	(working copy)
>@@ -31,10 +31,9 @@
> #import <pal/spi/cf/CFNetworkSPI.h>
> #import <wtf/ProcessPrivilege.h>
> 
>+namespace WebKit {
> using namespace WebCore;
> 
>-namespace WebKit {
>-
> void WebCookieManager::platformSetHTTPCookieAcceptPolicy(HTTPCookieAcceptPolicy policy)
> {
>     ASSERT(hasProcessPrivilege(ProcessPrivilege::CanAccessRawCookies));
>Index: Source/WebKit/NetworkProcess/IndexedDB/WebIDBConnectionToClient.cpp
>===================================================================
>--- Source/WebKit/NetworkProcess/IndexedDB/WebIDBConnectionToClient.cpp	(revision 239075)
>+++ Source/WebKit/NetworkProcess/IndexedDB/WebIDBConnectionToClient.cpp	(working copy)
>@@ -41,10 +41,9 @@
> #include <WebCore/ThreadSafeDataBuffer.h>
> #include <WebCore/UniqueIDBDatabaseConnection.h>
> 
>+namespace WebKit {
> using namespace WebCore;
> 
>-namespace WebKit {
>-
> Ref<WebIDBConnectionToClient> WebIDBConnectionToClient::create(NetworkConnectionToWebProcess& connection, uint64_t serverConnectionIdentifier, PAL::SessionID sessionID)
> {
>     return adoptRef(*new WebIDBConnectionToClient(connection, serverConnectionIdentifier, sessionID));
>Index: Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp
>===================================================================
>--- Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp	(revision 239075)
>+++ Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp	(working copy)
>@@ -53,11 +53,10 @@
> #include <WebCore/ServiceWorkerUpdateViaCache.h>
> #include <wtf/MainThread.h>
> 
>+namespace WebKit {
> using namespace PAL;
> using namespace WebCore;
> 
>-namespace WebKit {
>-
> #define SWSERVERCONNECTION_RELEASE_LOG_IF_ALLOWED(fmt, ...) RELEASE_LOG_IF(m_sessionID.isAlwaysOnLoggingAllowed(), ServiceWorker, "%p - WebSWServerConnection::" fmt, this, ##__VA_ARGS__)
> #define SWSERVERCONNECTION_RELEASE_LOG_ERROR_IF_ALLOWED(fmt, ...) RELEASE_LOG_ERROR_IF(m_sessionID.isAlwaysOnLoggingAllowed(), ServiceWorker, "%p - WebSWServerConnection::" fmt, this, ##__VA_ARGS__)
> 
>Index: Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp
>===================================================================
>--- Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp	(revision 239075)
>+++ Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp	(working copy)
>@@ -33,10 +33,9 @@
> #include "WebSWContextManagerConnectionMessages.h"
> #include <WebCore/ServiceWorkerContextData.h>
> 
>+namespace WebKit {
> using namespace WebCore;
> 
>-namespace WebKit {
>-
> WebSWServerToContextConnection::WebSWServerToContextConnection(const SecurityOriginData& securityOrigin, Ref<IPC::Connection>&& connection)
>     : SWServerToContextConnection(securityOrigin)
>     , m_ipcConnection(WTFMove(connection))
>Index: Source/WebKit/NetworkProcess/ios/NetworkProcessIOS.mm
>===================================================================
>--- Source/WebKit/NetworkProcess/ios/NetworkProcessIOS.mm	(revision 239075)
>+++ Source/WebKit/NetworkProcess/ios/NetworkProcessIOS.mm	(working copy)
>@@ -41,10 +41,9 @@
> 
> #define ENABLE_MANUAL_NETWORK_SANDBOXING 0
> 
>+namespace WebKit {
> using namespace WebCore;
> 
>-namespace WebKit {
>-
> void NetworkProcess::initializeProcess(const ChildProcessInitializationParameters&)
> {
>     InitWebCoreThreadSystemInterface();
>Index: Source/WebKit/NetworkProcess/mac/NetworkProcessMac.mm
>===================================================================
>--- Source/WebKit/NetworkProcess/mac/NetworkProcessMac.mm	(revision 239075)
>+++ Source/WebKit/NetworkProcess/mac/NetworkProcessMac.mm	(working copy)
>@@ -47,10 +47,9 @@
> #import <wtf/MemoryPressureHandler.h>
> #import <wtf/text/WTFString.h>
> 
>+namespace WebKit {
> using namespace WebCore;
> 
>-namespace WebKit {
>-
> void NetworkProcess::initializeProcess(const ChildProcessInitializationParameters&)
> {
>     // Having a window server connection in this process would result in spin logs (<rdar://problem/13239119>).
>Index: Source/WebKit/NetworkProcess/mac/RemoteNetworkingContext.mm
>===================================================================
>--- Source/WebKit/NetworkProcess/mac/RemoteNetworkingContext.mm	(revision 239075)
>+++ Source/WebKit/NetworkProcess/mac/RemoteNetworkingContext.mm	(working copy)
>@@ -39,10 +39,9 @@
> #import <pal/SessionID.h>
> #import <wtf/MainThread.h>
> 
>+namespace WebKit {
> using namespace WebCore;
> 
>-namespace WebKit {
>-
> void RemoteNetworkingContext::ensureWebsiteDataStoreSession(WebsiteDataStoreParameters&& parameters)
> {
>     auto sessionID = parameters.networkSessionParameters.sessionID;

Actions: View | Formatted Diff | Diff

Attachments on bug 192449: 356865 | 356866 | 356867 | 356868 | 356869 | 356870 | 356871 | 356872 | 356908 | 356926 | 356929 | 356950 | 356951 | 356989 | 356993 | 356995 | 357000 | 357014 | 357021 | 357109 | 357112 | 357115 | 357136 | 357139 | 357145 | 357152 | 357189 | 357191 | 357195 | 357211 | 357214 | 357218 | 357232 | 357237 | 357278 | 357318 | 357329