Attachment 354901 Details for Bug 191626 – Patch

[patch] Patch

bug-191626-20181115181449.patch (text/plain), 3.56 KB, created by Fujii Hironori on 2018-11-15 01:14:51 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Fujii Hironori

Created: 2018-11-15 01:14:51 PST

Size: 3.56 KB

patch

obsolete

>Subversion Revision: 238218
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index a6b6883f716c4dfa95798dc0eb3bfffb61602616..803ddb7765da2aef353fcde82de47f8d2952fc41 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,19 @@
>+2018-11-15  Fujii Hironori  <Hironori.Fujii@sony.com>
>+
>+        REGRESSION(r238039) WebCore::JSDOMGlobalObject::createStructure is using JSC::Structure::create without including StructureInlines.h
>+        https://bugs.webkit.org/show_bug.cgi?id=191626
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        JSC::Structure::create is used everywhere. It should be defined in
>+        Structure.h, not in StructureInlines.h.
>+
>+        * runtime/Structure.h: Marked JSC::Structure::create declaration
>+        'inline' to match with the definition to prevent future
>+        regressions.
>+        (JSC::Structure::create): Moved.
>+        * runtime/StructureInlines.h: Moved JSC::Structure::create.
>+
> 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
> 
>         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
>diff --git a/Source/JavaScriptCore/runtime/Structure.h b/Source/JavaScriptCore/runtime/Structure.h
>index b64e23a66d3cb90716b0ce670f5195c5caabb84c..074608046bb44337b0c4dd07e3f3e9c39dbaa1ae 100644
>--- a/Source/JavaScriptCore/runtime/Structure.h
>+++ b/Source/JavaScriptCore/runtime/Structure.h
>@@ -132,7 +132,7 @@ public:
>     static const unsigned StructureFlags = Base::StructureFlags | StructureIsImmortal;
>     
>     enum PolyProtoTag { PolyProto };
>-    static Structure* create(VM&, JSGlobalObject*, JSValue prototype, const TypeInfo&, const ClassInfo*, IndexingType = NonArray, unsigned inlineCapacity = 0);
>+    inline static Structure* create(VM&, JSGlobalObject*, JSValue prototype, const TypeInfo&, const ClassInfo*, IndexingType = NonArray, unsigned inlineCapacity = 0);
>     static Structure* create(PolyProtoTag, VM&, JSGlobalObject*, JSObject* prototype, const TypeInfo&, const ClassInfo*, IndexingType = NonArray, unsigned inlineCapacity = 0);
> 
>     ~Structure();
>@@ -828,4 +828,13 @@ private:
>     uint32_t m_propertyHash;
> };
> 
>+inline Structure* Structure::create(VM& vm, JSGlobalObject* globalObject, JSValue prototype, const TypeInfo& typeInfo, const ClassInfo* classInfo, IndexingType indexingType, unsigned inlineCapacity)
>+{
>+    ASSERT(vm.structureStructure);
>+    ASSERT(classInfo);
>+    Structure* structure = new (NotNull, allocateCell<Structure>(vm.heap)) Structure(vm, globalObject, prototype, typeInfo, classInfo, indexingType, inlineCapacity);
>+    structure->finishCreation(vm);
>+    return structure;
>+}
>+
> } // namespace JSC
>diff --git a/Source/JavaScriptCore/runtime/StructureInlines.h b/Source/JavaScriptCore/runtime/StructureInlines.h
>index d76df8763e8124144116d5f541268fe45268e349..b3eb1b41e9f1c781e96f0229051000e042705d5e 100644
>--- a/Source/JavaScriptCore/runtime/StructureInlines.h
>+++ b/Source/JavaScriptCore/runtime/StructureInlines.h
>@@ -34,15 +34,6 @@
> 
> namespace JSC {
> 
>-inline Structure* Structure::create(VM& vm, JSGlobalObject* globalObject, JSValue prototype, const TypeInfo& typeInfo, const ClassInfo* classInfo, IndexingType indexingType, unsigned inlineCapacity)
>-{
>-    ASSERT(vm.structureStructure);
>-    ASSERT(classInfo);
>-    Structure* structure = new (NotNull, allocateCell<Structure>(vm.heap)) Structure(vm, globalObject, prototype, typeInfo, classInfo, indexingType, inlineCapacity);
>-    structure->finishCreation(vm);
>-    return structure;
>-}
>-
> inline Structure* Structure::createStructure(VM& vm)
> {
>     ASSERT(!vm.structureStructure);

Actions: View | Formatted Diff | Diff

Attachments on bug 191626: 354901 | 355250