Attachment 345133 Details for Bug 187720 – Patch

[patch] Patch

bug-187720-20180716180524.patch (text/plain), 2.63 KB, created by Jeremy Jones on 2018-07-16 18:05:25 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Jones

Created: 2018-07-16 18:05:25 PDT

Size: 2.63 KB

patch

obsolete

>Subversion Revision: 233866
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index b6c2c57d6c130a354fe2dbb3e218bf5bb74aa13a..11f681dea73176d2e4f489235565bdbcb354ec15 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-07-16  Jeremy Jones  <jeremyj@apple.com>
>+
>+        Fix API Test failures introduced by r233865
>+        https://bugs.webkit.org/show_bug.cgi?id=187720
>+
>+        Unreviewed APITest fix after r233865.
>+
>+        Fullscreen can now only be initiated from a window that is on screen.
>+
>+        * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
>+        (TestWebKitAPI::TEST):
>+        * TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm:
>+        (TestWebKitAPI::TEST):
>+
> 2018-07-16  Aditya Keerthi  <akeerthi@apple.com>
> 
>         [Datalist][macOS] Add suggestions UI for TextFieldInputTypes
>diff --git a/Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm b/Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm
>index 1d051c7df7bf3dcef33406caf0cfd25a3faf4e33..4f5d4b723eede5c85e84676411d599aa323261b1 100644
>--- a/Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm
>+++ b/Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm
>@@ -94,6 +94,7 @@ TEST(Fullscreen, Delegate)
> 
>     RetainPtr<NSWindow> window = adoptNS([[NSWindow alloc] initWithContentRect:[webView frame] styleMask:NSWindowStyleMaskBorderless backing:NSBackingStoreBuffered defer:NO]);
>     [[window contentView] addSubview:webView.get()];
>+    [window makeKeyAndOrderFront:nil];
> 
>     NSURLRequest *request = [NSURLRequest requestWithURL:[[NSBundle mainBundle] URLForResource:@"FullscreenDelegate" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"]];
>     [webView loadRequest:request];
>diff --git a/Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm b/Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm
>index d11c80ac6e4de32fa61bef3e2d87293107b62d10..7450278340e0a6b73a00f6e890ea1a3fecb91761 100644
>--- a/Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm
>+++ b/Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm
>@@ -65,6 +65,7 @@ TEST(Fullscreen, TopContentInset)
> 
>     RetainPtr<NSWindow> window = adoptNS([[NSWindow alloc] initWithContentRect:[webView frame] styleMask:NSWindowStyleMaskBorderless backing:NSBackingStoreBuffered defer:NO]);
>     [[window contentView] addSubview:webView.get()];
>+    [window makeKeyAndOrderFront:nil];
> 
>     NSURLRequest *request = [NSURLRequest requestWithURL:[[NSBundle mainBundle] URLForResource:@"FullscreenTopContentInset" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"]];
>     [webView loadRequest:request];

Actions: View | Formatted Diff | Diff

Attachments on bug 187720: 345133