Attachment 33039 Details for Bug 19874 – Patch

[patch] Patch

patch.diff (text/plain), 4.16 KB, created by Keishi Hattori on 2009-07-19 05:14:12 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Keishi Hattori

Created: 2009-07-19 05:14:12 PDT

Size: 4.16 KB

patch

obsolete

>diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
>index 783f45f..4681875 100644
>--- a/WebCore/ChangeLog
>+++ b/WebCore/ChangeLog
>@@ -1,3 +1,19 @@
>+2009-07-19  Keishi Hattori  <casey.hattori@gmail.com>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Inspector should support inspect() in the command line
>+        https://bugs.webkit.org/show_bug.cgi?id=19874
>+        rdar://problem/6070225
>+
>+        * inspector/front-end/Console.js:
>+        (WebInspector.Console.prototype._ensureCommandLineAPIInstalled.inspectObject):
>+        (WebInspector.Console.prototype._ensureCommandLineAPIInstalled):
>+        * inspector/front-end/DatabasesPanel.js:
>+        (WebInspector.DatabasesPanel.prototype.revealAndSelectDomStorage): Added.
>+        (WebInspector.DatabasesPanel.prototype.revealAndSelectDatabase): Added.
>+        (WebInspector.DatabasesPanel.prototype.showDatabase): 
>+
> 2009-07-19  Adam Barth  <abarth@webkit.org>
> 
>         Reviewed by David Levin.
>diff --git a/WebCore/inspector/front-end/Console.js b/WebCore/inspector/front-end/Console.js
>index 7ffd0ab..ab72808 100644
>--- a/WebCore/inspector/front-end/Console.js
>+++ b/WebCore/inspector/front-end/Console.js
>@@ -416,6 +416,30 @@ WebInspector.Console.prototype = {
>             };");
> 
>             inspectedWindow._inspectorCommandLineAPI.clear = InspectorController.wrapCallback(this.clearMessages.bind(this));
>+            inspectedWindow._inspectorCommandLineAPI.inspect = InspectorController.wrapCallback(inspectObject.bind(this));
>+
>+            function inspectObject(o)
>+            {
>+                if (arguments.length === 0)
>+                    return;
>+
>+                InspectorController.inspectedWindow().console.log(o);
>+                if (Object.type(o, InspectorController.inspectedWindow()) === "node") {
>+                    WebInspector.showElementsPanel();
>+                    WebInspector.panels.elements.treeOutline.revealAndSelectNode(o);
>+                } else {
>+                    switch (Object.describe(o)) {
>+                        case "Database":
>+                            WebInspector.showDatabasesPanel();
>+                            WebInspector.panels.databases.revealAndSelectDatabase(o);
>+                            break;
>+                        case "Storage":
>+                            WebInspector.showDatabasesPanel();
>+                            WebInspector.panels.databases.revealAndSelectDomStorage(o);
>+                            break;
>+                    }
>+                }
>+            }
>         }
>     },
>     
>diff --git a/WebCore/inspector/front-end/DatabasesPanel.js b/WebCore/inspector/front-end/DatabasesPanel.js
>index b1d815f..ad3d71a 100644
>--- a/WebCore/inspector/front-end/DatabasesPanel.js
>+++ b/WebCore/inspector/front-end/DatabasesPanel.js
>@@ -145,6 +145,32 @@ WebInspector.DatabasesPanel.prototype = {
>             this.sessionStorageListTreeElement.appendChild(domStorageTreeElement);
>     },
> 
>+    revealAndSelectDomStorage: function(s)
>+    {
>+        var storage;
>+        for (var i = 0, len = this._domStorage.length; i < len; ++i) {
>+            storage = this._domStorage[i];
>+            if ( s === storage.domStorage ) {
>+                this.showDOMStorage(storage);
>+                storage._domStorageTreeElement.select();
>+                return;
>+            }
>+        }
>+    },
>+
>+    revealAndSelectDatabase: function(db)
>+    {
>+        var database;
>+        for (var i = 0, len = this._databases.length; i < len; ++i) {
>+            database = this._databases[i];
>+            if ( db === database.database ) {
>+                this.showDOMStorage(database);
>+                database._databasesTreeElement.select();
>+                return;
>+            }
>+        }
>+    },
>+
>     showDatabase: function(database, tableName)
>     {
>         if (!database)
>@@ -175,7 +201,7 @@ WebInspector.DatabasesPanel.prototype = {
>         this.visibleView = view;
> 
>         this.storageViewStatusBarItemsContainer.removeChildren();
>-        var statusBarItems = view.statusBarItems;
>+        var statusBarItems = view.statusBarItems || [];
>         for (var i = 0; i < statusBarItems.length; ++i)
>             this.storageViewStatusBarItemsContainer.appendChild(statusBarItems[i]);
>     },

Actions: View | Formatted Diff | Diff

Attachments on bug 19874: 33039 | 33040 | 33047 | 33057