Attachment 323952 Details for Bug 178365 – Patch

[patch] Patch

bug-178365-20171016155915.patch (text/plain), 7.73 KB, created by Alex Christensen on 2017-10-16 15:59:19 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Christensen

Created: 2017-10-16 15:59:19 PDT

Size: 7.73 KB

patch

obsolete

>Index: LayoutTests/ChangeLog
>===================================================================
>--- LayoutTests/ChangeLog	(revision 223443)
>+++ LayoutTests/ChangeLog	(working copy)
>@@ -1,3 +1,16 @@
>+2017-10-16  Alex Christensen  <achristensen@webkit.org>
>+
>+        De-flakify http/tests/loading/basic-credentials-sent-automatically.html
>+        https://bugs.webkit.org/show_bug.cgi?id=178365
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * http/tests/loading/basic-credentials-sent-automatically-expected.txt:
>+        * http/tests/loading/basic-credentials-sent-automatically.html:
>+        * platform/ios-wk2/TestExpectations:
>+        * platform/mac-wk2/TestExpectations:
>+        * platform/wk2/http/tests/loading/basic-credentials-sent-automatically-expected.txt:
>+
> 2017-10-15  Ryosuke Niwa  <rniwa@webkit.org>
> 
>         Cannot access images included in the content pasted from Microsoft Word
>Index: LayoutTests/http/tests/loading/basic-credentials-sent-automatically-expected.txt
>===================================================================
>--- LayoutTests/http/tests/loading/basic-credentials-sent-automatically-expected.txt	(revision 223407)
>+++ LayoutTests/http/tests/loading/basic-credentials-sent-automatically-expected.txt	(working copy)
>@@ -1,7 +1,8 @@
> main frame - didStartProvisionalLoadForFrame
> main frame - didCommitLoadForFrame
>-frame "-->" - didStartProvisionalLoadForFrame
> main frame - didFinishDocumentLoadForFrame
>+frame "-->" - didStartProvisionalLoadForFrame
>+main frame - didHandleOnloadEventsForFrame
> http://127.0.0.1:8000/loading/resources/subresources/protected-resource.php - didReceiveAuthenticationChallenge - Responding with first:first-pw
> frame "-->" - didCommitLoadForFrame
> frame "-->" - didFinishDocumentLoadForFrame
>@@ -22,7 +23,6 @@ frame "-->"
> frame "-->" - didCommitLoadForFrame
> frame "-->" - didFinishDocumentLoadForFrame
> frame "-->" - didHandleOnloadEventsForFrame
>-main frame - didHandleOnloadEventsForFrame
> frame "-->" - didFinishLoadForFrame
> main frame - didFinishLoadForFrame
> This test makes sure that once an HTTP Basic Auth. protected path is authenticated once, urls that emanate from that path automatically have their credentials sent without a challenge.
>@@ -34,7 +34,7 @@ The third frame's path is also /loading/
> It will be authorized with second/second-pw.
> The fourth frame's path is /loading/resources/othersubresources/protected-resource.php, and we should *not* get a challenge for it, because it has a common subpath with the previously authorized second and third frames.
> It will be authorized with second/second-pw.
>-  
>+
> 
> --------
> Frame: '-->'
>Index: LayoutTests/http/tests/loading/basic-credentials-sent-automatically.html
>===================================================================
>--- LayoutTests/http/tests/loading/basic-credentials-sent-automatically.html	(revision 223407)
>+++ LayoutTests/http/tests/loading/basic-credentials-sent-automatically.html	(working copy)
>@@ -52,9 +52,16 @@ function fourthFrameLoaded()
>         testRunner.notifyDone();
> }
> 
>+function makeIFrame() {
>+    var iframe = document.createElement("iframe");
>+    iframe.onload=firstFrameLoaded;
>+    iframe.src="resources/subresources/protected-resource.php";
>+    document.body.appendChild(iframe);
>+}
>+
> </script>
> </head>
>-<body>
>+<body onload="makeIFrame()">
> This test makes sure that once an HTTP Basic Auth. protected path is authenticated once, urls that emanate from that path automatically have their credentials sent without a challenge.<br>
> The first frame's path is /loading/resources/subresources/protected-resource.php, and we should get a challenge for it.<br>
> It will be authorized with first/first-pw.<br>
>@@ -64,6 +71,5 @@ The third frame's path is also /loading/
> It will be authorized with second/second-pw.<br>
> The fourth frame's path is /loading/resources/othersubresources/protected-resource.php, and we should *not* get a challenge for it, because it has a common subpath with the previously authorized second and third frames.<br>
> It will be authorized with second/second-pw.<br>
>-<iframe src="resources/subresources/protected-resource.php" onload="firstFrameLoaded();"></iframe>
> </body>
> </html>
>Index: LayoutTests/platform/ios-wk2/TestExpectations
>===================================================================
>--- LayoutTests/platform/ios-wk2/TestExpectations	(revision 223407)
>+++ LayoutTests/platform/ios-wk2/TestExpectations	(working copy)
>@@ -1858,8 +1858,6 @@ webkit.org/b/159884 [ Debug ] http/tests
> 
> webkit.org/b/159881 [ Release ] fast/shapes/shape-outside-floats/shape-outside-big-box-border-radius-002.html [ Pass ImageOnlyFailure ]
> 
>-webkit.org/b/159427 http/tests/loading/basic-credentials-sent-automatically.html [ Pass Failure ]
>-
> webkit.org/b/160368 http/tests/xmlhttprequest/workers/methods-async.html [ Pass Timeout ]
> 
> webkit.org/b/161323 media/track/media-element-enqueue-event-crash.html [ Skip ]
>Index: LayoutTests/platform/mac-wk2/TestExpectations
>===================================================================
>--- LayoutTests/platform/mac-wk2/TestExpectations	(revision 223407)
>+++ LayoutTests/platform/mac-wk2/TestExpectations	(working copy)
>@@ -623,8 +623,6 @@ webkit.org/b/159896 storage/indexeddb/mo
> 
> webkit.org/b/160042 accessibility/mac/value-change/value-change-user-info-contenteditable.html [ Pass Failure ]
> 
>-webkit.org/b/159427 http/tests/loading/basic-credentials-sent-automatically.html [ Pass Failure ]
>-
> webkit.org/b/160309 fast/dom/Window/child-window-focus.html [ Pass Failure ]
> 
> webkit.org/b/161148 gamepad/gamepad-timestamp.html [ Pass Failure ]
>Index: LayoutTests/platform/wk2/http/tests/loading/basic-credentials-sent-automatically-expected.txt
>===================================================================
>--- LayoutTests/platform/wk2/http/tests/loading/basic-credentials-sent-automatically-expected.txt	(revision 223407)
>+++ LayoutTests/platform/wk2/http/tests/loading/basic-credentials-sent-automatically-expected.txt	(working copy)
>@@ -1,7 +1,8 @@
> main frame - didStartProvisionalLoadForFrame
> main frame - didCommitLoadForFrame
>-frame "-->" - didStartProvisionalLoadForFrame
> main frame - didFinishDocumentLoadForFrame
>+frame "-->" - didStartProvisionalLoadForFrame
>+main frame - didHandleOnloadEventsForFrame
> 127.0.0.1:8000 - didReceiveAuthenticationChallenge - Responding with first:first-pw
> frame "-->" - didCommitLoadForFrame
> frame "-->" - didFinishDocumentLoadForFrame
>@@ -22,7 +23,6 @@ frame "-->"
> frame "-->" - didCommitLoadForFrame
> frame "-->" - didFinishDocumentLoadForFrame
> frame "-->" - didHandleOnloadEventsForFrame
>-main frame - didHandleOnloadEventsForFrame
> frame "-->" - didFinishLoadForFrame
> main frame - didFinishLoadForFrame
> This test makes sure that once an HTTP Basic Auth. protected path is authenticated once, urls that emanate from that path automatically have their credentials sent without a challenge.
>@@ -34,7 +34,7 @@ The third frame's path is also /loading/
> It will be authorized with second/second-pw.
> The fourth frame's path is /loading/resources/othersubresources/protected-resource.php, and we should *not* get a challenge for it, because it has a common subpath with the previously authorized second and third frames.
> It will be authorized with second/second-pw.
>-  
>+
> 
> --------
> Frame: '-->'

Flags:

aestes: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 178365: 323952