Attachment 320245 Details for Bug 176585 – Patch

[patch] Patch

bug-176585-20170908084958.patch (text/plain), 2.83 KB, created by Frédéric Wang Nélar on 2017-09-07 23:49:59 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Frédéric Wang Nélar

Created: 2017-09-07 23:49:59 PDT

Size: 2.83 KB

patch

obsolete

>Subversion Revision: 221753
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index d8c28053d769cbea17636b2ddfc50b0ea8507663..54d0ec1f9ce96584b2e518757ccbe2f0f79419a2 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,20 @@
>+2017-09-07  Frederic Wang  <fwang@igalia.com>
>+
>+        Use RenderLayerBacking::renderer() when possible
>+        https://bugs.webkit.org/show_bug.cgi?id=176585
>+
>+        The private member renderer() is a shorthand for m_owningLayer.renderer(). This patch uses
>+        it in RenderLayerBacking when possible.
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        No new tests, behavior not changed.
>+
>+        * rendering/RenderLayerBacking.cpp:
>+        (WebCore::RenderLayerBacking::updateGeometry):
>+        (WebCore::RenderLayerBacking::setContentsNeedDisplay):
>+        (WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):
>+
> 2017-09-07  Wenson Hsieh  <wenson_hsieh@apple.com>
> 
>         [Directory Upload] Extend drag and drop support to iOS
>diff --git a/Source/WebCore/rendering/RenderLayerBacking.cpp b/Source/WebCore/rendering/RenderLayerBacking.cpp
>index 3fa7540a13f511695c73fb4a0aa789ef5ba19235..a6e7df2e033137afa90fa43fec155304ca96d5d3 100644
>--- a/Source/WebCore/rendering/RenderLayerBacking.cpp
>+++ b/Source/WebCore/rendering/RenderLayerBacking.cpp
>@@ -1052,7 +1052,7 @@ void RenderLayerBacking::updateGeometry()
>     if (m_maskLayer)
>         updateMaskingLayerGeometry();
>     
>-    if (m_owningLayer.renderer().hasTransformRelatedProperty()) {
>+    if (renderer().hasTransformRelatedProperty()) {
>         // Update properties that depend on layer dimensions.
>         FloatPoint3D transformOrigin = computeTransformOriginForPainting(downcast<RenderBox>(renderer()).borderBoxRect());
>         FloatPoint layerOffset = roundPointToDevicePixels(toLayoutPoint(rendererOffset.fromParentGraphicsLayer()), deviceScaleFactor());
>@@ -2433,7 +2433,7 @@ void RenderLayerBacking::setContentsNeedDisplay(GraphicsLayer::ShouldClipToLayer
> {
>     ASSERT(!paintsIntoCompositedAncestor());
> 
>-    FrameView& frameView = owningLayer().renderer().view().frameView();
>+    FrameView& frameView = renderer().view().frameView();
>     if (m_isMainFrameRenderViewLayer && frameView.isTrackingRepaints())
>         frameView.addTrackedRepaintRect(owningLayer().absoluteBoundingBoxForPainting());
>     
>@@ -2468,7 +2468,7 @@ void RenderLayerBacking::setContentsNeedDisplayInRect(const LayoutRect& r, Graph
>     ASSERT(!paintsIntoCompositedAncestor());
> 
>     FloatRect pixelSnappedRectForPainting = snapRectToDevicePixels(r, deviceScaleFactor());
>-    FrameView& frameView = owningLayer().renderer().view().frameView();
>+    FrameView& frameView = renderer().view().frameView();
>     if (m_isMainFrameRenderViewLayer && frameView.isTrackingRepaints())
>         frameView.addTrackedRepaintRect(pixelSnappedRectForPainting);
>

Actions: View | Formatted Diff | Diff

Attachments on bug 176585: 320245 | 320248 | 320252