Attachment 318346 Details for Bug 175665 – Patch

[patch] Patch

wd-screenshot-size.diff (text/plain), 1.86 KB, created by Carlos Garcia Campos on 2017-08-17 02:59:26 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Carlos Garcia Campos

Created: 2017-08-17 02:59:26 PDT

Size: 1.86 KB

patch

obsolete

>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 11851d5b00c..dc422c7624b 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,19 @@
>+2017-08-17  Carlos Garcia Campos  <cgarcia@igalia.com>
>+
>+        Automation: takeScreenshot should use the visible content rect not the document rect
>+        https://bugs.webkit.org/show_bug.cgi?id=175665
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        According to the spec, we should get the toplevel browsing context document rectangle and take a screenshot of
>+        it using the current viewport width and height. We are currently using the document size.
>+
>+        19. Screen Capture.
>+        https://w3c.github.io/webdriver/webdriver-spec.html#dfn-draw-a-bounding-box-from-the-framebuffer
>+
>+        * WebProcess/Automation/WebAutomationSessionProxy.cpp:
>+        (WebKit::WebAutomationSessionProxy::takeScreenshot): Use FrameView::visibleContentRect().
>+
> 2017-08-16  Andy Estes  <aestes@apple.com>
> 
>         [Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
>diff --git a/Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp b/Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp
>index 07e4ffe6940..f11f6508217 100644
>--- a/Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp
>+++ b/Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp
>@@ -650,7 +650,7 @@ void WebAutomationSessionProxy::takeScreenshot(uint64_t pageID, uint64_t callbac
>         return;
>     }
> 
>-    WebCore::IntRect snapshotRect = WebCore::IntRect(WebCore::IntPoint(0, 0), frameView->contentsSize());
>+    WebCore::IntRect snapshotRect = frameView->visibleContentRect();
>     if (snapshotRect.isEmpty()) {
>         WebProcess::singleton().parentProcessConnection()->send(Messages::WebAutomationSession::DidTakeScreenshot(callbackID, handle, String()), 0);
>         return;

Flags:

bburg: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 175665: 318346