Attachment 317460 Details for Bug 174477 – status bubble link to individual EWS page.

[patch] status bubble link to individual EWS page.

patch1111 (text/plain), 5.63 KB, created by obinna obike on 2017-08-07 13:59:02 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: obinna obike

Created: 2017-08-07 13:59:02 PDT

Size: 5.63 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 220231)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,26 @@
>+2017-08-03  obinna obike  <oobike@apple.com>
>+
>+        Created Individual EWS Pages
>+        https://bugs.webkit.org/show_bug.cgi?id=174477
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Created Individual pages for each EWS in the queue. Also changed the link within each statusbubble
>+        to go directly to the Individual EWS page. I also made changes to the code so that if the number
>+        of items in the queue is zero then it displays a message that says waiting in the queue processing, hasn't started yet.
>+        I also added a link to the list of all of the EWS queues at the bottom.
>+
>+        * QueueStatusServer/handlers/patch.py:
>+        (Patch.get): made changes to the code to allow to go the all ews queue page or the individual ews page.
>+        * QueueStatusServer/handlers/statusbubble.py:
>+        (StatusBubble._build_bubble):
>+        * QueueStatusServer/main.py:
>+        added a link to the individual ews in the routes dictionary.
>+        * QueueStatusServer/templates/patch.html:
>+        added a link to go directly to the page with all ews queues.
>+        * QueueStatusServer/templates/statusbubble.html:
>+        if you click on a statusbubble it takes you directly to the individual ews page.
>+
> 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
> 
>         [GTK][WKE] Pass the --memory-limited option on the GTK and WPE buildbots for the JSC tests.
>Index: Tools/QueueStatusServer/main.py
>===================================================================
>--- Tools/QueueStatusServer/main.py	(revision 219533)
>+++ Tools/QueueStatusServer/main.py	(working copy)
>@@ -64,6 +64,7 @@ routes = [
>     ('/gc', GC),
>     ('/sync-queue-logs', SyncQueueLogs),
>     (r'/patch-status/(.*)/(.*)', PatchStatus),
>+    (r'/patch/(.*)/(.*)', Patch),
>     (r'/patch/(.*)', Patch),
>     ('/submit-to-ews', SubmitToEWS),
>     (r'/results/(.*)', ShowResults),
>Index: Tools/QueueStatusServer/handlers/patch.py
>===================================================================
>--- Tools/QueueStatusServer/handlers/patch.py	(revision 219533)
>+++ Tools/QueueStatusServer/handlers/patch.py	(working copy)
>@@ -33,7 +33,7 @@ from model.queuestatus import QueueStatu
> 
> 
> class Patch(webapp.RequestHandler):
>-    def get(self, attachment_id_string):
>+    def get(self, attachment_id_string, queue_name=None):
>         attachment_id = int(attachment_id_string)
>         statuses = QueueStatus.all().filter("active_patch_id =", attachment_id).order("-date")
> 
>@@ -41,10 +41,10 @@ class Patch(webapp.RequestHandler):
>         queue_status = {}
>         for status in statuses:
>             bug_id = status.active_bug_id # Should be the same for every status.
>-            per_queue_statuses = queue_status.get(status.queue_name, [])
>-            per_queue_statuses.append(status)
>-            queue_status[status.queue_name] = per_queue_statuses
>-
>+            if status.queue_name == queue_name or queue_name is None:
>+                per_queue_statuses = queue_status.get(status.queue_name, [])
>+                per_queue_statuses.append(status)
>+                queue_status[status.queue_name] = per_queue_statuses
>         template_values = {
>             "attachment_id" : attachment_id,
>             "bug_id" : bug_id,
>Index: Tools/QueueStatusServer/handlers/statusbubble.py
>===================================================================
>--- Tools/QueueStatusServer/handlers/statusbubble.py	(revision 219533)
>+++ Tools/QueueStatusServer/handlers/statusbubble.py	(working copy)
>@@ -113,6 +113,7 @@ class StatusBubble(webapp.RequestHandler
>         bubble = {
>             "name": queue.short_name().lower(),
>             "attachment_id": attachment.id,
>+            "queue_name": queue.name(),
>         }
>         # 10 recent statuses is enough to always include a resultative one, if there were any at all.
>         statuses = QueueStatus.all().filter('queue_name =', queue.name()).filter('active_patch_id =', attachment.id).order('-date').fetch(limit=10)
>Index: Tools/QueueStatusServer/templates/patch.html
>===================================================================
>--- Tools/QueueStatusServer/templates/patch.html	(revision 219533)
>+++ Tools/QueueStatusServer/templates/patch.html	(working copy)
>@@ -7,7 +7,11 @@
> <body>
> <h1>
>   Patch {{ attachment_id|force_escape|webkit_attachment_id|safe }} (Bug {{ bug_id|force_escape|webkit_bug_id|safe }})
>-</h1>{% for queue_name, statuses in queue_status.items %}
>+</h1>
>+{% if queue_status|length == 0 %}
>+<p> Waiting in Queue, Processing has not started yet. </p>
>+{% endif %}
>+{% for queue_name, statuses in queue_status.items %}
> <div class="status-details">
>   <h2>{{ queue_name }}</h2>
>   <ul>{% for status in statuses %}
>@@ -19,4 +23,8 @@
>     </li>{% endfor %}
>   </ul>
> </div>{% endfor %}
>+{% if queue_status|length == 1 or queue_status|length == 0  %}
>+<br>
>+<a href="/patch/{{ attachment_id }}">All EWS Queues</a>
>+{% endif %}
> </html>
>Index: Tools/QueueStatusServer/templates/statusbubble.html
>===================================================================
>--- Tools/QueueStatusServer/templates/statusbubble.html	(revision 219533)
>+++ Tools/QueueStatusServer/templates/statusbubble.html	(working copy)
>@@ -77,7 +77,7 @@ window.addEventListener("message", funct
>   {% else %}
>   {% for bubble in bubbles %}
>   <a class="status {{ bubble.state }}" target="_top"
>-      href="/patch/{{ bubble.attachment_id }}"
>+      href="/patch/{{ bubble.attachment_id }}/{{ bubble.queue_name }}"
>   {% if bubble.details_message %}
>       title="{{ bubble.details_message }}"
>   {% endif %}

Actions: View | Formatted Diff | Diff

Attachments on bug 174477: 315961 | 317149 | 317428 | 317447 | 317460 | 317581 | 317646 | 317647