Attachment 317224 Details for Bug 175179 – Proposed patch

[patch] Proposed patch

bug-175179.diff (text/plain), 1.38 KB, created by Andreas Kling on 2017-08-04 01:12:25 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Andreas Kling

Created: 2017-08-04 01:12:25 PDT

Size: 1.38 KB

patch

obsolete

>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 534e23e8d70..3b348b2d286 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,17 @@
>+2017-08-04  Andreas Kling  <akling@apple.com>
>+
>+        NetworkLoad should always invoke its redirect completion handler
>+        https://bugs.webkit.org/show_bug.cgi?id=175179
>+        <rdar://problem/33464999>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Make sure the redirect completion handler is always invoked,
>+        just like we already did for the response completion handler.
>+
>+        * NetworkProcess/NetworkLoad.cpp:
>+        (WebKit::NetworkLoad::~NetworkLoad):
>+
> 2017-08-03  Brian Burg  <bburg@apple.com>
> 
>         Remove ENABLE(WEB_SOCKET) guards
>diff --git a/Source/WebKit/NetworkProcess/NetworkLoad.cpp b/Source/WebKit/NetworkProcess/NetworkLoad.cpp
>index 9c8c6c0e6a1..04747c40a02 100644
>--- a/Source/WebKit/NetworkProcess/NetworkLoad.cpp
>+++ b/Source/WebKit/NetworkProcess/NetworkLoad.cpp
>@@ -135,6 +135,8 @@ NetworkLoad::~NetworkLoad()
> #if USE(NETWORK_SESSION)
>     if (m_responseCompletionHandler)
>         m_responseCompletionHandler(PolicyIgnore);
>+    if (m_redirectCompletionHandler)
>+        m_redirectCompletionHandler({ });
> #if USE(PROTECTION_SPACE_AUTH_CALLBACK)
>     if (m_challengeCompletionHandler)
>         m_challengeCompletionHandler(AuthenticationChallengeDisposition::Cancel, { });

Actions: View | Formatted Diff | Diff

Attachments on bug 175179: 317224