Attachment 317133 Details for Bug 175076 – Patch

[patch] Patch

bug-175076-20170803113257.patch (text/plain), 4.09 KB, created by Chris Dumez on 2017-08-03 11:32:57 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Dumez

Created: 2017-08-03 11:32:57 PDT

Size: 4.09 KB

patch

obsolete

>Subversion Revision: 220205
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 3ab11062f1b30c64f777bddb73d9c51ac98a4b07..877ef4741a503d37356e2a44c38da4e5a9944ec1 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,19 @@
>+2017-08-03  Chris Dumez  <cdumez@apple.com>
>+
>+        Multiple Layout tests from web-platform-tests/beacon/ are timing out.
>+        https://bugs.webkit.org/show_bug.cgi?id=175076
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * NetworkProcess/NetworkLoad.cpp:
>+        (WebKit::NetworkLoad::completeAuthenticationChallenge):
>+        In the NETWORK_SESSION code path, we did not ask the client about server trust evaluation
>+        when the clientCredentialPolicy was CannotAskClientForCredentials. This is because the
>+        same delegate is used for HTTP authentication and server trust evaluation in the
>+        NETWORK_SESSION code path. To align both code paths, we now ask the client about server
>+        trust evaluation even if the policy CannotAskClientForCredentials. This allows WKTR
>+        to trust certificates for localhost / 127.0.0.1 unconditionally and consistently.
>+
> 2017-08-02  Chris Dumez  <cdumez@apple.com>
> 
>         NetworkResourceLoader::setDefersLoading() may cause start() to be called multiple times
>diff --git a/Source/WebKit/NetworkProcess/NetworkLoad.cpp b/Source/WebKit/NetworkProcess/NetworkLoad.cpp
>index 5173e79c1ffba2443c0d73c6e88dcaccb2154d53..9c8c6c0e6a1077bfb36d63c8a43c77332559e49e 100644
>--- a/Source/WebKit/NetworkProcess/NetworkLoad.cpp
>+++ b/Source/WebKit/NetworkProcess/NetworkLoad.cpp
>@@ -337,7 +337,8 @@ void NetworkLoad::didReceiveChallenge(const AuthenticationChallenge& challenge,
> 
> void NetworkLoad::completeAuthenticationChallenge(ChallengeCompletionHandler&& completionHandler)
> {
>-    if (m_parameters.clientCredentialPolicy == ClientCredentialPolicy::CannotAskClientForCredentials) {
>+    bool isServerTrustEvaluation = m_challenge->protectionSpace().authenticationScheme() == ProtectionSpaceAuthenticationSchemeServerTrustEvaluationRequested;
>+    if (m_parameters.clientCredentialPolicy == ClientCredentialPolicy::CannotAskClientForCredentials && !isServerTrustEvaluation) {
>         completionHandler(AuthenticationChallengeDisposition::UseCredential, { });
>         return;
>     }
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 6a7debdf060471e0bf3a8536f64d608e8f38533b..75e7f6cb18d955af189c8465a1f97d6cffa99e65 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,14 @@
>+2017-08-03  Chris Dumez  <cdumez@apple.com>
>+
>+        Multiple Layout tests from web-platform-tests/beacon/ are timing out.
>+        https://bugs.webkit.org/show_bug.cgi?id=175076
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Unskip tests that no longer time out on WebKit2.
>+
>+        * platform/wk2/TestExpectations:
>+
> 2017-08-03  Ms2ger  <Ms2ger@igalia.com>
> 
>         [GTK] Remove obsolete failure expectation for narrow-non-breaking-space.html.
>diff --git a/LayoutTests/platform/wk2/TestExpectations b/LayoutTests/platform/wk2/TestExpectations
>index ab2d7b2a9cfc93d0e24727af2a44317d71aaa12a..42f7b55ff1cf8efafeed9074d36352da7c4c78d7 100644
>--- a/LayoutTests/platform/wk2/TestExpectations
>+++ b/LayoutTests/platform/wk2/TestExpectations
>@@ -213,12 +213,6 @@ http/tests/download/default-encoding.html
> http/tests/download/inherited-encoding-form-submission-result.html
> http/tests/download/inherited-encoding.html
> 
>-# Those tests are loaded over HTTPS and pass locally. However, they get an SSL error on the bots and time out.
>-webkit.org/b/175076 imported/w3c/web-platform-tests/beacon/headers/header-referrer-no-referrer-when-downgrade.https.html [ Skip ]
>-webkit.org/b/175076 imported/w3c/web-platform-tests/beacon/headers/header-referrer-strict-origin-when-cross-origin.https.html [ Skip ]
>-webkit.org/b/175076 imported/w3c/web-platform-tests/beacon/headers/header-referrer-strict-origin.https.html [ Skip ]
>-webkit.org/b/175076 imported/w3c/web-platform-tests/beacon/headers/header-referrer-unsafe-url.https.html [ Skip ]
>-
> ### END OF (1) Classified failures with bug reports
> ########################################
>

Actions: View | Formatted Diff | Diff

Attachments on bug 175076: 317133 | 317153 | 317162 | 317164 | 317176