Attachment 316981 Details for Bug 173667 – Sorted the EWS on the Patch Page

[patch] Sorted the EWS on the Patch Page

patch1 (text/plain), 1.87 KB, created by obinna obike on 2017-08-02 12:02:25 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: obinna obike

Created: 2017-08-02 12:02:25 PDT

Size: 1.87 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 220109)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2017-08-01  obinna obike  <oobike@apple.com>
>+
>+        Unsorted EWS on patch page
>+        https://bugs.webkit.org/show_bug.cgi?id=175043
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * QueueStatusServer/handlers/patch.py:
>+        (Patch.get):
>+        * QueueStatusServer/templates/patch.html:
>+
> 2017-07-26  Jiewen Tan  <jiewen_tan@apple.com>
> 
>         Add tests to detect mistakes in backward compatibility when the structured clone algorithm is changed in the future
>Index: Tools/QueueStatusServer/handlers/patch.py
>===================================================================
>--- Tools/QueueStatusServer/handlers/patch.py	(revision 219533)
>+++ Tools/QueueStatusServer/handlers/patch.py	(working copy)
>@@ -44,7 +44,7 @@ class Patch(webapp.RequestHandler):
>             per_queue_statuses = queue_status.get(status.queue_name, [])
>             per_queue_statuses.append(status)
>             queue_status[status.queue_name] = per_queue_statuses
>-
>+        queue_status = sorted(queue_status.items())
>         template_values = {
>             "attachment_id" : attachment_id,
>             "bug_id" : bug_id,
>Index: Tools/QueueStatusServer/templates/patch.html
>===================================================================
>--- Tools/QueueStatusServer/templates/patch.html	(revision 219533)
>+++ Tools/QueueStatusServer/templates/patch.html	(working copy)
>@@ -7,7 +7,7 @@
> <body>
> <h1>
>   Patch {{ attachment_id|force_escape|webkit_attachment_id|safe }} (Bug {{ bug_id|force_escape|webkit_bug_id|safe }})
>-</h1>{% for queue_name, statuses in queue_status.items %}
>+</h1>{% for queue_name, statuses in queue_status %}
> <div class="status-details">
>   <h2>{{ queue_name }}</h2>
>   <ul>{% for status in statuses %}

Actions: View | Formatted Diff | Diff

Attachments on bug 173667: 315720 | 315850 | 315858 | 316981 | 317441 | 317458 | 317488 | 317489