Attachment 315244 Details for Bug 174157 – Patch

[patch] Patch

bug-174157-20170712174341.patch (text/plain), 2.19 KB, created by Miguel Gomez on 2017-07-12 08:43:42 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Miguel Gomez

Created: 2017-07-12 08:43:42 PDT

Size: 2.19 KB

patch

obsolete

>Subversion Revision: 219392
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 1b2ec6741bb700070151b6d0e215aba075a758cd..74f7979e94d72580814c246a292f5b369540ba15 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,22 @@
>+2017-07-12  Miguel Gomez  <magomez@igalia.com>
>+
>+        [GTK][WPE] border-radius with non visible border doesn't work on images that have their own RenderLayer
>+        https://bugs.webkit.org/show_bug.cgi?id=174157
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Do not allow direct compositing of images when they have a border-radius property on WebKitGTK+ and WPE.
>+        These platforms don't support clipping using rounded rectangles during composition, which is required
>+        when using border-radius and the border is not visible. Due to this, they need to perform the clippping
>+        with cairo.
>+
>+        This is a temporal fix, until appropriate clipping is implemented in the TextureMapper.
>+
>+        No new tests.
>+
>+        * rendering/RenderLayerBacking.cpp:
>+        (WebCore::RenderLayerBacking::isDirectlyCompositedImage):
>+
> 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
> 
>         [GCrypt] Implement CryptoKeyEC PKCS#8 exports
>diff --git a/Source/WebCore/rendering/RenderLayerBacking.cpp b/Source/WebCore/rendering/RenderLayerBacking.cpp
>index 45b16499d7dfdd3baad21e64935dce661ea30705..68c884238b3c71d7fe533db967db8705b9dd665e 100644
>--- a/Source/WebCore/rendering/RenderLayerBacking.cpp
>+++ b/Source/WebCore/rendering/RenderLayerBacking.cpp
>@@ -2228,6 +2228,14 @@ bool RenderLayerBacking::isDirectlyCompositedImage() const
>         if (image->orientationForCurrentFrame() != DefaultImageOrientation)
>             return false;
> 
>+#if (PLATFORM(GTK) || PLATFORM(WPE))
>+        // GTK and WPE ports don't support rounded rect clipping at TextureMapper level, so they cannot
>+        // directly composite images that have border-radius propery. Draw them as non directly composited
>+        // content instead. See https://bugs.webkit.org/show_bug.cgi?id=174157.
>+        if (imageRenderer.style().hasBorderRadius())
>+            return false;
>+#endif
>+
>         return m_graphicsLayer->shouldDirectlyCompositeImage(image);
>     }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 174157: 315231 | 315237 | 315238 | 315239 | 315244 | 315251