Attachment 309322 Details for Bug 171792 – Patch

[patch] Patch

bug-171792-20170507160850.patch (text/plain), 1.88 KB, created by Adrian Perez on 2017-05-07 06:08:51 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Adrian Perez

Created: 2017-05-07 06:08:51 PDT

Size: 1.88 KB

patch

obsolete

>Subversion Revision: 216347
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 9c1b9611adecba0f1fb43bc0ff12538f97f77376..25f27ccceb09283a3ff6c47b450ba2eaab2a0249 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,20 @@
>+2017-05-07  Adrian Perez de Castro  <aperez@igalia.com>
>+
>+        [GTK] Test cases for typehead in form menu lists should start from known state
>+        https://bugs.webkit.org/show_bug.cgi?id=171792
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Since r171792 opening a popup menu in a form pre-selects the active
>+        element to mimic GtkComboxBox behavior, but the layout test implicitly
>+        assumed that type ahead search always started the beginning of the
>+        list, which is no longer true now that GTK+ is informed of which one
>+        is the active element.
>+
>+        * platform/gtk/fast/forms/menulist-typeahead-find.html: Reset menu
>+        list to the initial state (no element selected, unfocused) at the
>+        beginning of testTypeAheadFunction().
>+
> 2017-05-07  Sam Weinig  <sam@webkit.org>
> 
>         Implement Subresource Integrity (SRI)
>diff --git a/LayoutTests/platform/gtk/fast/forms/menulist-typeahead-find.html b/LayoutTests/platform/gtk/fast/forms/menulist-typeahead-find.html
>index 52677fb293c1439129be7c644833a4cce5f584cd..f98979fc77236df90633c916b598b399c9ec45db 100644
>--- a/LayoutTests/platform/gtk/fast/forms/menulist-typeahead-find.html
>+++ b/LayoutTests/platform/gtk/fast/forms/menulist-typeahead-find.html
>@@ -20,6 +20,10 @@ function testTypeAheadFind(keys, expectedMenuListText)
>     if (!window.eventSender)
>         return;
> 
>+    // Reset menu list to initial state.
>+    menulist.selectedIndex = -1;
>+    menulist.blur();
>+
>     eventSender.mouseMoveTo(menulist.offsetLeft + (menulist.offsetWidth / 2), menulist.offsetTop + (menulist.offsetHeight / 2));
>     eventSender.mouseDown();
>     eventSender.mouseUp();

Actions: View | Formatted Diff | Diff

Attachments on bug 171792: 309321 | 309322 | 309327