Attachment 293208 Details for Bug 164150 – Patch

[patch] Patch

patch.txt (text/plain), 2.24 KB, created by Dave Hyatt on 2016-10-28 13:59:22 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Dave Hyatt

Created: 2016-10-28 13:59:22 PDT

Size: 2.24 KB

patch

obsolete

>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 208067)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2016-10-28  Dave Hyatt  <hyatt@apple.com>
>+
>+        [CSS Parser] Support initial-letter
>+        https://bugs.webkit.org/show_bug.cgi?id=164150
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * css/parser/CSSPropertyParser.cpp:
>+        (WebCore::consumeInitialLetter):
>+        (WebCore::CSSPropertyParser::parseSingleValue):
>+
> 2016-10-28  Sam Weinig  <sam@webkit.org>
> 
>         [WebIDL] Update parser and code generators to only access type information through the type property
>Index: Source/WebCore/css/parser/CSSPropertyParser.cpp
>===================================================================
>--- Source/WebCore/css/parser/CSSPropertyParser.cpp	(revision 208061)
>+++ Source/WebCore/css/parser/CSSPropertyParser.cpp	(working copy)
>@@ -3125,6 +3125,27 @@ static RefPtr<CSSValue> consumeLineGrid(
>     return consumeCustomIdent(range);
> }
> 
>+static RefPtr<CSSValue> consumeInitialLetter(CSSParserTokenRange& range)
>+{
>+    RefPtr<CSSValue> ident = consumeIdent<CSSValueNormal>(range);
>+    if (ident)
>+        return ident;
>+    
>+    RefPtr<CSSPrimitiveValue> height = consumeNumber(range, ValueRangeNonNegative);
>+    if (!height)
>+        return nullptr;
>+    
>+    RefPtr<CSSPrimitiveValue> position;
>+    if (!range.atEnd()) {
>+        position = consumeNumber(range, ValueRangeNonNegative);
>+        if (!position || !range.atEnd())
>+            return nullptr;
>+    } else
>+        position = height.copyRef();
>+    
>+    return createPrimitiveValuePair(position.releaseNonNull(), WTFMove(height));
>+}
>+
> static RefPtr<CSSValue> consumeWebkitMarqueeIncrement(CSSParserTokenRange& range, CSSParserMode cssParserMode)
> {
>     if (range.peek().type() == IdentToken)
>@@ -3516,6 +3537,8 @@ RefPtr<CSSValue> CSSPropertyParser::pars
> #endif
>     case CSSPropertyWebkitLineGrid:
>         return consumeLineGrid(m_range);
>+    case CSSPropertyWebkitInitialLetter:
>+        return consumeInitialLetter(m_range);
>     case CSSPropertyWebkitMarqueeIncrement:
>         return consumeWebkitMarqueeIncrement(m_range, m_context.mode);
>     case CSSPropertyWebkitMarqueeRepetition:

Flags:

simon.fraser: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 164150: 293208