Attachment 291772 Details for Bug 162920 – Patch

[patch] Patch

bug-162920-20161016190924.patch (text/plain), 3.25 KB, created by Enrique Ocaña on 2016-10-16 12:12:56 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Enrique Ocaña

Created: 2016-10-16 12:12:56 PDT

Size: 3.25 KB

patch

obsolete

>Subversion Revision: 207345
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 2ea79f0df443680844dc0d06b16f9a49c7fb2a89..488514acfcbba316deafc4e0178c678022f32ad6 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,5 +1,20 @@
> 2016-10-04  Enrique OcaÃ±a GonzÃ¡lez  <eocanha@igalia.com>
> 
>+        [MSE] Expose additional MediaSource methods to MediaSourcePrivate
>+        https://bugs.webkit.org/show_bug.cgi?id=162920
>+
>+        Reviewed by Xabier Rodriguez-Calvar.
>+
>+        The GStreamer MSE platform implementation needs to report duration changes and trigger
>+        monitorSourceBuffers() calls.
>+
>+        * Modules/mediasource/MediaSource.cpp:
>+        (WebCore::MediaSource::durationChanged):
>+        * Modules/mediasource/MediaSource.h:
>+        * platform/graphics/MediaSourcePrivateClient.h:
>+
>+2016-10-04  Enrique OcaÃ±a GonzÃ¡lez  <eocanha@igalia.com>
>+
>         [GStreamer][EME] ClearKey decryption support
>         https://bugs.webkit.org/show_bug.cgi?id=162918
> 
>diff --git a/Source/WebCore/Modules/mediasource/MediaSource.cpp b/Source/WebCore/Modules/mediasource/MediaSource.cpp
>index 137869705610ffc40ba4e317783b76a00f0e9e4e..22a0b3c3e1f5d8f6810de258249565e7a340015f 100644
>--- a/Source/WebCore/Modules/mediasource/MediaSource.cpp
>+++ b/Source/WebCore/Modules/mediasource/MediaSource.cpp
>@@ -147,6 +147,11 @@ MediaTime MediaSource::duration() const
>     return m_duration;
> }
> 
>+void MediaSource::durationChanged(const MediaTime& duration)
>+{
>+    m_duration = duration;
>+}
>+
> MediaTime MediaSource::currentTime() const
> {
>     return m_mediaElement ? m_mediaElement->currentMediaTime() : MediaTime::zeroTime();
>diff --git a/Source/WebCore/Modules/mediasource/MediaSource.h b/Source/WebCore/Modules/mediasource/MediaSource.h
>index fa3797acffefa05e6b062d28dfb52156f7ea758b..37f113ce0890de3eb5a656ab1f9e2803ea473912 100644
>--- a/Source/WebCore/Modules/mediasource/MediaSource.h
>+++ b/Source/WebCore/Modules/mediasource/MediaSource.h
>@@ -68,11 +68,12 @@ public:
>     void streamEndedWithError(Optional<EndOfStreamError>);
> 
>     MediaTime duration() const final;
>+    void durationChanged(const MediaTime&) final;
>     std::unique_ptr<PlatformTimeRanges> buffered() const final;
> 
>     bool attachToElement(HTMLMediaElement&);
>     void detachFromElement(HTMLMediaElement&);
>-    void monitorSourceBuffers();
>+    void monitorSourceBuffers() override;
>     bool isSeeking() const { return m_pendingSeekTime.isValid(); }
>     Ref<TimeRanges> seekable();
>     ExceptionOr<void> setLiveSeekableRange(double start, double end);
>diff --git a/Source/WebCore/platform/graphics/MediaSourcePrivateClient.h b/Source/WebCore/platform/graphics/MediaSourcePrivateClient.h
>index bb5cc575b606db91572ad0302faf2456180aa65c..3f6863593a68efc1fb230e2d9b0322d265b71e6e 100644
>--- a/Source/WebCore/platform/graphics/MediaSourcePrivateClient.h
>+++ b/Source/WebCore/platform/graphics/MediaSourcePrivateClient.h
>@@ -41,8 +41,10 @@ public:
> 
>     virtual void setPrivateAndOpen(Ref<MediaSourcePrivate>&&) = 0;
>     virtual MediaTime duration() const = 0;
>+    virtual void durationChanged(const MediaTime&) = 0;
>     virtual std::unique_ptr<PlatformTimeRanges> buffered() const = 0;
>     virtual void seekToTime(const MediaTime&) = 0;
>+    virtual void monitorSourceBuffers() = 0;
> };
> 
> }

Actions: View | Formatted Diff | Diff

Attachments on bug 162920: 290618 | 291046 | 291772 | 292902