Attachment 290103 Details for Bug 162461 – patch for landing

[patch] patch for landing

blah.patch (text/plain), 1.28 KB, created by Filip Pizlo on 2016-09-28 11:31:45 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Filip Pizlo

Created: 2016-09-28 11:31:45 PDT

Size: 1.28 KB

patch

obsolete

>Index: Source/JavaScriptCore/ChangeLog
>===================================================================
>--- Source/JavaScriptCore/ChangeLog	(revision 206529)
>+++ Source/JavaScriptCore/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2016-09-28  Filip Pizlo  <fpizlo@apple.com>
>+
>+        Store-load fences should be a lot cheaper on ARM
>+        https://bugs.webkit.org/show_bug.cgi?id=162461
>+
>+        Rubber stamped by Keith Miller.
>+
>+        It turns out that they are already cheap enough, so this change just make us use them.
>+
>+        * heap/SlotVisitor.cpp:
>+        (JSC::SlotVisitor::visitChildren):
>+
> 2016-09-28  Ryan Haddad  <ryanhaddad@apple.com>
> 
>         Unreviewed, rolling out r206522.
>Index: Source/JavaScriptCore/heap/SlotVisitor.cpp
>===================================================================
>--- Source/JavaScriptCore/heap/SlotVisitor.cpp	(revision 206524)
>+++ Source/JavaScriptCore/heap/SlotVisitor.cpp	(working copy)
>@@ -300,10 +300,7 @@ ALWAYS_INLINE void SlotVisitor::visitChi
>     
>     cell->setCellState(blacken(cell->cellState()));
>     
>-    // FIXME: Make this work on ARM also.
>-    // https://bugs.webkit.org/show_bug.cgi?id=162461
>-    if (isX86())
>-        WTF::storeLoadFence();
>+    WTF::storeLoadFence();
>     
>     switch (cell->type()) {
>     case StringType:

Actions: View | Formatted Diff | Diff

Attachments on bug 162461: 290103