Attachment 287717 Details for Bug 161522 – Patch

[patch] Patch

bug-161522-20160901195128.patch (text/plain), 3.56 KB, created by Yusuke Suzuki on 2016-09-01 19:53:43 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Yusuke Suzuki

Created: 2016-09-01 19:53:43 PDT

Size: 3.56 KB

patch

obsolete

>Subversion Revision: 205291
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 7cf350512937fa78726890414c5098181c8b1602..d9f58627c33f25faa5365e0173ddbe282ace8546 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,14 @@
>+2016-09-01  Yusuke Suzuki  <utatane.tea@gmail.com>
>+
>+        Add toJS for JSC::PrivateName
>+        https://bugs.webkit.org/show_bug.cgi?id=161522
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Add the export annotation.
>+
>+        * runtime/Symbol.h:
>+
> 2016-09-01  Csaba OsztrogonÃ¡c  <ossy@webkit.org>
> 
>         Unreviewed ARM buildfix after r205283.
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 550f5c6cafdb83545ee87c1f304d3b451b367bb7..8755b3c4e941cbb91438852b670610779551edf9 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,20 @@
>+2016-09-01  Yusuke Suzuki  <utatane.tea@gmail.com>
>+
>+        Add toJS for JSC::PrivateName
>+        https://bugs.webkit.org/show_bug.cgi?id=161522
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        No new tests (OOPS!).
>+
>+        JSC::PrivateName is the wrapper to create and hold the ES6 Symbol instance.
>+        This patch adds toJS support for JSC::PrivateName.
>+        Later, the module integration patch will use this feature to call
>+        DeferredWrapper::{resolve,reject} with JSC::PrivateName.
>+
>+        * bindings/js/JSDOMBinding.h:
>+        (WebCore::toJS):
>+
> 2016-09-01  Fujii Hironori  <Hironori.Fujii@sony.com>
> 
>         Fix the Mac cmake clean build issue
>diff --git a/Source/JavaScriptCore/runtime/Symbol.h b/Source/JavaScriptCore/runtime/Symbol.h
>index 933a2e5184ab99ff26fcc12f6230b8d03ee19d80..8c703063a134e5e36246a949079a7a5138a2c116 100644
>--- a/Source/JavaScriptCore/runtime/Symbol.h
>+++ b/Source/JavaScriptCore/runtime/Symbol.h
>@@ -49,7 +49,7 @@ class Symbol final : public JSCell {
> 
>     static Symbol* create(VM&);
>     static Symbol* create(ExecState*, JSString* description);
>-    static Symbol* create(VM&, SymbolImpl& uid);
>+    JS_EXPORT_PRIVATE static Symbol* create(VM&, SymbolImpl& uid);
> 
>     const PrivateName& privateName() const { return m_privateName; }
>     String descriptiveString() const;
>diff --git a/Source/WebCore/bindings/js/JSDOMBinding.h b/Source/WebCore/bindings/js/JSDOMBinding.h
>index d416b602cbaaa06e76e639ca8bae1734c6149ceb..a328eb174640e630e15d2630178d2bfba2972110 100644
>--- a/Source/WebCore/bindings/js/JSDOMBinding.h
>+++ b/Source/WebCore/bindings/js/JSDOMBinding.h
>@@ -263,6 +263,7 @@ template<typename T> JSC::JSValue toJS(JSC::ExecState*, JSDOMGlobalObject*, RefP
> template<typename T> JSC::JSValue toJS(JSC::ExecState*, JSDOMGlobalObject*, const Vector<T>&);
> template<typename T> JSC::JSValue toJS(JSC::ExecState*, JSDOMGlobalObject*, const Vector<RefPtr<T>>&);
> JSC::JSValue toJS(JSC::ExecState*, JSDOMGlobalObject*, const String&);
>+JSC::JSValue toJS(JSC::ExecState*, JSDOMGlobalObject*, const JSC::PrivateName&);
> 
> JSC::JSValue toJSIterator(JSC::ExecState&, JSDOMGlobalObject&, JSC::JSValue);
> template<typename T> JSC::JSValue toJSIterator(JSC::ExecState&, JSDOMGlobalObject&, const T&);
>@@ -575,6 +576,11 @@ inline JSC::JSValue toJS(JSC::ExecState* exec, JSDOMGlobalObject*, const String&
>     return jsStringOrNull(exec, value);
> }
> 
>+inline JSC::JSValue toJS(JSC::ExecState* exec, JSDOMGlobalObject*, const JSC::PrivateName& privateName)
>+{
>+    return JSC::Symbol::create(exec->vm(), *privateName.uid());
>+}
>+
> inline JSC::JSValue toJSIterator(JSC::ExecState& state, JSDOMGlobalObject&, JSC::JSValue value)
> {
>     return createIteratorResultObject(&state, value, false);

Actions: View | Formatted Diff | Diff

Attachments on bug 161522: 287717 | 287721