Attachment 282740 Details for Bug 159398 – Patch

[patch] Patch

bug-159398-20160704200425.patch (text/plain), 1.91 KB, created by Caio Lima on 2016-07-04 20:04:57 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Caio Lima

Created: 2016-07-04 20:04:57 PDT

Size: 1.91 KB

patch

obsolete

>Subversion Revision: 202811
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index d3ef4d4d509f2cea2f6c23745547a26259b439da..f18b4c10d5684314d41b7ec5c317cbbdad85aab8 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2016-07-04  Caio Lima  <ticaiolima@gmail.com>
>+
>+        [test262] Fixing "Mapped arguments object with non-configurable property" test case
>+        https://bugs.webkit.org/show_bug.cgi?id=159398
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This patches fixes some test cases of ECMAScript test262 suite of
>+        Mapped arguments object with non-configurable property case.
>+
>+        * runtime/GenericArgumentsInlines.h:
>+        (JSC::GenericArguments<Type>::defineOwnProperty):
>+
> 2016-07-03  Per Arne Vollan  <pvollan@apple.com>
> 
>         [Win] DLLs are missing version information.
>diff --git a/Source/JavaScriptCore/runtime/GenericArgumentsInlines.h b/Source/JavaScriptCore/runtime/GenericArgumentsInlines.h
>index 654fb54a3563820902d6bb1c004015ee3ef88957..9c206f6d27eed306cebc276834e896e5f7d387d9 100644
>--- a/Source/JavaScriptCore/runtime/GenericArgumentsInlines.h
>+++ b/Source/JavaScriptCore/runtime/GenericArgumentsInlines.h
>@@ -199,10 +199,10 @@ bool GenericArguments<Type>::defineOwnProperty(JSObject* object, ExecState* exec
>                 // ignore the request to change enumerability. We appear to have always done so, in
>                 // cases where the argument was still aliased.
>                 // FIXME: https://bugs.webkit.org/show_bug.cgi?id=141952
>-                if (descriptor.writable())
>+                if (!descriptor.writablePresent() || descriptor.writable())
>                     return true;
>             }
>-        
>+
>             // If the property is a non-deleted argument, then move it into the base object and
>             // then delete it.
>             JSValue value = thisObject->getIndexQuickly(index);

Actions: View | Formatted Diff | Diff

Attachments on bug 159398: 282740 | 282742 | 282743 | 282744 | 282745 | 283286 | 283499 | 283504 | 283505 | 283509 | 283742 | 283766 | 284980 | 284981 | 284982 | 284983 | 284984 | 284985 | 289955 | 289969 | 289970 | 289975 | 289979 | 290296 | 290303 | 290305 | 290306 | 290326 | 290344 | 290350 | 290429 | 290583 | 291051 | 291932 | 294029 | 295654 | 297500 | 297526 | 297747