Attachment 281728 Details for Bug 158982 – Patch

[patch] Patch

bug-158982-20160621125000.patch (text/plain), 13.57 KB, created by youenn fablet on 2016-06-21 03:50:09 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2016-06-21 03:50:09 PDT

Size: 13.57 KB

patch

obsolete

>Subversion Revision: 202271
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 2668d633c5fc4ee1cb4419bf7ed244c913427a70..7af8fb8470fb286df451839515701351a4aff9a6 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2016-06-21  Youenn Fablet  <youennf@gmail.com>
>+
>+        [Fetch API] Rename 'origin-only' referrer policy to 'origin'
>+        https://bugs.webkit.org/show_bug.cgi?id=158982
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Covered by updated tests.
>+
>+        * Modules/fetch/FetchRequest.cpp:
>+        (WebCore::setReferrerPolicy): Renaming origin-only to origin.
>+        * Modules/fetch/FetchRequest.idl: Ditto.
>+        * loader/FetchOptions.h: Ditto.
>+
> 2016-06-20  Frederic Wang  <fwang@igalia.com>
> 
>         Use the MathOperator to handle some non-stretchy operators
>diff --git a/Source/WebCore/Modules/fetch/FetchRequest.cpp b/Source/WebCore/Modules/fetch/FetchRequest.cpp
>index 303a811ef2cbed1cb6bb556052b5d0b7de36521c..57cbe45132388e2ac7ebf43e9ccab716ad6e0d4d 100644
>--- a/Source/WebCore/Modules/fetch/FetchRequest.cpp
>+++ b/Source/WebCore/Modules/fetch/FetchRequest.cpp
>@@ -47,8 +47,8 @@ static bool setReferrerPolicy(FetchOptions& options, const String& referrerPolic
>         options.referrerPolicy = FetchOptions::ReferrerPolicy::NoReferrer;
>     else if (referrerPolicy == "no-referrer-when-downgrade")
>         options.referrerPolicy = FetchOptions::ReferrerPolicy::NoReferrerWhenDowngrade;
>-    else if (referrerPolicy == "origin-only")
>-        options.referrerPolicy = FetchOptions::ReferrerPolicy::OriginOnly;
>+    else if (referrerPolicy == "origin")
>+        options.referrerPolicy = FetchOptions::ReferrerPolicy::Origin;
>     else if (referrerPolicy == "origin-when-cross-origin")
>         options.referrerPolicy = FetchOptions::ReferrerPolicy::OriginWhenCrossOrigin;
>     else if (referrerPolicy == "unsafe-url")
>diff --git a/Source/WebCore/Modules/fetch/FetchRequest.idl b/Source/WebCore/Modules/fetch/FetchRequest.idl
>index de479e7a406d5b187e1b941b2fe58b888cd565c4..359f099144d6b0482f0116a0b7ccac71a0b322cd 100644
>--- a/Source/WebCore/Modules/fetch/FetchRequest.idl
>+++ b/Source/WebCore/Modules/fetch/FetchRequest.idl
>@@ -32,7 +32,7 @@ enum RequestMode { "navigate", "same-origin", "no-cors", "cors" };
> enum RequestCredentials { "omit", "same-origin", "include" };
> enum RequestCache { "default", "no-store", "reload", "no-cache", "force-cache" };
> enum RequestRedirect { "follow", "error", "manual" };
>-enum ReferrerPolicy { "", "no-referrer",  "no-referrer-when-downgrade", "origin-only", "origin-when-cross-origin", "unsafe-url" };
>+enum ReferrerPolicy { "", "no-referrer",  "no-referrer-when-downgrade", "origin", "origin-when-cross-origin", "unsafe-url" };
> 
> [
>     ActiveDOMObject,
>diff --git a/Source/WebCore/loader/FetchOptions.h b/Source/WebCore/loader/FetchOptions.h
>index cfe53d08a9c9cdf39025e593e2c18b81abefe1fc..499c81b5a442c5550c2d84d460015b644ebe7e77 100644
>--- a/Source/WebCore/loader/FetchOptions.h
>+++ b/Source/WebCore/loader/FetchOptions.h
>@@ -49,7 +49,7 @@ struct FetchOptions {
>     enum class Redirect { Follow, Error, Manual };
>     Redirect redirect { Redirect::Follow };
> 
>-    enum class ReferrerPolicy { EmptyString, NoReferrer, NoReferrerWhenDowngrade, OriginOnly, OriginWhenCrossOrigin, UnsafeUrl };
>+    enum class ReferrerPolicy { EmptyString, NoReferrer, NoReferrerWhenDowngrade, Origin, OriginWhenCrossOrigin, UnsafeUrl };
>     ReferrerPolicy referrerPolicy { ReferrerPolicy::EmptyString };
> };
> 
>diff --git a/LayoutTests/imported/w3c/ChangeLog b/LayoutTests/imported/w3c/ChangeLog
>index 8fdaf1100eeeac994ec0d4b6e617abbcfa9e1905..224ece493891281b31c6f8f89073bdcfb8c89979 100644
>--- a/LayoutTests/imported/w3c/ChangeLog
>+++ b/LayoutTests/imported/w3c/ChangeLog
>@@ -1,3 +1,21 @@
>+2016-06-21  Youenn Fablet  <youennf@gmail.com>
>+
>+        [Fetch API] Rename 'origin-only' referrer policy to 'origin'
>+        https://bugs.webkit.org/show_bug.cgi?id=158982
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Renaming origin-only to origin.
>+
>+        * web-platform-tests/fetch/api/cors/cors-preflight-referrer-expected.txt:
>+        * web-platform-tests/fetch/api/cors/cors-preflight-referrer-worker-expected.txt:
>+        * web-platform-tests/fetch/api/cors/cors-preflight-referrer.js:
>+        * web-platform-tests/fetch/api/request/request-clone.sub.html:
>+        * web-platform-tests/fetch/api/request/request-idl.html:
>+        * web-platform-tests/fetch/api/request/request-init-001.sub-expected.txt:
>+        * web-platform-tests/fetch/api/request/request-init-001.sub.html:
>+        * web-platform-tests/fetch/api/request/request-init-003.sub.html:
>+
> 2016-06-20  Benjamin Poulain  <benjamin@webkit.org>
> 
>         :default CSS pseudo-class should match checkboxes+radios with a `checked` attribute
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-preflight-referrer-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-preflight-referrer-expected.txt
>index 9f08b2f3b948cc5277fa07b93945cf69d98a519a..de10ef2964b2942a4f1dd87650606823573cd2ac 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-preflight-referrer-expected.txt
>+++ b/LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-preflight-referrer-expected.txt
>@@ -1,7 +1,7 @@
> 
> PASS Referrer policy: no-referrer 
> PASS Referrer policy: "" 
>-PASS Referrer policy: origin-only 
>+PASS Referrer policy: origin 
> PASS Referrer policy: origin-when-cross-origin 
> PASS Referrer policy: unsafe-url 
> 
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-preflight-referrer-worker-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-preflight-referrer-worker-expected.txt
>index 9f08b2f3b948cc5277fa07b93945cf69d98a519a..de10ef2964b2942a4f1dd87650606823573cd2ac 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-preflight-referrer-worker-expected.txt
>+++ b/LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-preflight-referrer-worker-expected.txt
>@@ -1,7 +1,7 @@
> 
> PASS Referrer policy: no-referrer 
> PASS Referrer policy: "" 
>-PASS Referrer policy: origin-only 
>+PASS Referrer policy: origin 
> PASS Referrer policy: origin-when-cross-origin 
> PASS Referrer policy: unsafe-url 
> 
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-preflight-referrer.js b/LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-preflight-referrer.js
>index 5cc3a084436daaa91b33fe01bb3d76de56ee12e3..2abda364fe494011f6e2b92f07facea4fc239736 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-preflight-referrer.js
>+++ b/LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-preflight-referrer.js
>@@ -32,7 +32,7 @@ var origin = "http://{{host}}:{{ports[http][0]}}";
> 
> corsPreflightReferrer("Referrer policy: no-referrer", corsUrl, "no-referrer", "");
> corsPreflightReferrer("Referrer policy: \"\"", corsUrl, "", "");
>-corsPreflightReferrer("Referrer policy: origin-only", corsUrl, "origin-only", origin);
>+corsPreflightReferrer("Referrer policy: origin", corsUrl, "origin", origin);
> corsPreflightReferrer("Referrer policy: origin-when-cross-origin", corsUrl, "origin-when-cross-origin", origin);
> corsPreflightReferrer("Referrer policy: unsafe-url", corsUrl, "unsafe-url", location.toString());
> 
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-clone.sub.html b/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-clone.sub.html
>index 40beb650390ff67ff1007596d14ff3ab5e546b0e..c690bb3dc036535510de6720f6aaf9d55cb55fe6 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-clone.sub.html
>+++ b/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-clone.sub.html
>@@ -16,7 +16,7 @@
> 
>       var initValuesDict = {"method" : "POST",
>                             "referrer" : "http://{{host}}:{{ports[http][0]}}/",
>-                            "referrerPolicy" : "origin-only",
>+                            "referrerPolicy" : "origin",
>                             "mode" : "same-origin",
>                             "credentials" : "include",
>                             "cache" : "no-cache",
>@@ -28,7 +28,7 @@
> 
>       var expectedInitialized = {"method" : "POST",
>                                  "referrer" : "http://{{host}}:{{ports[http][0]}}/",
>-                                 "referrerPolicy" : "origin-only",
>+                                 "referrerPolicy" : "origin",
>                                  "mode" : "same-origin",
>                                  "credentials" : "include",
>                                  "cache" : "no-cache",
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-idl.html b/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-idl.html
>index 4f1590c75609dd48356a03006668adce71f076bf..02b39f992436a827184a4df71ad9f9b850982530 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-idl.html
>+++ b/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-idl.html
>@@ -70,7 +70,7 @@
>       enum RequestCredentials { "omit", "same-origin", "include" };
>       enum RequestCache { "default", "no-store", "reload", "no-cache", "force-cache", "only-if-cached" };
>       enum RequestRedirect { "follow", "error", "manual" };
>-      enum ReferrerPolicy { "", "no-referrer", "no-referrer-when-downgrade", "origin-only", "origin-when-cross-origin", "unsafe-url" };
>+      enum ReferrerPolicy { "", "no-referrer", "no-referrer-when-downgrade", "origin", "origin-when-cross-origin", "unsafe-url" };
>     </script>
>     <script>
>       var idlsArray = new IdlArray();
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-init-001.sub-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-init-001.sub-expected.txt
>index a52209120abf9ef1da46a39c617996231e5c6be3..ed0666a1ac7e33803435cd71b35d80e54af9b40b 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-init-001.sub-expected.txt
>+++ b/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-init-001.sub-expected.txt
>@@ -14,7 +14,7 @@ PASS Check referrer init value of  and associated getter
> PASS Check referrerPolicy init value of  and associated getter 
> PASS Check referrerPolicy init value of no-referrer and associated getter 
> PASS Check referrerPolicy init value of no-referrer-when-downgrade and associated getter 
>-PASS Check referrerPolicy init value of origin-only and associated getter 
>+PASS Check referrerPolicy init value of origin and associated getter 
> PASS Check referrerPolicy init value of origin-when-cross-origin and associated getter 
> PASS Check referrerPolicy init value of unsafe-url and associated getter 
> PASS Check mode init value of same-origin and associated getter 
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-init-001.sub.html b/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-init-001.sub.html
>index 92206b45128dc397a00e3f781664aa057a74db24..b41f6f0fe715fba9d053ad6bbddbcdefc9befd2a 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-init-001.sub.html
>+++ b/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-init-001.sub.html
>@@ -29,14 +29,14 @@
>       var referrerPolicies = {"givenValues" : [ "",
>                                                 "no-referrer",
>                                                 "no-referrer-when-downgrade",
>-                                                "origin-only",
>+                                                "origin",
>                                                 "origin-when-cross-origin",
>                                                 "unsafe-url"
>                                               ],
>                               "expectedValues" : ["",
>                                                   "no-referrer",
>                                                   "no-referrer-when-downgrade",
>-                                                  "origin-only",
>+                                                  "origin",
>                                                   "origin-when-cross-origin",
>                                                   "unsafe-url"
>                                                   ]
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-init-003.sub.html b/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-init-003.sub.html
>index 41bafebb18dca2efa74f006d4380568a35604073..12181a21970f4829da8cf8d858932b962ca3ba9e 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-init-003.sub.html
>+++ b/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-init-003.sub.html
>@@ -17,7 +17,7 @@
> 
>       var initValuesDict = {"method" : "POST",
>                             "referrer" : "http://{{host}}:{{ports[http][0]}}/",
>-                            "referrerPolicy" : "origin-only",
>+                            "referrerPolicy" : "origin",
>                             "mode" : "same-origin",
>                             "credentials" : "include",
>                             "cache" : "no-cache",
>@@ -29,7 +29,7 @@
> 
>       var expectedInitialized = {"method" : "POST",
>                                  "referrer" : "http://{{host}}:{{ports[http][0]}}/",
>-                                 "referrerPolicy" : "origin-only",
>+                                 "referrerPolicy" : "origin",
>                                  "mode" : "same-origin",
>                                  "credentials" : "include",
>                                  "cache" : "no-cache",

Actions: View | Formatted Diff | Diff

Attachments on bug 158982: 281728