Attachment 279788 Details for Bug 158078 – Patch

[patch] Patch

bug-158078-20160525114558.patch (text/plain), 2.79 KB, created by Alex Christensen on 2016-05-25 11:44:50 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Christensen

Created: 2016-05-25 11:44:50 PDT

Size: 2.79 KB

patch

obsolete

>Index: Source/JavaScriptCore/ChangeLog
>===================================================================
>--- Source/JavaScriptCore/ChangeLog	(revision 201391)
>+++ Source/JavaScriptCore/ChangeLog	(working copy)
>@@ -1,3 +1,13 @@
>+2016-05-25  Alex Christensen  <achristensen@webkit.org>
>+
>+        Fix Win64 build after r201335
>+        https://bugs.webkit.org/show_bug.cgi?id=158078
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * offlineasm/x86.rb:
>+        Add intel implementations for loadbs and loadhs
>+
> 2016-05-25  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         REGRESSION(r201066): [GTK] Several intl tests started to fail in GTK+ bot after r201066
>Index: Source/JavaScriptCore/offlineasm/x86.rb
>===================================================================
>--- Source/JavaScriptCore/offlineasm/x86.rb	(revision 201387)
>+++ Source/JavaScriptCore/offlineasm/x86.rb	(working copy)
>@@ -648,7 +648,7 @@ class Instruction
>             $asm.puts "xchg#{x86Suffix(:ptr)} #{operand.x86Operand(:ptr)}, #{ax.x86Operand(:ptr)}"
>             $asm.puts "#{setOpcode} #{ax.x86Operand(:byte)}"
>             if !isIntelSyntax
>-		$asm.puts "movzbl #{ax.x86Operand(:byte)}, #{ax.x86Operand(:int)}"
>+                $asm.puts "movzbl #{ax.x86Operand(:byte)}, #{ax.x86Operand(:int)}"
>             else
>                 $asm.puts "movzx #{ax.x86Operand(:int)}, #{ax.x86Operand(:byte)}"
>             end
>@@ -954,7 +954,11 @@ class Instruction
>                 $asm.puts "movzx #{orderOperands(operands[0].x86Operand(:byte), operands[1].x86Operand(:int))}"
>             end
>         when "loadbs"
>-            $asm.puts "movsbl #{operands[0].x86Operand(:byte)}, #{operands[1].x86Operand(:int)}"
>+            if !isIntelSyntax
>+                $asm.puts "movsbl #{orderOperands(operands[0].x86Operand(:byte), operands[1].x86Operand(:int))}"
>+            else
>+                $asm.puts "movsx #{orderOperands(operands[0].x86Operand(:byte), operands[1].x86Operand(:int))}"
>+            end
>         when "loadh"
>             if !isIntelSyntax
>                 $asm.puts "movzwl #{orderOperands(operands[0].x86Operand(:half), operands[1].x86Operand(:int))}"
>@@ -962,7 +966,11 @@ class Instruction
>                 $asm.puts "movzx #{orderOperands(operands[0].x86Operand(:half), operands[1].x86Operand(:int))}"
>             end
>         when "loadhs"
>-            $asm.puts "movswl #{operands[0].x86Operand(:half)}, #{operands[1].x86Operand(:int)}"
>+            if !isIntelSyntax
>+                $asm.puts "movswl #{orderOperands(operands[0].x86Operand(:half), operands[1].x86Operand(:int))}"
>+            else
>+                $asm.puts "movsx #{orderOperands(operands[0].x86Operand(:half), operands[1].x86Operand(:int))}"
>+            end
>         when "storeb"
>             $asm.puts "mov#{x86Suffix(:byte)} #{x86Operands(:byte, :byte)}"
>         when "loadd"

Flags:

mark.lam: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 158078: 279788