Attachment 267779 Details for Bug 152471 – Patch

[patch] Patch

patch.txt (text/plain), 1.70 KB, created by Nikita Vasilyev on 2015-12-21 21:08:33 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Nikita Vasilyev

Created: 2015-12-21 21:08:33 PST

Size: 1.70 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index eed5423..01e86b9 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,5 +1,16 @@
> 2015-12-21  Nikita Vasilyev  <nvasilyev@apple.com>
> 
>+        WebInspector: Can't open a new tab: Uncaught Exception: TypeError: this.isNewTabWithTypeAllowed is not a function
>+        https://bugs.webkit.org/show_bug.cgi?id=152471
>+
>+        Reviewed by Timothy Hatcher.
>+
>+        * UserInterface/Base/Main.js:
>+        (WebInspector._updateNewTabButtonState):
>+        Don't use arrow functions because of https://webkit.org/b/152497 "Arrow functions: 'this' isn't lexically bound"
>+
>+2015-12-21  Nikita Vasilyev  <nvasilyev@apple.com>
>+
>         Web Inspector: Remove unused WebInspector.Object.removeAllListeners
>         https://bugs.webkit.org/show_bug.cgi?id=152474
> 
>diff --git a/Source/WebInspectorUI/UserInterface/Base/Main.js b/Source/WebInspectorUI/UserInterface/Base/Main.js
>index 9e4ae0b..e0aa5e3 100644
>--- a/Source/WebInspectorUI/UserInterface/Base/Main.js
>+++ b/Source/WebInspectorUI/UserInterface/Base/Main.js
>@@ -490,7 +490,11 @@ WebInspector._updateNewTabButtonState = function(event)
> {
>     let allTabs = [...this._knownTabClassesByType.values()];
>     let addableTabs = allTabs.filter((tabClass) => !tabClass.isEphemeral());
>-    let canMakeNewTab = addableTabs.some((tabClass) => this.isNewTabWithTypeAllowed(tabClass.Type));
>+
>+    // FIXME: Use arrow functions once http://webkit.org/b/152497 is resolved.
>+    let canMakeNewTab = addableTabs.some(function(tabClass) {
>+        return this.isNewTabWithTypeAllowed(tabClass.Type);
>+    }.bind(this));
>     this.tabBar.newTabItem.disabled = !canMakeNewTab;
> };
>

Actions: View | Formatted Diff | Diff

Attachments on bug 152471: 267732 | 267734 | 267735 | 267779