Attachment 261578 Details for Bug 145638 – Patch

[patch] Patch

bug-145638-20150919203209.patch (text/plain), 2.94 KB, created by GSkachkov on 2015-09-19 10:32:23 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: GSkachkov

Created: 2015-09-19 10:32:23 PDT

Size: 2.94 KB

patch

obsolete

>Subversion Revision: 190013
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 0a045b24ea87ec9fb31ba2f395e4ed9cd94d3aca..76469b9c1a00788b3065895e5548b1427a56e02b 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,12 @@
>+2015-09-19 Aleksandr Skachkov    <gskachkov@gmail.com>
>+
>+        [ES6] Added controlFlowProfiler test for arrow function
>+        https://bugs.webkit.org/show_bug.cgi?id=145638
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Source/JavaScriptCore/tests/controlFlowProfiler/arrowfunction-expression.js: added
>+
> 2015-09-19 Aleksandr Skachkov   <gskachkov@gmail.com>
> 
>         New tests introduced in r188545 fail on 32 bit ARM
>diff --git a/Source/JavaScriptCore/tests/controlFlowProfiler/arrowfunction-expression.js b/Source/JavaScriptCore/tests/controlFlowProfiler/arrowfunction-expression.js
>new file mode 100644
>index 0000000000000000000000000000000000000000..613560e118c1c552eabb7cb87853e7bbe9ebfa2f
>--- /dev/null
>+++ b/Source/JavaScriptCore/tests/controlFlowProfiler/arrowfunction-expression.js
>@@ -0,0 +1,63 @@
>+load("./driver/driver.js");
>+
>+var afSimple = y => y + 1,
>+    afBlock = y => { y++; return y + 1;},
>+    afBlockWithCondition = x => { x > 0 ? x++ : x--; return x;};
>+
>+checkBasicBlock(afSimple, "y + 1", ShouldNotHaveExecuted);
>+afSimple(1);
>+checkBasicBlock(afSimple, "y + 1", ShouldHaveExecuted);
>+
>+
>+checkBasicBlock(afBlock, "y++", ShouldNotHaveExecuted);
>+afBlock(2);
>+checkBasicBlock(afBlock, "y++", ShouldHaveExecuted);
>+checkBasicBlock(afBlock, "return y + 1", ShouldHaveExecuted);
>+
>+
>+checkBasicBlock(afBlockWithCondition,'x++', ShouldNotHaveExecuted);
>+afBlockWithCondition(10);
>+checkBasicBlock(afBlockWithCondition,'x++', ShouldHaveExecuted);
>+checkBasicBlock(afBlockWithCondition,'return x', ShouldHaveExecuted);
>+checkBasicBlock(afBlockWithCondition,'x--', ShouldNotHaveExecuted);
>+
>+
>+afBlockWithCondition(-10);
>+checkBasicBlock(afBlockWithCondition,'x--', ShouldHaveExecuted);
>+
>+function foo1(test) {
>+   var f1 = () => { "hello"; }
>+   if (test)
>+       f1();
>+}
>+foo1(false);
>+checkBasicBlock(foo1, '() =>', ShouldNotHaveExecuted);
>+checkBasicBlock(foo1, '; }', ShouldNotHaveExecuted);
>+foo1(true);
>+checkBasicBlock(foo1, '() =>', ShouldHaveExecuted);
>+checkBasicBlock(foo1, '; }', ShouldHaveExecuted);
>+
>+function foo2(test) {
>+   var f1 = x => { "hello"; }
>+   if (test)
>+       f1();
>+}
>+foo2(false);
>+checkBasicBlock(foo2, 'x =>', ShouldNotHaveExecuted);
>+checkBasicBlock(foo2, '; }', ShouldNotHaveExecuted);
>+foo2(true);
>+checkBasicBlock(foo2, 'x =>', ShouldHaveExecuted);
>+checkBasicBlock(foo2, '; }', ShouldHaveExecuted);
>+
>+
>+function foo3(test) {
>+   var f1 = (xyz) => { "hello"; }
>+   if (test)
>+       f1();
>+}
>+foo3(false);
>+checkBasicBlock(foo3, '(xyz) =>', ShouldNotHaveExecuted);
>+checkBasicBlock(foo3, '; }', ShouldNotHaveExecuted);
>+foo3(true);
>+checkBasicBlock(foo3, '(xyz) =>', ShouldHaveExecuted);
>+checkBasicBlock(foo3, '; }', ShouldHaveExecuted);

Actions: View | Formatted Diff | Diff

Attachments on bug 145638: 254489 | 255624 | 255700 | 261578