Attachment 260948 Details for Bug 149044 – Patch with speculative fix for ARM64 Linux

[patch] Patch with speculative fix for ARM64 Linux

149044.patch (text/plain), 1.72 KB, created by Michael Saboff on 2015-09-10 13:48:32 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Saboff

Created: 2015-09-10 13:48:32 PDT

Size: 1.72 KB

patch

obsolete

>Index: Source/JavaScriptCore/ChangeLog
>===================================================================
>--- Source/JavaScriptCore/ChangeLog	(revision 189587)
>+++ Source/JavaScriptCore/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2015-09-10  Michael Saboff  <msaboff@apple.com>
>+
>+        REGRESSION(r189575): Appears to break ARM64 linux builds
>+        https://bugs.webkit.org/show_bug.cgi?id=149044
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Changed the use of the ARM64 "fp", a register alias, to be "x29", the real register name.
>+
>+        * llint/LowLevelInterpreter.asm:
>+
> 2015-09-09  Filip Pizlo  <fpizlo@apple.com>
> 
>         There should be one stub hanging off an inline cache that contains code for all of the cases, rather than forming a linked list consisting of one stub per case
>Index: Source/JavaScriptCore/llint/LowLevelInterpreter.asm
>===================================================================
>--- Source/JavaScriptCore/llint/LowLevelInterpreter.asm	(revision 189587)
>+++ Source/JavaScriptCore/llint/LowLevelInterpreter.asm	(working copy)
>@@ -517,8 +517,8 @@ macro preserveCalleeSavesUsedByLLInt()
>     elsif ARM or ARMv7_TRADITIONAL
>     elsif ARMv7
>     elsif ARM64
>-        emit "stp x27, x28, [fp, #-16]"
>-        emit "stp xzr, x26, [fp, #-32]"
>+        emit "stp x27, x28, [x29, #-16]"
>+        emit "stp xzr, x26, [x29, #-32]"
>     elsif MIPS
>     elsif SH4
>     elsif X86
>@@ -539,8 +539,8 @@ macro restoreCalleeSavesUsedByLLInt()
>     elsif ARM or ARMv7_TRADITIONAL
>     elsif ARMv7
>     elsif ARM64
>-        emit "ldp xzr, x26, [fp, #-32]"
>-        emit "ldp x27, x28, [fp, #-16]"
>+        emit "ldp xzr, x26, [x29, #-32]"
>+        emit "ldp x27, x28, [x29, #-16]"
>     elsif MIPS
>     elsif SH4
>     elsif X86

Flags:

fpizlo: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 149044: 260948