Attachment 253019 Details for Bug 144905 – Patch

[patch] Patch

bug-144905-20150513141311.patch (text/plain), 53.46 KB, created by Joonghun Park on 2015-05-12 22:14:28 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Joonghun Park

Created: 2015-05-12 22:14:28 PDT

Size: 53.46 KB

patch

obsolete

>Subversion Revision: 184154
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 17a9118cd9f5af0e73b2aa5fedd2f54e4b211645..e7df306fa93e0d1c92bed8f04d5d8b0c72ef2cc3 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,101 @@
>+2015-05-12  Joonghun Park  <jh718.park@samsung.com>
>+
>+        Purge PassRefPtr create() factory functions in WebCore/css
>+        https://bugs.webkit.org/show_bug.cgi?id=144905
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Return Ref instead of PassRefPtr in create() factory functions in css,
>+        because the factory can't return null.
>+
>+        No new tests, no new behaviours.
>+
>+        * css/BasicShapeFunctions.cpp:
>+        (WebCore::valueForCenterCoordinate):
>+        (WebCore::basicShapeRadiusToCSSValue):
>+        (WebCore::valueForBasicShape):
>+        * css/CSSBasicShapes.h:
>+        * css/CSSCalculationValue.cpp:
>+        (WebCore::CSSCalcValue::create):
>+        * css/CSSCalculationValue.h:
>+        * css/CSSCharsetRule.h:
>+        * css/CSSComputedStyleDeclaration.cpp:
>+        (WebCore::valueForNinePieceImageSlice):
>+        (WebCore::valueForNinePieceImageQuad):
>+        (WebCore::ComputedStyleExtractor::propertyValue):
>+        * css/CSSComputedStyleDeclaration.h:
>+        * css/CSSFontFace.h:
>+        (WebCore::CSSFontFace::create):
>+        * css/CSSFontFaceLoadEvent.h:
>+        * css/CSSFontFaceRule.h:
>+        * css/CSSGrammar.y.in:
>+        * css/CSSGridLineNamesValue.cpp:
>+        (WebCore::CSSGridLineNamesValue::cloneForCSSOM):
>+        * css/CSSGridLineNamesValue.h:
>+        (WebCore::CSSGridLineNamesValue::create):
>+        * css/CSSImportRule.h:
>+        * css/CSSKeyframeRule.h:
>+        (WebCore::StyleKeyframe::create):
>+        * css/CSSKeyframesRule.h:
>+        * css/CSSMediaRule.h:
>+        * css/CSSPageRule.h:
>+        * css/CSSParser.cpp:
>+        (WebCore::CSSParser::parseGridLineNames):
>+        (WebCore::CSSParser::parseDashboardRegions):
>+        (WebCore::CSSParser::parseClipShape):
>+        (WebCore::CSSParser::parseBasicShape):
>+        (WebCore::BorderImageSliceParseContext::commitBorderImageSlice):
>+        (WebCore::BorderImageQuadParseContext::commitBorderImageQuad):
>+        * css/CSSPrimitiveValue.cpp:
>+        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
>+        (WebCore::CSSPrimitiveValue::init):
>+        * css/CSSPrimitiveValue.h:
>+        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
>+        * css/CSSPropertySourceData.h:
>+        (WebCore::CSSStyleSourceData::create):
>+        (WebCore::CSSRuleSourceData::create):
>+        (WebCore::CSSRuleSourceData::createUnknown):
>+        * css/CSSRuleList.h:
>+        * css/CSSSegmentedFontFace.h:
>+        (WebCore::CSSSegmentedFontFace::create):
>+        * css/CSSSelector.cpp:
>+        (WebCore::CSSSelector::createRareData):
>+        * css/CSSSelector.h:
>+        (WebCore::CSSSelector::RareData::create):
>+        * css/CSSStyleRule.h:
>+        * css/CSSSupportsRule.h:
>+        * css/FontLoader.cpp:
>+        (WebCore::LoadFontCallback::create):
>+        * css/LengthRepeat.h:
>+        (WebCore::LengthRepeat::create):
>+        * css/MediaList.h:
>+        (WebCore::MediaQuerySet::create):
>+        (WebCore::MediaQuerySet::createAllowingDescriptionSyntax):
>+        (WebCore::MediaList::create):
>+        * css/MediaQueryList.cpp:
>+        (WebCore::MediaQueryList::create):
>+        * css/MediaQueryList.h:
>+        * css/MediaQueryMatcher.h:
>+        (WebCore::MediaQueryMatcher::create):
>+        * css/Pair.h:
>+        (WebCore::Pair::create):
>+        * css/Rect.h:
>+        (WebCore::Rect::create):
>+        (WebCore::Rect::cloneForCSSOM):
>+        (WebCore::Quad::create):
>+        (WebCore::Quad::cloneForCSSOM):
>+        * css/StyleMedia.h:
>+        (WebCore::StyleMedia::create):
>+        * css/StyleResolver.cpp:
>+        (WebCore::StyleResolver::keyframeStylesForAnimation):
>+        * css/StyleSheetList.h:
>+        (WebCore::StyleSheetList::create):
>+        * css/ViewportStyleResolver.h:
>+        (WebCore::ViewportStyleResolver::create):
>+        * css/WebKitCSSMatrix.h:
>+        * css/WebKitCSSRegionRule.h:
>+        * css/WebKitCSSViewportRule.h:
>+
> 2015-05-11  Zan Dobersek  <zdobersek@igalia.com>
> 
>         Clean up redundant resources in case of failure in GLContextEGL context creation methods
>diff --git a/Source/WebCore/css/BasicShapeFunctions.cpp b/Source/WebCore/css/BasicShapeFunctions.cpp
>index dcb1f0ac333c3de65c0811885d6895c61ed08216..27d6cdc41767a47f18555776980644332711b8d3 100644
>--- a/Source/WebCore/css/BasicShapeFunctions.cpp
>+++ b/Source/WebCore/css/BasicShapeFunctions.cpp
>@@ -39,7 +39,7 @@
> 
> namespace WebCore {
> 
>-static PassRefPtr<CSSPrimitiveValue> valueForCenterCoordinate(CSSValuePool& pool, const RenderStyle* style, const BasicShapeCenterCoordinate& center, EBoxOrient orientation)
>+static Ref<CSSPrimitiveValue> valueForCenterCoordinate(CSSValuePool& pool, const RenderStyle* style, const BasicShapeCenterCoordinate& center, EBoxOrient orientation)
> {
>     if (center.direction() == BasicShapeCenterCoordinate::TopLeft)
>         return pool.createValue(center.length(), style);
>@@ -49,7 +49,7 @@ static PassRefPtr<CSSPrimitiveValue> valueForCenterCoordinate(CSSValuePool& pool
>     return pool.createValue(Pair::create(pool.createIdentifierValue(keyword), pool.createValue(center.length(), style)));
> }
> 
>-static PassRefPtr<CSSPrimitiveValue> basicShapeRadiusToCSSValue(const RenderStyle* style, CSSValuePool& pool, const BasicShapeRadius& radius)
>+static RefPtr<CSSPrimitiveValue> basicShapeRadiusToCSSValue(const RenderStyle* style, CSSValuePool& pool, const BasicShapeRadius& radius)
> {
>     switch (radius.type()) {
>     case BasicShapeRadius::Value:
>@@ -77,7 +77,7 @@ Ref<CSSValue> valueForBasicShape(const RenderStyle* style, const BasicShape& bas
>         circleValue->setCenterX(valueForCenterCoordinate(pool, style, circle.centerX(), HORIZONTAL));
>         circleValue->setCenterY(valueForCenterCoordinate(pool, style, circle.centerY(), VERTICAL));
>         circleValue->setRadius(basicShapeRadiusToCSSValue(style, pool, circle.radius()));
>-        basicShapeValue = circleValue.release();
>+        basicShapeValue = circleValue;
>         break;
>     }
>     case BasicShape::BasicShapeEllipseType: {
>@@ -88,7 +88,7 @@ Ref<CSSValue> valueForBasicShape(const RenderStyle* style, const BasicShape& bas
>         ellipseValue->setCenterY(valueForCenterCoordinate(pool, style, ellipse.centerY(), VERTICAL));
>         ellipseValue->setRadiusX(basicShapeRadiusToCSSValue(style, pool, ellipse.radiusX()));
>         ellipseValue->setRadiusY(basicShapeRadiusToCSSValue(style, pool, ellipse.radiusY()));
>-        basicShapeValue = ellipseValue.release();
>+        basicShapeValue = ellipseValue;
>         break;
>     }
>     case BasicShape::BasicShapePolygonType: {
>@@ -100,7 +100,7 @@ Ref<CSSValue> valueForBasicShape(const RenderStyle* style, const BasicShape& bas
>         for (unsigned i = 0; i < values.size(); i += 2)
>             polygonValue->appendPoint(pool.createValue(values.at(i), style), pool.createValue(values.at(i + 1), style));
> 
>-        basicShapeValue = polygonValue.release();
>+        basicShapeValue = polygonValue;
>         break;
>     }
>     case BasicShape::BasicShapeInsetType: {
>@@ -117,14 +117,14 @@ Ref<CSSValue> valueForBasicShape(const RenderStyle* style, const BasicShape& bas
>         insetValue->setBottomRightRadius(pool.createValue(inset.bottomRightRadius(), style));
>         insetValue->setBottomLeftRadius(pool.createValue(inset.bottomLeftRadius(), style));
> 
>-        basicShapeValue = insetValue.release();
>+        basicShapeValue = insetValue;
>         break;
>     }
>     default:
>         break;
>     }
> 
>-    return pool.createValue(basicShapeValue.release());
>+    return pool.createValue(WTF::move(basicShapeValue));
> }
> 
> static Length convertToLength(const CSSToLengthConversionData& conversionData, CSSPrimitiveValue* value)
>diff --git a/Source/WebCore/css/CSSBasicShapes.h b/Source/WebCore/css/CSSBasicShapes.h
>index 0ceb2f51c8d13bad928da63f180528c731d96929..b7b46dbc4127a8e03457f888bf1bc691fcbebb43 100644
>--- a/Source/WebCore/css/CSSBasicShapes.h
>+++ b/Source/WebCore/css/CSSBasicShapes.h
>@@ -65,7 +65,7 @@ protected:
> 
> class CSSBasicShapeInset final : public CSSBasicShape {
> public:
>-    static PassRefPtr<CSSBasicShapeInset> create() { return adoptRef(new CSSBasicShapeInset); }
>+    static Ref<CSSBasicShapeInset> create() { return adoptRef(*new CSSBasicShapeInset); }
> 
>     CSSPrimitiveValue* top() const { return m_top.get(); }
>     CSSPrimitiveValue* right() const { return m_right.get(); }
>@@ -131,7 +131,7 @@ private:
> 
> class CSSBasicShapeCircle final : public CSSBasicShape {
> public:
>-    static PassRefPtr<CSSBasicShapeCircle> create() { return adoptRef(new CSSBasicShapeCircle); }
>+    static Ref<CSSBasicShapeCircle> create() { return adoptRef(*new CSSBasicShapeCircle); }
> 
>     virtual String cssText() const override;
>     virtual bool equals(const CSSBasicShape&) const override;
>@@ -156,7 +156,7 @@ private:
> 
> class CSSBasicShapeEllipse final : public CSSBasicShape {
> public:
>-    static PassRefPtr<CSSBasicShapeEllipse> create() { return adoptRef(new CSSBasicShapeEllipse); }
>+    static Ref<CSSBasicShapeEllipse> create() { return adoptRef(*new CSSBasicShapeEllipse); }
> 
>     CSSPrimitiveValue* centerX() const { return m_centerX.get(); }
>     CSSPrimitiveValue* centerY() const { return m_centerY.get(); }
>@@ -184,7 +184,7 @@ private:
> 
> class CSSBasicShapePolygon final : public CSSBasicShape {
> public:
>-    static PassRefPtr<CSSBasicShapePolygon> create() { return adoptRef(new CSSBasicShapePolygon); }
>+    static Ref<CSSBasicShapePolygon> create() { return adoptRef(*new CSSBasicShapePolygon); }
> 
>     void appendPoint(PassRefPtr<CSSPrimitiveValue> x, PassRefPtr<CSSPrimitiveValue> y)
>     {
>diff --git a/Source/WebCore/css/CSSCalculationValue.cpp b/Source/WebCore/css/CSSCalculationValue.cpp
>index 7b72f109888ceba0b0228c07ca2a7228da932547..19376ad11dcea3fd56bdd32a69cbc4bcc5731c6c 100644
>--- a/Source/WebCore/css/CSSCalculationValue.cpp
>+++ b/Source/WebCore/css/CSSCalculationValue.cpp
>@@ -751,7 +751,7 @@ static PassRefPtr<CSSCalcExpressionNode> createCSS(const Length& length, const R
>     return nullptr;
> }
> 
>-PassRefPtr<CSSCalcValue> CSSCalcValue::create(CSSParserString name, CSSParserValueList& parserValueList, CalculationPermittedValueRange range)
>+RefPtr<CSSCalcValue> CSSCalcValue::create(CSSParserString name, CSSParserValueList& parserValueList, CalculationPermittedValueRange range)
> {
>     CSSCalcExpressionNodeParser parser;
>     RefPtr<CSSCalcExpressionNode> expression;
>@@ -762,7 +762,7 @@ PassRefPtr<CSSCalcValue> CSSCalcValue::create(CSSParserString name, CSSParserVal
>     return expression ? adoptRef(new CSSCalcValue(expression.releaseNonNull(), range != CalculationRangeAll)) : nullptr;
> }
> 
>-PassRefPtr<CSSCalcValue> CSSCalcValue::create(const CalculationValue& value, const RenderStyle& style)
>+RefPtr<CSSCalcValue> CSSCalcValue::create(const CalculationValue& value, const RenderStyle& style)
> {
>     RefPtr<CSSCalcExpressionNode> expression = createCSS(value.expression(), style);
>     if (!expression)
>diff --git a/Source/WebCore/css/CSSCalculationValue.h b/Source/WebCore/css/CSSCalculationValue.h
>index df7cebac012f611d13fe43ea508e20ddeeaf72a1..169b4a51d05e1d10777576579bbde024b3f53d85 100644
>--- a/Source/WebCore/css/CSSCalculationValue.h
>+++ b/Source/WebCore/css/CSSCalculationValue.h
>@@ -86,8 +86,8 @@ private:
> 
> class CSSCalcValue : public CSSValue {
> public:
>-    static PassRefPtr<CSSCalcValue> create(CSSParserString name, CSSParserValueList& arguments, CalculationPermittedValueRange);
>-    static PassRefPtr<CSSCalcValue> create(const CalculationValue&, const RenderStyle&);
>+    static RefPtr<CSSCalcValue> create(CSSParserString name, CSSParserValueList& arguments, CalculationPermittedValueRange);
>+    static RefPtr<CSSCalcValue> create(const CalculationValue&, const RenderStyle&);
> 
>     CalculationCategory category() const { return m_expression->category(); }
>     bool isInt() const { return m_expression->isInteger(); }
>diff --git a/Source/WebCore/css/CSSCharsetRule.h b/Source/WebCore/css/CSSCharsetRule.h
>index de1ac3ce2a2b0ebb1c49497ecf829e01af713e70..bf08d1e22e3410d393f5a94b09bf438ae4d19967 100644
>--- a/Source/WebCore/css/CSSCharsetRule.h
>+++ b/Source/WebCore/css/CSSCharsetRule.h
>@@ -28,9 +28,9 @@ namespace WebCore {
> 
> class CSSCharsetRule final : public CSSRule {
> public:
>-    static PassRefPtr<CSSCharsetRule> create(CSSStyleSheet* parent, const String& encoding)
>+    static Ref<CSSCharsetRule> create(CSSStyleSheet* parent, const String& encoding)
>     {
>-        return adoptRef(new CSSCharsetRule(parent, encoding));
>+        return adoptRef(*new CSSCharsetRule(parent, encoding));
>     }
> 
>     virtual ~CSSCharsetRule() { }
>diff --git a/Source/WebCore/css/CSSComputedStyleDeclaration.cpp b/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
>index e7b38a4c847dfd817bb7de29b6b08ed3f66d25f6..ca0a4fece613403f39fcbc4ed30502c8688de598 100644
>--- a/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
>+++ b/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
>@@ -525,13 +525,13 @@ static Ref<CSSBorderImageSliceValue> valueForNinePieceImageSlice(const NinePiece
>         }
>     }
> 
>-    RefPtr<Quad> quad = Quad::create();
>+    Ref<Quad> quad = Quad::create();
>     quad->setTop(top.release());
>     quad->setRight(right.release());
>     quad->setBottom(bottom.release());
>     quad->setLeft(left.release());
> 
>-    return CSSBorderImageSliceValue::create(cssValuePool().createValue(quad.release()), image.fill());
>+    return CSSBorderImageSliceValue::create(cssValuePool().createValue(WTF::move(quad)), image.fill());
> }
> 
> static Ref<CSSPrimitiveValue> valueForNinePieceImageQuad(const LengthBox& box)
>@@ -576,13 +576,13 @@ static Ref<CSSPrimitiveValue> valueForNinePieceImageQuad(const LengthBox& box)
>         }
>     }
> 
>-    RefPtr<Quad> quad = Quad::create();
>+    Ref<Quad> quad = Quad::create();
>     quad->setTop(top);
>     quad->setRight(right);
>     quad->setBottom(bottom);
>     quad->setLeft(left);
> 
>-    return cssValuePool().createValue(quad.release());
>+    return cssValuePool().createValue(WTF::move(quad));
> }
> 
> static Ref<CSSValue> valueForNinePieceImageRepeat(const NinePieceImage& image)
>@@ -2742,7 +2742,7 @@ PassRefPtr<CSSValue> ComputedStyleExtractor::propertyValue(CSSPropertyID propert
>                     firstRegion = region;
>                 previousRegion = region.get();
>             }
>-            return cssValuePool().createValue(firstRegion.release());
>+            return cssValuePool().createValue(WTF::move(firstRegion));
>         }
> #endif
>         case CSSPropertyAnimationDelay:
>@@ -2953,12 +2953,12 @@ PassRefPtr<CSSValue> ComputedStyleExtractor::propertyValue(CSSPropertyID propert
>         case CSSPropertyClip: {
>             if (!style->hasClip())
>                 return cssValuePool().createIdentifierValue(CSSValueAuto);
>-            RefPtr<Rect> rect = Rect::create();
>+            Ref<Rect> rect = Rect::create();
>             rect->setTop(autoOrZoomAdjustedValue(style->clip().top(), style.get()));
>             rect->setRight(autoOrZoomAdjustedValue(style->clip().right(), style.get()));
>             rect->setBottom(autoOrZoomAdjustedValue(style->clip().bottom(), style.get()));
>             rect->setLeft(autoOrZoomAdjustedValue(style->clip().left(), style.get()));
>-            return cssValuePool().createValue(rect.release());
>+            return cssValuePool().createValue(WTF::move(rect));
>         }
>         case CSSPropertySpeak:
>             return cssValuePool().createValue(style->speak());
>diff --git a/Source/WebCore/css/CSSComputedStyleDeclaration.h b/Source/WebCore/css/CSSComputedStyleDeclaration.h
>index efdc15738940602e42a9db912e3315ed0e043d51..42f291a51000a6685702f153abf94b84b80f1dcc 100644
>--- a/Source/WebCore/css/CSSComputedStyleDeclaration.h
>+++ b/Source/WebCore/css/CSSComputedStyleDeclaration.h
>@@ -85,9 +85,9 @@ private:
> 
> class CSSComputedStyleDeclaration final : public CSSStyleDeclaration {
> public:
>-    static PassRefPtr<CSSComputedStyleDeclaration> create(PassRefPtr<Node> node, bool allowVisitedStyle = false, const String& pseudoElementName = String())
>+    static Ref<CSSComputedStyleDeclaration> create(PassRefPtr<Node> node, bool allowVisitedStyle = false, const String& pseudoElementName = String())
>     {
>-        return adoptRef(new CSSComputedStyleDeclaration(node, allowVisitedStyle, pseudoElementName));
>+        return adoptRef(*new CSSComputedStyleDeclaration(node, allowVisitedStyle, pseudoElementName));
>     }
>     virtual ~CSSComputedStyleDeclaration();
> 
>diff --git a/Source/WebCore/css/CSSFontFace.h b/Source/WebCore/css/CSSFontFace.h
>index d1f0636dd73b61b6dbcf1638fc611e71df626f50..db67bc66433b5f5008eaedf5d9b150a9016cbd25 100644
>--- a/Source/WebCore/css/CSSFontFace.h
>+++ b/Source/WebCore/css/CSSFontFace.h
>@@ -44,7 +44,7 @@ class Font;
> 
> class CSSFontFace : public RefCounted<CSSFontFace> {
> public:
>-    static PassRefPtr<CSSFontFace> create(FontTraitsMask traitsMask, PassRefPtr<CSSFontFaceRule> rule, bool isLocalFallback = false) { return adoptRef(new CSSFontFace(traitsMask, rule, isLocalFallback)); }
>+    static Ref<CSSFontFace> create(FontTraitsMask traitsMask, PassRefPtr<CSSFontFaceRule> rule, bool isLocalFallback = false) { return adoptRef(*new CSSFontFace(traitsMask, rule, isLocalFallback)); }
> 
>     FontTraitsMask traitsMask() const { return m_traitsMask; }
> 
>diff --git a/Source/WebCore/css/CSSFontFaceLoadEvent.h b/Source/WebCore/css/CSSFontFaceLoadEvent.h
>index 6f69811c9955199829442955ef2164b7e896bb93..13ca251f5582a5d6053ac86454b7b5033fa40cdb 100644
>--- a/Source/WebCore/css/CSSFontFaceLoadEvent.h
>+++ b/Source/WebCore/css/CSSFontFaceLoadEvent.h
>@@ -50,24 +50,24 @@ struct CSSFontFaceLoadEventInit : public EventInit {
> 
> class CSSFontFaceLoadEvent final : public Event {
> public:
>-    static PassRefPtr<CSSFontFaceLoadEvent> create()
>+    static Ref<CSSFontFaceLoadEvent> create()
>     {
>-        return adoptRef<CSSFontFaceLoadEvent>(new CSSFontFaceLoadEvent());
>+        return adoptRef<CSSFontFaceLoadEvent>(*new CSSFontFaceLoadEvent;
>     }
> 
>-    static PassRefPtr<CSSFontFaceLoadEvent> create(const AtomicString& type, const CSSFontFaceLoadEventInit& initializer)
>+    static Ref<CSSFontFaceLoadEvent> create(const AtomicString& type, const CSSFontFaceLoadEventInit& initializer)
>     {
>-        return adoptRef<CSSFontFaceLoadEvent>(new CSSFontFaceLoadEvent(type, initializer));
>+        return adoptRef<CSSFontFaceLoadEvent>(*new CSSFontFaceLoadEvent(type, initializer));
>     }
> 
>-    static PassRefPtr<CSSFontFaceLoadEvent> createForFontFaceRule(const AtomicString& type, PassRefPtr<CSSFontFaceRule> rule)
>+    static Ref<CSSFontFaceLoadEvent> createForFontFaceRule(const AtomicString& type, PassRefPtr<CSSFontFaceRule> rule)
>     {
>-        return adoptRef<CSSFontFaceLoadEvent>(new CSSFontFaceLoadEvent(type, rule, 0));
>+        return adoptRef<CSSFontFaceLoadEvent>(*new CSSFontFaceLoadEvent(type, rule, 0));
>     }
> 
>-    static PassRefPtr<CSSFontFaceLoadEvent> createForError(PassRefPtr<CSSFontFaceRule> rule, PassRefPtr<DOMError> error)
>+    static Ref<CSSFontFaceLoadEvent> createForError(PassRefPtr<CSSFontFaceRule> rule, PassRefPtr<DOMError> error)
>     {
>-        return adoptRef<CSSFontFaceLoadEvent>(new CSSFontFaceLoadEvent(eventNames().errorEvent, rule, error));
>+        return adoptRef<CSSFontFaceLoadEvent>(*new CSSFontFaceLoadEvent(eventNames().errorEvent, rule, error));
>     }
> 
>     virtual ~CSSFontFaceLoadEvent();
>diff --git a/Source/WebCore/css/CSSFontFaceRule.h b/Source/WebCore/css/CSSFontFaceRule.h
>index b55ab4f9b6b31e51b8a82bfaa0dbd4c10dedf4ac..f8399418a8102bff64a926fc1632dc8874ca6742 100644
>--- a/Source/WebCore/css/CSSFontFaceRule.h
>+++ b/Source/WebCore/css/CSSFontFaceRule.h
>@@ -32,7 +32,7 @@ class StyleRuleCSSStyleDeclaration;
> 
> class CSSFontFaceRule final : public CSSRule {
> public:
>-    static PassRefPtr<CSSFontFaceRule> create(StyleRuleFontFace& rule, CSSStyleSheet* sheet) { return adoptRef(new CSSFontFaceRule(rule, sheet)); }
>+    static Ref<CSSFontFaceRule> create(StyleRuleFontFace& rule, CSSStyleSheet* sheet) { return adoptRef(*new CSSFontFaceRule(rule, sheet)); }
> 
>     virtual ~CSSFontFaceRule();
> 
>diff --git a/Source/WebCore/css/CSSGrammar.y.in b/Source/WebCore/css/CSSGrammar.y.in
>index b4fe11a40e91c2312887572a23caf87d2eefb3d4..7fdcb2a20520657ba0e67d70fc195e438a9bff23 100644
>--- a/Source/WebCore/css/CSSGrammar.y.in
>+++ b/Source/WebCore/css/CSSGrammar.y.in
>@@ -642,11 +642,11 @@ media_query:
>     }
>     ;
> 
>-maybe_media_list: /* empty */ { $$ = MediaQuerySet::create().leakRef(); } | media_list ;
>+maybe_media_list: /* empty */ { $$ = &MediaQuerySet::create().leakRef(); } | media_list ;
> 
> media_list:
>     media_query {
>-        $$ = MediaQuerySet::create().leakRef();
>+        $$ = &MediaQuerySet::create().leakRef();
>         $$->addMediaQuery(std::unique_ptr<MediaQuery>($1));
>         parser->updateLastMediaLine($$);
>     }
>diff --git a/Source/WebCore/css/CSSGridLineNamesValue.cpp b/Source/WebCore/css/CSSGridLineNamesValue.cpp
>index 53d6010bb503a6eed76fa5cd84ac58d5717306da..0eb11a2790444ffd77287a9da418d1f8ede42484 100644
>--- a/Source/WebCore/css/CSSGridLineNamesValue.cpp
>+++ b/Source/WebCore/css/CSSGridLineNamesValue.cpp
>@@ -44,9 +44,9 @@ CSSGridLineNamesValue::CSSGridLineNamesValue()
> {
> }
> 
>-PassRefPtr<CSSGridLineNamesValue> CSSGridLineNamesValue::cloneForCSSOM() const
>+Ref<CSSGridLineNamesValue> CSSGridLineNamesValue::cloneForCSSOM() const
> {
>-    return adoptRef(new CSSGridLineNamesValue(*this));
>+    return adoptRef(*new CSSGridLineNamesValue(*this));
> }
> 
> }
>diff --git a/Source/WebCore/css/CSSGridLineNamesValue.h b/Source/WebCore/css/CSSGridLineNamesValue.h
>index 7ab8b258a966497f68725a612403cd053005e0ac..2fddbf896c785cc11347b3d7c309d08f5946e5e3 100644
>--- a/Source/WebCore/css/CSSGridLineNamesValue.h
>+++ b/Source/WebCore/css/CSSGridLineNamesValue.h
>@@ -39,14 +39,14 @@ namespace WebCore {
> 
> class CSSGridLineNamesValue : public CSSValueList {
> public:
>-    static PassRefPtr<CSSGridLineNamesValue> create()
>+    static Ref<CSSGridLineNamesValue> create()
>     {
>-        return adoptRef(new CSSGridLineNamesValue());
>+        return adoptRef(*new CSSGridLineNamesValue);
>     }
> 
>     String customCSSText() const;
> 
>-    PassRefPtr<CSSGridLineNamesValue> cloneForCSSOM() const;
>+    Ref<CSSGridLineNamesValue> cloneForCSSOM() const;
> 
> private:
>     CSSGridLineNamesValue();
>diff --git a/Source/WebCore/css/CSSImportRule.h b/Source/WebCore/css/CSSImportRule.h
>index 59a2e9c0fc638518851ef4b9e5bbbbde32a0a007..d448aff739e235b9deea8cfa0e0f7c8983da32f5 100644
>--- a/Source/WebCore/css/CSSImportRule.h
>+++ b/Source/WebCore/css/CSSImportRule.h
>@@ -33,7 +33,7 @@ class StyleRuleImport;
> 
> class CSSImportRule final : public CSSRule {
> public:
>-    static PassRefPtr<CSSImportRule> create(StyleRuleImport& rule, CSSStyleSheet* sheet) { return adoptRef(new CSSImportRule(rule, sheet)); }
>+    static Ref<CSSImportRule> create(StyleRuleImport& rule, CSSStyleSheet* sheet) { return adoptRef(*new CSSImportRule(rule, sheet)); }
>     
>     virtual ~CSSImportRule();
> 
>diff --git a/Source/WebCore/css/CSSKeyframeRule.h b/Source/WebCore/css/CSSKeyframeRule.h
>index 2dae4094288c81ff24096820b30d869182ff6c9f..ad8be3df6bfdc72cfcfc7c13935c68cb405d4ae7 100644
>--- a/Source/WebCore/css/CSSKeyframeRule.h
>+++ b/Source/WebCore/css/CSSKeyframeRule.h
>@@ -39,9 +39,9 @@ class CSSKeyframesRule;
> class StyleKeyframe : public RefCounted<StyleKeyframe> {
>     WTF_MAKE_FAST_ALLOCATED;
> public:
>-    static PassRefPtr<StyleKeyframe> create(Ref<StyleProperties>&& properties)
>+    static Ref<StyleKeyframe> create(Ref<StyleProperties>&& properties)
>     {
>-        return adoptRef(new StyleKeyframe(WTF::move(properties)));
>+        return adoptRef(*new StyleKeyframe(WTF::move(properties)));
>     }
>     ~StyleKeyframe();
> 
>diff --git a/Source/WebCore/css/CSSKeyframesRule.h b/Source/WebCore/css/CSSKeyframesRule.h
>index 449d8bd412ff7c20d0d50565a66be22608679c00..865bbed0c30173875f931e032c70fc2707751d60 100644
>--- a/Source/WebCore/css/CSSKeyframesRule.h
>+++ b/Source/WebCore/css/CSSKeyframesRule.h
>@@ -67,7 +67,7 @@ private:
> 
> class CSSKeyframesRule final : public CSSRule {
> public:
>-    static PassRefPtr<CSSKeyframesRule> create(StyleRuleKeyframes& rule, CSSStyleSheet* sheet) { return adoptRef(new CSSKeyframesRule(rule, sheet)); }
>+    static Ref<CSSKeyframesRule> create(StyleRuleKeyframes& rule, CSSStyleSheet* sheet) { return adoptRef(*new CSSKeyframesRule(rule, sheet)); }
> 
>     virtual ~CSSKeyframesRule();
> 
>diff --git a/Source/WebCore/css/CSSMediaRule.h b/Source/WebCore/css/CSSMediaRule.h
>index 9d0943fa28a02c0342d62c2ada2463d4902fb818..21a53673c5b2db461476eaa1813d3fcb5672cb97 100644
>--- a/Source/WebCore/css/CSSMediaRule.h
>+++ b/Source/WebCore/css/CSSMediaRule.h
>@@ -32,7 +32,7 @@ class StyleRuleMedia;
> 
> class CSSMediaRule final : public CSSGroupingRule {
> public:
>-    static PassRefPtr<CSSMediaRule> create(StyleRuleMedia& rule, CSSStyleSheet* sheet) { return adoptRef(new CSSMediaRule(rule, sheet)); }
>+    static Ref<CSSMediaRule> create(StyleRuleMedia& rule, CSSStyleSheet* sheet) { return adoptRef(*new CSSMediaRule(rule, sheet)); }
> 
>     virtual ~CSSMediaRule();
> 
>diff --git a/Source/WebCore/css/CSSPageRule.h b/Source/WebCore/css/CSSPageRule.h
>index 4aba6dab8d75890437c30a0f09b1966a3a1adfd3..5644cd957779899b8f1be24ac603cffe5b9722ca 100644
>--- a/Source/WebCore/css/CSSPageRule.h
>+++ b/Source/WebCore/css/CSSPageRule.h
>@@ -33,7 +33,7 @@ class StyleRuleCSSStyleDeclaration;
> 
> class CSSPageRule final : public CSSRule {
> public:
>-    static PassRefPtr<CSSPageRule> create(StyleRulePage& rule, CSSStyleSheet* sheet) { return adoptRef(new CSSPageRule(rule, sheet)); }
>+    static Ref<CSSPageRule> create(StyleRulePage& rule, CSSStyleSheet* sheet) { return adoptRef(*new CSSPageRule(rule, sheet)); }
> 
>     virtual ~CSSPageRule();
> 
>diff --git a/Source/WebCore/css/CSSParser.cpp b/Source/WebCore/css/CSSParser.cpp
>index 08302f7e86966f257e71c2cfd04004a50637284f..50b65f865de59dd41e6ac240af586d20f5b05b1c 100644
>--- a/Source/WebCore/css/CSSParser.cpp
>+++ b/Source/WebCore/css/CSSParser.cpp
>@@ -5585,8 +5585,12 @@ bool CSSParser::parseGridLineNames(CSSParserValueList& inputList, CSSValueList&
> 
>     // Need to ensure the identList is at the heading index, since the parserList might have been rewound.
>     identList.setCurrentIndex(0);
>+    RefPtr<CSSGridLineNamesValue> lineNames;
> 
>-    RefPtr<CSSGridLineNamesValue> lineNames = previousNamedAreaTrailingLineNames ? previousNamedAreaTrailingLineNames : CSSGridLineNamesValue::create();
>+    if (previousNamedAreaTrailingLineNames != nullptr)
>+        lineNames = previousNamedAreaTrailingLineNames;
>+    else
>+        lineNames = CSSGridLineNamesValue::create();
>     while (CSSParserValue* identValue = identList.current()) {
>         ASSERT(identValue->unit == CSSPrimitiveValue::CSS_IDENT);
>         lineNames->append(createPrimitiveStringValue(*identValue));
>@@ -5935,7 +5939,7 @@ bool CSSParser::parseDashboardRegions(CSSPropertyID propId, bool important)
>     }
> 
>     if (valid)
>-        addProperty(propId, cssValuePool().createValue(firstRegion.release()), important);
>+        addProperty(propId, cssValuePool().createValue(WTF::move(firstRegion)), important);
> 
>     return valid;
> }
>@@ -6093,7 +6097,7 @@ bool CSSParser::parseClipShape(CSSPropertyID propId, bool important)
>     // rect(t, r, b, l) || rect(t r b l)
>     if (args->size() != 4 && args->size() != 7)
>         return false;
>-    RefPtr<Rect> rect = Rect::create();
>+    Ref<Rect> rect = Rect::create();
>     bool valid = true;
>     int i = 0;
>     CSSParserValue* argument = args->current();
>@@ -6123,7 +6127,7 @@ bool CSSParser::parseClipShape(CSSPropertyID propId, bool important)
>         i++;
>     }
>     if (valid) {
>-        addProperty(propId, cssValuePool().createValue(rect.release()), important);
>+        addProperty(propId, cssValuePool().createValue(WTF::move(rect)), important);
>         m_valueList->next();
>         return true;
>     }
>@@ -6523,7 +6527,7 @@ PassRefPtr<CSSPrimitiveValue> CSSParser::parseBasicShape()
>         return nullptr;
> 
>     m_valueList->next();
>-    return cssValuePool().createValue(shape.release());
>+    return cssValuePool().createValue(WTF::move(shape));
> }
> 
> // [ 'font-style' || 'font-variant' || 'font-weight' ]? 'font-size' [ / 'line-height' ]? 'font-family'
>@@ -8090,14 +8094,14 @@ public:
>             m_left = m_right;
> 
>         // Now build a rect value to hold all four of our primitive values.
>-        RefPtr<Quad> quad = Quad::create();
>+        Ref<Quad> quad = Quad::create();
>         quad->setTop(m_top);
>         quad->setRight(m_right);
>         quad->setBottom(m_bottom);
>         quad->setLeft(m_left);
> 
>         // Make our new border image value now.
>-        return CSSBorderImageSliceValue::create(cssValuePool().createValue(quad.release()), m_fill);
>+        return CSSBorderImageSliceValue::create(cssValuePool().createValue(WTF::move(quad)), m_fill);
>     }
> 
> private:
>@@ -8208,14 +8212,14 @@ public:
>             m_left = m_right;
> 
>         // Now build a quad value to hold all four of our primitive values.
>-        RefPtr<Quad> quad = Quad::create();
>+        Ref<Quad> quad = Quad::create();
>         quad->setTop(m_top);
>         quad->setRight(m_right);
>         quad->setBottom(m_bottom);
>         quad->setLeft(m_left);
> 
>         // Make our new value now.
>-        return cssValuePool().createValue(quad.release());
>+        return cssValuePool().createValue(WTF::move(quad));
>     }
> 
> private:
>diff --git a/Source/WebCore/css/CSSPrimitiveValue.cpp b/Source/WebCore/css/CSSPrimitiveValue.cpp
>index 71798ee8d6b53cd02d1505935698a25e8a1b1310..ce010c0a9fbbc4e1cd222b43b0dd0b02dc01dd0d 100644
>--- a/Source/WebCore/css/CSSPrimitiveValue.cpp
>+++ b/Source/WebCore/css/CSSPrimitiveValue.cpp
>@@ -237,6 +237,24 @@ static const AtomicString& valueName(CSSValueID valueID)
>     return keywordString;
> }
> 
>+CSSPrimitiveValue::CSSPrimitiveValue(CSSBasicShape* shape)
>+    : CSSValue(PrimitiveClass)
>+{
>+    init(RefPtr<CSSBasicShape>(shape));
>+}
>+
>+CSSPrimitiveValue::CSSPrimitiveValue(CSSCalcValue* val)
>+    : CSSValue(PrimitiveClass)
>+{
>+    init(RefPtr<CSSCalcValue>(val));
>+}
>+
>+CSSPrimitiveValue::CSSPrimitiveValue(DashboardRegion* region)
>+    : CSSValue(PrimitiveClass)
>+{
>+    init(RefPtr<DashboardRegion>(region));
>+}
>+
> CSSPrimitiveValue::CSSPrimitiveValue(CSSValueID valueID)
>     : CSSValue(PrimitiveClass)
> {
>@@ -307,7 +325,7 @@ CSSPrimitiveValue::CSSPrimitiveValue(const Length& length, const RenderStyle* st
>         return;
>     case Calculated: {
>         RefPtr<CSSCalcValue> calcValue = CSSCalcValue::create(length.calculationValue(), *style);
>-        init(calcValue.release());
>+        init(WTF::move(calcValue));
>         return;
>     }
>     case Relative:
>@@ -377,7 +395,7 @@ void CSSPrimitiveValue::init(const LengthSize& lengthSize, const RenderStyle* st
> {
>     m_primitiveUnitType = CSS_PAIR;
>     m_hasCachedCSSText = false;
>-    m_value.pair = Pair::create(create(lengthSize.width(), style), create(lengthSize.height(), style)).leakRef();
>+    m_value.pair = &Pair::create(create(lengthSize.width(), style), create(lengthSize.height(), style)).leakRef();
> }
> 
> void CSSPrimitiveValue::init(Ref<Counter>&& counter)
>@@ -387,31 +405,31 @@ void CSSPrimitiveValue::init(Ref<Counter>&& counter)
>     m_value.counter = &counter.leakRef();
> }
> 
>-void CSSPrimitiveValue::init(PassRefPtr<Rect> r)
>+void CSSPrimitiveValue::init(Ref<Rect>&& r)
> {
>     m_primitiveUnitType = CSS_RECT;
>     m_hasCachedCSSText = false;
>-    m_value.rect = r.leakRef();
>+    m_value.rect = &r.leakRef();
> }
> 
>-void CSSPrimitiveValue::init(PassRefPtr<Quad> quad)
>+void CSSPrimitiveValue::init(Ref<Quad>&& quad)
> {
>     m_primitiveUnitType = CSS_QUAD;
>     m_hasCachedCSSText = false;
>-    m_value.quad = quad.leakRef();
>+    m_value.quad = &quad.leakRef();
> }
> 
> #if ENABLE(CSS_SCROLL_SNAP)
>-void CSSPrimitiveValue::init(PassRefPtr<LengthRepeat> lengthRepeat)
>+void CSSPrimitiveValue::init(Ref<LengthRepeat>&& lengthRepeat)
> {
>     m_primitiveUnitType = CSS_LENGTH_REPEAT;
>     m_hasCachedCSSText = false;
>-    m_value.lengthRepeat = lengthRepeat.leakRef();
>+    m_value.lengthRepeat = &lengthRepeat.leakRef();
> }
> #endif
> 
> #if ENABLE(DASHBOARD_SUPPORT)
>-void CSSPrimitiveValue::init(PassRefPtr<DashboardRegion> r)
>+void CSSPrimitiveValue::init(RefPtr<DashboardRegion>&& r)
> {
>     m_primitiveUnitType = CSS_DASHBOARD_REGION;
>     m_hasCachedCSSText = false;
>@@ -419,21 +437,21 @@ void CSSPrimitiveValue::init(PassRefPtr<DashboardRegion> r)
> }
> #endif
> 
>-void CSSPrimitiveValue::init(PassRefPtr<Pair> p)
>+void CSSPrimitiveValue::init(Ref<Pair>&& p)
> {
>     m_primitiveUnitType = CSS_PAIR;
>     m_hasCachedCSSText = false;
>-    m_value.pair = p.leakRef();
>+    m_value.pair = &p.leakRef();
> }
> 
>-void CSSPrimitiveValue::init(PassRefPtr<CSSCalcValue> c)
>+void CSSPrimitiveValue::init(RefPtr<CSSCalcValue>&& c)
> {
>     m_primitiveUnitType = CSS_CALC;
>     m_hasCachedCSSText = false;
>     m_value.calc = c.leakRef();
> }
> 
>-void CSSPrimitiveValue::init(PassRefPtr<CSSBasicShape> shape)
>+void CSSPrimitiveValue::init(RefPtr<CSSBasicShape>&& shape)
> {
>     m_primitiveUnitType = CSS_SHAPE;
>     m_hasCachedCSSText = false;
>diff --git a/Source/WebCore/css/CSSPrimitiveValue.h b/Source/WebCore/css/CSSPrimitiveValue.h
>index b0c221e0648de3e9f634223da4455ec1f20231fd..c9910f998e554e9924ad5f993967e644e99b68ca 100644
>--- a/Source/WebCore/css/CSSPrimitiveValue.h
>+++ b/Source/WebCore/css/CSSPrimitiveValue.h
>@@ -386,13 +386,17 @@ private:
>     template<typename T> CSSPrimitiveValue(T* val)
>         : CSSValue(PrimitiveClass)
>     {
>-        init(PassRefPtr<T>(val));
>+        init(Ref<T>(*val));
>     }
> 
>-    template<typename T> CSSPrimitiveValue(PassRefPtr<T> value)
>+    CSSPrimitiveValue(CSSBasicShape*);
>+    CSSPrimitiveValue(CSSCalcValue*);
>+    CSSPrimitiveValue(DashboardRegion*);
>+
>+    template<typename T> CSSPrimitiveValue(RefPtr<T>&& value)
>         : CSSValue(PrimitiveClass)
>     {
>-        init(value);
>+        init(WTF::move(value));
>     }
> 
>     template<typename T> CSSPrimitiveValue(Ref<T>&& value)
>@@ -408,15 +412,15 @@ private:
>     void init(const Length&);
>     void init(const LengthSize&, const RenderStyle*);
>     void init(Ref<Counter>&&);
>-    void init(PassRefPtr<Rect>);
>-    void init(PassRefPtr<Pair>);
>-    void init(PassRefPtr<Quad>);
>+    void init(Ref<Rect>&&);
>+    void init(Ref<Pair>&&);
>+    void init(Ref<Quad>&&);
> #if ENABLE(CSS_SCROLL_SNAP)
>-    void init(PassRefPtr<LengthRepeat>);
>+    void init(Ref<LengthRepeat>&&);
> #endif
>-    void init(PassRefPtr<DashboardRegion>); // FIXME: Dashboard region should not be a primitive value.
>-    void init(PassRefPtr<CSSBasicShape>);
>-    void init(PassRefPtr<CSSCalcValue>);
>+    void init(RefPtr<DashboardRegion>&&); // FIXME: Dashboard region should not be a primitive value.
>+    void init(RefPtr<CSSBasicShape>&&);
>+    void init(RefPtr<CSSCalcValue>&&);
>     bool getDoubleValueInternal(UnitTypes targetUnitType, double* result) const;
> 
>     double computeLengthDouble(const CSSToLengthConversionData&) const;
>diff --git a/Source/WebCore/css/CSSPropertySourceData.h b/Source/WebCore/css/CSSPropertySourceData.h
>index c995a00da1a1e81262b4686bf757462ef0ad36b4..414da5b199fb3f55ecbcf4b12e310674f1c12dbd 100644
>--- a/Source/WebCore/css/CSSPropertySourceData.h
>+++ b/Source/WebCore/css/CSSPropertySourceData.h
>@@ -67,9 +67,9 @@ struct CSSPropertySourceData {
> };
> 
> struct CSSStyleSourceData : public RefCounted<CSSStyleSourceData> {
>-    static PassRefPtr<CSSStyleSourceData> create()
>+    static Ref<CSSStyleSourceData> create()
>     {
>-        return adoptRef(new CSSStyleSourceData());
>+        return adoptRef(*new CSSStyleSourceData);
>     }
> 
>     Vector<CSSPropertySourceData> propertyData;
>@@ -95,14 +95,14 @@ struct CSSRuleSourceData : public RefCounted<CSSRuleSourceData> {
>         SUPPORTS_RULE,
>     };
> 
>-    static PassRefPtr<CSSRuleSourceData> create(Type type)
>+    static Ref<CSSRuleSourceData> create(Type type)
>     {
>-        return adoptRef(new CSSRuleSourceData(type));
>+        return adoptRef(*new CSSRuleSourceData(type));
>     }
> 
>-    static PassRefPtr<CSSRuleSourceData> createUnknown()
>+    static Ref<CSSRuleSourceData> createUnknown()
>     {
>-        return adoptRef(new CSSRuleSourceData(UNKNOWN_RULE));
>+        return adoptRef(*new CSSRuleSourceData(UNKNOWN_RULE));
>     }
> 
>     CSSRuleSourceData(Type type)
>diff --git a/Source/WebCore/css/CSSRuleList.h b/Source/WebCore/css/CSSRuleList.h
>index 27144cf9fe1b4ab19470dc2984c2babd6939da1b..548f52eddf77904e76887523a738497e2491af27 100644
>--- a/Source/WebCore/css/CSSRuleList.h
>+++ b/Source/WebCore/css/CSSRuleList.h
>@@ -52,7 +52,7 @@ protected:
> 
> class StaticCSSRuleList final : public CSSRuleList {
> public:
>-    static PassRefPtr<StaticCSSRuleList> create() { return adoptRef(new StaticCSSRuleList()); }
>+    static Ref<StaticCSSRuleList> create() { return adoptRef(*new StaticCSSRuleList); }
> 
>     virtual void ref() override { ++m_refCount; }
>     virtual void deref() override;
>diff --git a/Source/WebCore/css/CSSSegmentedFontFace.h b/Source/WebCore/css/CSSSegmentedFontFace.h
>index f627fd130588c4ec5331a677b665d1a20b33f8bd..2e563663f2f5c1fe41993c9b08baaed2be86492a 100644
>--- a/Source/WebCore/css/CSSSegmentedFontFace.h
>+++ b/Source/WebCore/css/CSSSegmentedFontFace.h
>@@ -40,7 +40,7 @@ class FontDescription;
> 
> class CSSSegmentedFontFace : public RefCounted<CSSSegmentedFontFace> {
> public:
>-    static PassRefPtr<CSSSegmentedFontFace> create(CSSFontSelector* selector) { return adoptRef(new CSSSegmentedFontFace(selector)); }
>+    static Ref<CSSSegmentedFontFace> create(CSSFontSelector* selector) { return adoptRef(*new CSSSegmentedFontFace(selector)); }
>     ~CSSSegmentedFontFace();
> 
>     CSSFontSelector* fontSelector() const { return m_fontSelector; }
>diff --git a/Source/WebCore/css/CSSSelector.cpp b/Source/WebCore/css/CSSSelector.cpp
>index 70819260ffdeb0b8129ec51978509a14be4a5bc0..795e80651efdfc301494a2a9176eefebef6b42e9 100644
>--- a/Source/WebCore/css/CSSSelector.cpp
>+++ b/Source/WebCore/css/CSSSelector.cpp
>@@ -82,7 +82,7 @@ void CSSSelector::createRareData()
>     if (m_hasRareData)
>         return;
>     // Move the value to the rare data stucture.
>-    m_data.m_rareData = RareData::create(adoptRef(m_data.m_value)).leakRef();
>+    m_data.m_rareData = &RareData::create(adoptRef(m_data.m_value)).leakRef();
>     m_hasRareData = true;
> }
> 
>diff --git a/Source/WebCore/css/CSSSelector.h b/Source/WebCore/css/CSSSelector.h
>index 4c347d2cf162f56e95fdbd3ce4173d310492fe36..11a6642e56af4e8e2d9d7630f3099a84679cb212 100644
>--- a/Source/WebCore/css/CSSSelector.h
>+++ b/Source/WebCore/css/CSSSelector.h
>@@ -324,7 +324,7 @@ namespace WebCore {
>         CSSSelector& operator=(const CSSSelector&);
> 
>         struct RareData : public RefCounted<RareData> {
>-            static PassRefPtr<RareData> create(PassRefPtr<AtomicStringImpl> value) { return adoptRef(new RareData(value)); }
>+            static Ref<RareData> create(PassRefPtr<AtomicStringImpl> value) { return adoptRef(*new RareData(value)); }
>             ~RareData();
> 
>             bool parseNth();
>diff --git a/Source/WebCore/css/CSSStyleRule.h b/Source/WebCore/css/CSSStyleRule.h
>index 7d9ea7876009747bbead1370934a7bc4d0fb701a..9676a84582c0dc1ad30c6cfc58d7d3ad509ab8d3 100644
>--- a/Source/WebCore/css/CSSStyleRule.h
>+++ b/Source/WebCore/css/CSSStyleRule.h
>@@ -32,7 +32,7 @@ class StyleRule;
> 
> class CSSStyleRule final : public CSSRule {
> public:
>-    static PassRefPtr<CSSStyleRule> create(StyleRule& rule, CSSStyleSheet* sheet) { return adoptRef(new CSSStyleRule(rule, sheet)); }
>+    static Ref<CSSStyleRule> create(StyleRule& rule, CSSStyleSheet* sheet) { return adoptRef(*new CSSStyleRule(rule, sheet)); }
> 
>     virtual ~CSSStyleRule();
> 
>diff --git a/Source/WebCore/css/CSSSupportsRule.h b/Source/WebCore/css/CSSSupportsRule.h
>index 6480119cdd8d8055c62b070e43855619f03d2138..8a3e36bf7ef89f83885cc672835ddbdcd5183d3a 100644
>--- a/Source/WebCore/css/CSSSupportsRule.h
>+++ b/Source/WebCore/css/CSSSupportsRule.h
>@@ -38,9 +38,9 @@ class StyleRuleSupports;
> 
> class CSSSupportsRule final : public CSSGroupingRule {
> public:
>-    static PassRefPtr<CSSSupportsRule> create(StyleRuleSupports& rule, CSSStyleSheet* sheet)
>+    static Ref<CSSSupportsRule> create(StyleRuleSupports& rule, CSSStyleSheet* sheet)
>     {
>-        return adoptRef(new CSSSupportsRule(rule, sheet));
>+        return adoptRef(*new CSSSupportsRule(rule, sheet));
>     }
> 
>     virtual ~CSSSupportsRule() { }
>diff --git a/Source/WebCore/css/FontLoader.cpp b/Source/WebCore/css/FontLoader.cpp
>index 808852cfd511ceb752bd663dfa66bc6e00f97700..fc2b36f7b29fbbaf04c7aa1855d7990ace688701 100644
>--- a/Source/WebCore/css/FontLoader.cpp
>+++ b/Source/WebCore/css/FontLoader.cpp
>@@ -48,9 +48,9 @@ static const char* const defaultFontFamily = "sans-serif";
> 
> class LoadFontCallback : public CSSSegmentedFontFace::LoadFontCallback {
> public:
>-    static PassRefPtr<LoadFontCallback> create(int numLoading, FontLoader& fontLoader, PassRefPtr<VoidCallback> loadCallback, PassRefPtr<VoidCallback> errorCallback)
>+    static Ref<LoadFontCallback> create(int numLoading, FontLoader& fontLoader, PassRefPtr<VoidCallback> loadCallback, PassRefPtr<VoidCallback> errorCallback)
>     {
>-        return adoptRef<LoadFontCallback>(new LoadFontCallback(numLoading, fontLoader, loadCallback, errorCallback));
>+        return adoptRef<LoadFontCallback>(*new LoadFontCallback(numLoading, fontLoader, loadCallback, errorCallback));
>     }
> 
>     static PassRefPtr<LoadFontCallback> createFromParams(const Dictionary& params, FontLoader& fontLoader, const FontCascade& font)
>diff --git a/Source/WebCore/css/LengthRepeat.h b/Source/WebCore/css/LengthRepeat.h
>index ae269e9832dc464341a802f7f558c74bf42ebf71..7758856a61bccee2b5acbf5fb347dc4186ee57ce 100644
>--- a/Source/WebCore/css/LengthRepeat.h
>+++ b/Source/WebCore/css/LengthRepeat.h
>@@ -36,7 +36,7 @@ namespace WebCore {
> 
> class LengthRepeat : public RefCounted<LengthRepeat> {
> public:
>-    static PassRefPtr<LengthRepeat> create(PassRefPtr<CSSValue> interval) { return adoptRef(new LengthRepeat(interval)); }
>+    static Ref<LengthRepeat> create(PassRefPtr<CSSValue> interval) { return adoptRef(*new LengthRepeat(interval)); }
> 
>     PassRefPtr<LengthRepeat> cloneForCSSOM() const { return create(interval()); }
> 
>diff --git a/Source/WebCore/css/MediaList.h b/Source/WebCore/css/MediaList.h
>index 1bc7fb0ef10acd5257af5d863d9adcad4d0f2611..04e093ea24329a3a832f63bbfa5b5ec4f9179608 100644
>--- a/Source/WebCore/css/MediaList.h
>+++ b/Source/WebCore/css/MediaList.h
>@@ -39,17 +39,17 @@ class MediaQuery;
> 
> class MediaQuerySet : public RefCounted<MediaQuerySet> {
> public:
>-    static PassRefPtr<MediaQuerySet> create()
>+    static Ref<MediaQuerySet> create()
>     {
>-        return adoptRef(new MediaQuerySet());
>+        return adoptRef(*new MediaQuerySet);
>     }
>-    static PassRefPtr<MediaQuerySet> create(const String& mediaString)
>+    static Ref<MediaQuerySet> create(const String& mediaString)
>     {
>-        return adoptRef(new MediaQuerySet(mediaString, false));
>+        return adoptRef(*new MediaQuerySet(mediaString, false));
>     }
>-    static PassRefPtr<MediaQuerySet> createAllowingDescriptionSyntax(const String& mediaString)
>+    static Ref<MediaQuerySet> createAllowingDescriptionSyntax(const String& mediaString)
>     {
>-        return adoptRef(new MediaQuerySet(mediaString, true));
>+        return adoptRef(*new MediaQuerySet(mediaString, true));
>     }
>     ~MediaQuerySet();
>     
>@@ -80,13 +80,13 @@ private:
> 
> class MediaList : public RefCounted<MediaList> {
> public:
>-    static PassRefPtr<MediaList> create(MediaQuerySet* mediaQueries, CSSStyleSheet* parentSheet)
>+    static Ref<MediaList> create(MediaQuerySet* mediaQueries, CSSStyleSheet* parentSheet)
>     {
>-        return adoptRef(new MediaList(mediaQueries, parentSheet));
>+        return adoptRef(*new MediaList(mediaQueries, parentSheet));
>     }
>-    static PassRefPtr<MediaList> create(MediaQuerySet* mediaQueries, CSSRule* parentRule)
>+    static Ref<MediaList> create(MediaQuerySet* mediaQueries, CSSRule* parentRule)
>     {
>-        return adoptRef(new MediaList(mediaQueries, parentRule));
>+        return adoptRef(*new MediaList(mediaQueries, parentRule));
>     }
> 
>     ~MediaList();
>diff --git a/Source/WebCore/css/MediaQueryList.cpp b/Source/WebCore/css/MediaQueryList.cpp
>index 4b121d18bade808c680c62bbf516b17a7f73da8b..7b4fd02dd54b74d40172e304b20cddac79b0be7e 100644
>--- a/Source/WebCore/css/MediaQueryList.cpp
>+++ b/Source/WebCore/css/MediaQueryList.cpp
>@@ -27,9 +27,9 @@
> 
> namespace WebCore {
> 
>-PassRefPtr<MediaQueryList> MediaQueryList::create(PassRefPtr<MediaQueryMatcher> vector, PassRefPtr<MediaQuerySet> media, bool matches)
>+Ref<MediaQueryList> MediaQueryList::create(PassRefPtr<MediaQueryMatcher> vector, PassRefPtr<MediaQuerySet> media, bool matches)
> {
>-    return adoptRef(new MediaQueryList(vector, media, matches));
>+    return adoptRef(*new MediaQueryList(vector, media, matches));
> }
> 
> MediaQueryList::MediaQueryList(PassRefPtr<MediaQueryMatcher> vector, PassRefPtr<MediaQuerySet> media, bool matches)
>diff --git a/Source/WebCore/css/MediaQueryList.h b/Source/WebCore/css/MediaQueryList.h
>index 5601ec78736f3437d2f79527150e25a0aa26fe50..69afa76b0e06b028444794cec1f09be816ba5689 100644
>--- a/Source/WebCore/css/MediaQueryList.h
>+++ b/Source/WebCore/css/MediaQueryList.h
>@@ -38,7 +38,7 @@ class MediaQuerySet;
> 
> class MediaQueryList : public RefCounted<MediaQueryList> {
> public:
>-    static PassRefPtr<MediaQueryList> create(PassRefPtr<MediaQueryMatcher>, PassRefPtr<MediaQuerySet>, bool);
>+    static Ref<MediaQueryList> create(PassRefPtr<MediaQueryMatcher>, PassRefPtr<MediaQuerySet>, bool);
>     ~MediaQueryList();
> 
>     String media() const;
>diff --git a/Source/WebCore/css/MediaQueryMatcher.h b/Source/WebCore/css/MediaQueryMatcher.h
>index 4d549b96a143a4f5e08f59ec10e4bccf54fa4518..98fb9cf5a28536b8f835162278c7f0b2e99e9b10 100644
>--- a/Source/WebCore/css/MediaQueryMatcher.h
>+++ b/Source/WebCore/css/MediaQueryMatcher.h
>@@ -40,7 +40,7 @@ class MediaQuerySet;
> 
> class MediaQueryMatcher : public RefCounted<MediaQueryMatcher> {
> public:
>-    static PassRefPtr<MediaQueryMatcher> create(Document* document) { return adoptRef(new MediaQueryMatcher(document)); }
>+    static Ref<MediaQueryMatcher> create(Document* document) { return adoptRef(*new MediaQueryMatcher(document)); }
>     ~MediaQueryMatcher();
>     void documentDestroyed();
> 
>diff --git a/Source/WebCore/css/Pair.h b/Source/WebCore/css/Pair.h
>index 013fd444be097ccf53b6125059488137439c104c..2c6cd01e765e0ebf5785e7b990ed748cf98fdcf0 100644
>--- a/Source/WebCore/css/Pair.h
>+++ b/Source/WebCore/css/Pair.h
>@@ -34,13 +34,13 @@ namespace WebCore {
> // it (eliminating some extra -webkit- internal properties).
> class Pair : public RefCounted<Pair> {
> public:
>-    static PassRefPtr<Pair> create()
>+    static Ref<Pair> create()
>     {
>-        return adoptRef(new Pair);
>+        return adoptRef(*new Pair);
>     }
>-    static PassRefPtr<Pair> create(PassRefPtr<CSSPrimitiveValue> first, PassRefPtr<CSSPrimitiveValue> second)
>+    static Ref<Pair> create(PassRefPtr<CSSPrimitiveValue> first, PassRefPtr<CSSPrimitiveValue> second)
>     {
>-        return adoptRef(new Pair(first, second));
>+        return adoptRef(*new Pair(first, second));
>     }
>     virtual ~Pair() { }
> 
>diff --git a/Source/WebCore/css/Rect.h b/Source/WebCore/css/Rect.h
>index d9869f448547f0692d3badea56e3f6c5d17b0109..dd9cd045dd65e70e25133c12d65318f64f542ba6 100644
>--- a/Source/WebCore/css/Rect.h
>+++ b/Source/WebCore/css/Rect.h
>@@ -68,9 +68,9 @@ private:
> 
> class Rect : public RectBase, public RefCounted<Rect> {
> public:
>-    static PassRefPtr<Rect> create() { return adoptRef(new Rect); }
>+    static Ref<Rect> create() { return adoptRef(*new Rect); }
>     
>-    PassRefPtr<Rect> cloneForCSSOM() const { return adoptRef(new Rect(*this)); }
>+    Ref<Rect> cloneForCSSOM() const { return adoptRef(*new Rect(*this)); }
> 
>     String cssText() const
>     {
>@@ -88,9 +88,9 @@ private:
> 
> class Quad : public RectBase, public RefCounted<Quad> {
> public:
>-    static PassRefPtr<Quad> create() { return adoptRef(new Quad); }
>+    static Ref<Quad> create() { return adoptRef(*new Quad); }
>     
>-    PassRefPtr<Quad> cloneForCSSOM() const { return adoptRef(new Quad(*this)); }
>+    Ref<Quad> cloneForCSSOM() const { return adoptRef(*new Quad(*this)); }
> 
>     String cssText() const
>     {
>diff --git a/Source/WebCore/css/StyleMedia.h b/Source/WebCore/css/StyleMedia.h
>index 7bd529631ac735faf9c107d91c22bf3677926db6..07ae228dea6bcb45ab3e2ce22d727d2ca9222591 100644
>--- a/Source/WebCore/css/StyleMedia.h
>+++ b/Source/WebCore/css/StyleMedia.h
>@@ -37,7 +37,7 @@ class Frame;
> 
> class StyleMedia : public RefCounted<StyleMedia>, public DOMWindowProperty {
> public:
>-    static PassRefPtr<StyleMedia> create(Frame* frame) { return adoptRef(new StyleMedia(frame));}
>+    static Ref<StyleMedia> create(Frame* frame) { return adoptRef(*new StyleMedia(frame));}
> 
>     String type() const;
>     bool matchMedium(const String&) const;
>diff --git a/Source/WebCore/css/StyleResolver.cpp b/Source/WebCore/css/StyleResolver.cpp
>index 025301d5f97b73633f9d8a73fc3dba38f15c80d5..62bdaea0cf74ad41b7f85e289e7fe75879dd6bcd 100644
>--- a/Source/WebCore/css/StyleResolver.cpp
>+++ b/Source/WebCore/css/StyleResolver.cpp
>@@ -935,7 +935,7 @@ void StyleResolver::keyframeStylesForAnimation(Element* e, const RenderStyle* el
>     if (initialListSize > 0 && list[0].key()) {
>         static StyleKeyframe* zeroPercentKeyframe;
>         if (!zeroPercentKeyframe) {
>-            zeroPercentKeyframe = StyleKeyframe::create(MutableStyleProperties::create()).leakRef();
>+            zeroPercentKeyframe = &StyleKeyframe::create(MutableStyleProperties::create()).leakRef();
>             zeroPercentKeyframe->setKeyText("0%");
>         }
>         KeyframeValue keyframeValue(0, nullptr);
>@@ -947,7 +947,7 @@ void StyleResolver::keyframeStylesForAnimation(Element* e, const RenderStyle* el
>     if (initialListSize > 0 && (list[list.size() - 1].key() != 1)) {
>         static StyleKeyframe* hundredPercentKeyframe;
>         if (!hundredPercentKeyframe) {
>-            hundredPercentKeyframe = StyleKeyframe::create(MutableStyleProperties::create()).leakRef();
>+            hundredPercentKeyframe = &StyleKeyframe::create(MutableStyleProperties::create()).leakRef();
>             hundredPercentKeyframe->setKeyText("100%");
>         }
>         KeyframeValue keyframeValue(1, nullptr);
>diff --git a/Source/WebCore/css/StyleSheetList.h b/Source/WebCore/css/StyleSheetList.h
>index dd273ac00c7bc57248feb6b0bda9fa72f6425819..12a7c459dba3cca3f938b91f64398a53be5e7f25 100644
>--- a/Source/WebCore/css/StyleSheetList.h
>+++ b/Source/WebCore/css/StyleSheetList.h
>@@ -34,7 +34,7 @@ class StyleSheet;
> 
> class StyleSheetList : public RefCounted<StyleSheetList> {
> public:
>-    static PassRefPtr<StyleSheetList> create(Document* document) { return adoptRef(new StyleSheetList(document)); }
>+    static Ref<StyleSheetList> create(Document* document) { return adoptRef(*new StyleSheetList(document)); }
>     ~StyleSheetList();
> 
>     unsigned length() const;
>diff --git a/Source/WebCore/css/ViewportStyleResolver.h b/Source/WebCore/css/ViewportStyleResolver.h
>index deaa992d0084278eea40b89fcfb57926639fed86..1af83c6507fb38c502c9fbb9a737ab902defa63b 100644
>--- a/Source/WebCore/css/ViewportStyleResolver.h
>+++ b/Source/WebCore/css/ViewportStyleResolver.h
>@@ -46,9 +46,9 @@ class StyleRuleViewport;
> 
> class ViewportStyleResolver : public RefCounted<ViewportStyleResolver> {
> public:
>-    static PassRefPtr<ViewportStyleResolver> create(Document* document)
>+    static Ref<ViewportStyleResolver> create(Document* document)
>     {
>-        return adoptRef(new ViewportStyleResolver(document));
>+        return adoptRef(*new ViewportStyleResolver(document));
>     }
> 
>     ~ViewportStyleResolver();
>diff --git a/Source/WebCore/css/WebKitCSSMatrix.h b/Source/WebCore/css/WebKitCSSMatrix.h
>index 67e2f528a5217fc7637ab987041f50068a01ff09..ec1db9f05650e4af5f00e60801b9948040c50d76 100644
>--- a/Source/WebCore/css/WebKitCSSMatrix.h
>+++ b/Source/WebCore/css/WebKitCSSMatrix.h
>@@ -38,13 +38,13 @@ typedef int ExceptionCode;
> 
> class WebKitCSSMatrix final : public ScriptWrappable, public RefCounted<WebKitCSSMatrix> {
> public:
>-    static PassRefPtr<WebKitCSSMatrix> create(const TransformationMatrix& m)
>+    static Ref<WebKitCSSMatrix> create(const TransformationMatrix& m)
>     {
>-        return adoptRef(new WebKitCSSMatrix(m));
>+        return adoptRef(*new WebKitCSSMatrix(m));
>     }
>-    static PassRefPtr<WebKitCSSMatrix> create(const String& s, ExceptionCode& ec)
>+    static Ref<WebKitCSSMatrix> create(const String& s, ExceptionCode& ec)
>     {
>-        return adoptRef(new WebKitCSSMatrix(s, ec));
>+        return adoptRef(*new WebKitCSSMatrix(s, ec));
>     }
> 
>     ~WebKitCSSMatrix();
>diff --git a/Source/WebCore/css/WebKitCSSRegionRule.h b/Source/WebCore/css/WebKitCSSRegionRule.h
>index 516bca3d507a9e7fe00e6b3bbb0f06d7ad0894ae..fb5d0285e4b8b19488bc58877c3e48487da19681 100644
>--- a/Source/WebCore/css/WebKitCSSRegionRule.h
>+++ b/Source/WebCore/css/WebKitCSSRegionRule.h
>@@ -41,7 +41,7 @@ class StyleRuleRegion;
> 
> class WebKitCSSRegionRule final : public CSSGroupingRule {
> public:
>-    static PassRefPtr<WebKitCSSRegionRule> create(StyleRuleRegion& rule, CSSStyleSheet* sheet) { return adoptRef(new WebKitCSSRegionRule(rule, sheet)); }
>+    static Ref<WebKitCSSRegionRule> create(StyleRuleRegion& rule, CSSStyleSheet* sheet) { return adoptRef(*new WebKitCSSRegionRule(rule, sheet)); }
> 
>     virtual CSSRule::Type type() const override { return WEBKIT_REGION_RULE; }
>     virtual String cssText() const override;
>diff --git a/Source/WebCore/css/WebKitCSSViewportRule.h b/Source/WebCore/css/WebKitCSSViewportRule.h
>index 5bf43473a97f89b652219264a56a4a7ed0bed521..4f053182d06463feceb56d7c7ec2ffe912d762fe 100644
>--- a/Source/WebCore/css/WebKitCSSViewportRule.h
>+++ b/Source/WebCore/css/WebKitCSSViewportRule.h
>@@ -43,9 +43,9 @@ class StyleRuleCSSStyleDeclaration;
> 
> class WebKitCSSViewportRule final : public CSSRule {
> public:
>-    static PassRefPtr<WebKitCSSViewportRule> create(StyleRuleViewport& viewportRule, CSSStyleSheet* sheet)
>+    static Ref<WebKitCSSViewportRule> create(StyleRuleViewport& viewportRule, CSSStyleSheet* sheet)
>     {
>-        return adoptRef(new WebKitCSSViewportRule(viewportRule, sheet));
>+        return adoptRef(*new WebKitCSSViewportRule(viewportRule, sheet));
>     }
>     virtual ~WebKitCSSViewportRule();
>

Actions: View | Formatted Diff | Diff

Attachments on bug 144905: 252962 | 253013 | 253015 | 253016 | 253019 | 253075 | 253090 | 253092 | 253822 | 253839 | 253843 | 253844 | 253845 | 253971 | 254104