Attachment 252646 Details for Bug 144753 – patch

[patch] patch

clean-backup.diff (text/plain), 6.17 KB, created by Saam Barati on 2015-05-07 16:29:33 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Saam Barati

Created: 2015-05-07 16:29:33 PDT

Size: 6.17 KB

patch

obsolete

>Index: Source/JavaScriptCore/ChangeLog
>===================================================================
>--- Source/JavaScriptCore/ChangeLog	(revision 183956)
>+++ Source/JavaScriptCore/ChangeLog	(working copy)
>@@ -1,3 +1,23 @@
>+2015-05-07  Saam Barati  <saambarati1@gmail.com>
>+
>+        exceptionFuzz tests should explicitly initialize the exceptionFuzz boolean in JavaScript code through a function in jsc.cpp
>+        https://bugs.webkit.org/show_bug.cgi?id=144753
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This allows the BytecodeGenerator to freely emit startup code that "may"
>+        throw exceptions without worrying that this startup code will trigger
>+        the exceptionFuzz exception. The exceptionFuzz counter will only begin
>+        ticking when the 'enableExceptionFuzz' function is explicitly called in 
>+        the exceptionFuzz tests.
>+
>+        * jsc.cpp:
>+        (GlobalObject::finishCreation):
>+        (functionEnableExceptionFuzz):
>+        * tests/exceptionFuzz/3d-cube.js:
>+        * tests/exceptionFuzz/date-format-xparb.js:
>+        * tests/exceptionFuzz/earley-boyer.js:
>+
> 2015-05-07  Yusuke Suzuki  <utatane.tea@gmail.com>
> 
>         FunctionCallBracketNode should store the base value to the temporary when subscript has assignment
>Index: Source/JavaScriptCore/jsc.cpp
>===================================================================
>--- Source/JavaScriptCore/jsc.cpp	(revision 183891)
>+++ Source/JavaScriptCore/jsc.cpp	(working copy)
>@@ -478,6 +478,7 @@ static EncodedJSValue JSC_HOST_CALL func
> static EncodedJSValue JSC_HOST_CALL functionReturnTypeFor(ExecState*);
> static EncodedJSValue JSC_HOST_CALL functionDumpBasicBlockExecutionRanges(ExecState*);
> static EncodedJSValue JSC_HOST_CALL functionHasBasicBlockExecuted(ExecState*);
>+static EncodedJSValue JSC_HOST_CALL functionEnableExceptionFuzz(ExecState*);
> 
> #if ENABLE(SAMPLING_FLAGS)
> static EncodedJSValue JSC_HOST_CALL functionSetSamplingFlags(ExecState*);
>@@ -635,6 +636,8 @@ protected:
> 
>         addFunction(vm, "dumpBasicBlockExecutionRanges", functionDumpBasicBlockExecutionRanges , 0);
>         addFunction(vm, "hasBasicBlockExecuted", functionHasBasicBlockExecuted, 2);
>+
>+        addFunction(vm, "enableExceptionFuzz", functionEnableExceptionFuzz, 0);
>         
>         JSArray* array = constructEmptyArray(globalExec(), 0);
>         for (size_t i = 0; i < arguments.size(); ++i)
>@@ -1129,6 +1132,12 @@ EncodedJSValue JSC_HOST_CALL functionHas
>     return JSValue::encode(jsBoolean(hasExecuted));
> }
> 
>+EncodedJSValue JSC_HOST_CALL functionEnableExceptionFuzz(ExecState*)
>+{
>+    Options::enableExceptionFuzz() = true;
>+    return JSValue::encode(jsUndefined());
>+}
>+
> // Use SEH for Release builds only to get rid of the crash report dialog
> // (luckily the same tests fail in Release and Debug builds so far). Need to
> // be in a separate main function because the jscmain function requires object
>Index: Source/JavaScriptCore/tests/exceptionFuzz/3d-cube.js
>===================================================================
>--- Source/JavaScriptCore/tests/exceptionFuzz/3d-cube.js	(revision 183891)
>+++ Source/JavaScriptCore/tests/exceptionFuzz/3d-cube.js	(working copy)
>@@ -4,6 +4,9 @@ try {
> // http://www.speich.net/computer/moztesting/3d.htm
> // Created by Simon Speich
> 
>+enableExceptionFuzz();
>+
>+
> var Q = new Array();
> var MTrans = new Array();  // transformation matrix
> var MQube = new Array();  // position information of qube
>Index: Source/JavaScriptCore/tests/exceptionFuzz/date-format-xparb.js
>===================================================================
>--- Source/JavaScriptCore/tests/exceptionFuzz/date-format-xparb.js	(revision 183891)
>+++ Source/JavaScriptCore/tests/exceptionFuzz/date-format-xparb.js	(working copy)
>@@ -13,6 +13,9 @@ try {
>  * details.
>  */
> 
>+enableExceptionFuzz();
>+
>+
> Date.parseFunctions = {count:0};
> Date.parseRegexes = [];
> Date.formatFunctions = {count:0};
>Index: Source/JavaScriptCore/tests/exceptionFuzz/earley-boyer.js
>===================================================================
>--- Source/JavaScriptCore/tests/exceptionFuzz/earley-boyer.js	(revision 183891)
>+++ Source/JavaScriptCore/tests/exceptionFuzz/earley-boyer.js	(working copy)
>@@ -39,6 +39,8 @@ function initRuntime() {
> }
> */
> 
>+enableExceptionFuzz();
>+
> 
> function sc_print_debug() {
>     sc_print.apply(null, arguments);
>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 183956)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,12 @@
>+2015-05-07  Saam Barati  <saambarati1@gmail.com>
>+
>+        exceptionFuzz tests should explicitly initialize the exceptionFuzz boolean in JavaScript code through a function in jsc.cpp
>+        https://bugs.webkit.org/show_bug.cgi?id=144753
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
>+
> 2015-05-07  Beth Dakin  <bdakin@apple.com>
> 
>         New force-related DOM events should fire in WK1 views
>Index: Tools/Scripts/jsc-stress-test-helpers/js-exception-fuzz
>===================================================================
>--- Tools/Scripts/jsc-stress-test-helpers/js-exception-fuzz	(revision 183891)
>+++ Tools/Scripts/jsc-stress-test-helpers/js-exception-fuzz	(working copy)
>@@ -71,7 +71,7 @@ if (shift @ARGV) {
>     die "Ignoring garbage arguments; only the first non-option argument is used as the command string.";
> }
> 
>-open (my $testInput, "$commandString --enableExceptionFuzz=true |") or fail("Cannot execute initial command when getting check count");
>+open (my $testInput, "$commandString |") or fail("Cannot execute initial command when getting check count");
> while (my $inputLine = <$testInput>) {
>     chomp($inputLine);
>     my $handled = 0;
>@@ -104,7 +104,7 @@ for (my $iteration = 0; $iteration < $re
>     if ($verbose) {
>         print "iteration($iteration) target($target): Running.\n";
>     }
>-    open ($testInput, "$commandString --enableExceptionFuzz=true --fireExceptionFuzzAt=$target |") or fail("Cannot execute command on iteration $iteration");
>+    open ($testInput, "$commandString --fireExceptionFuzzAt=$target |") or fail("Cannot execute command on iteration $iteration");
>     my $state = "waiting";
>     while (my $inputLine = <$testInput>) {
>         chomp($inputLine);

Actions: View | Formatted Diff | Diff

Attachments on bug 144753: 252646