Attachment 249395 Details for Bug 143046 – Patch

[patch] Patch

bug-143046-20150325020503.patch (text/plain), 1.32 KB, created by Zan Dobersek on 2015-03-25 02:02:25 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Zan Dobersek

Created: 2015-03-25 02:02:25 PDT

Size: 1.32 KB

patch

obsolete

>Index: Source/WebKit2/ChangeLog
>===================================================================
>--- Source/WebKit2/ChangeLog	(revision 181936)
>+++ Source/WebKit2/ChangeLog	(working copy)
>@@ -1,3 +1,13 @@
>+2015-03-25  Zan Dobersek  <zdobersek@igalia.com>
>+
>+        [WK2] WebUserMediaClient::pageDestroyed() virtual method should be marked as override
>+        https://bugs.webkit.org/show_bug.cgi?id=143046
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebProcess/WebCoreSupport/WebUserMediaClient.h: Mark the WebUserMediaClient::pageDestroyed()
>+        method, inherited from the WebCore::UserMediaClient, as an override.
>+
> 2015-03-24  Ryosuke Niwa  <rniwa@webkit.org>
> 
>         Inspector doesn't get focused when opened in dock mode
>Index: Source/WebKit2/WebProcess/WebCoreSupport/WebUserMediaClient.h
>===================================================================
>--- Source/WebKit2/WebProcess/WebCoreSupport/WebUserMediaClient.h	(revision 181936)
>+++ Source/WebKit2/WebProcess/WebCoreSupport/WebUserMediaClient.h	(working copy)
>@@ -33,7 +33,7 @@ public:
>     WebUserMediaClient(WebPage&);
> 
> private:
>-    virtual void pageDestroyed();
>+    virtual void pageDestroyed() override;
>     virtual void requestPermission(Ref<WebCore::UserMediaRequest>&&) override;
>     virtual void cancelRequest(WebCore::UserMediaRequest&) override;
>

Actions: View | Formatted Diff | Diff

Attachments on bug 143046: 249395