Attachment 242835 Details for Bug 137773 – Patch

[patch] Patch

137773.diff (text/plain), 3.36 KB, created by Alberto Garcia on 2014-12-08 11:41:15 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Alberto Garcia

Created: 2014-12-08 11:41:15 PST

Size: 3.36 KB

patch

obsolete

>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 50e9865..b2d082c 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,21 @@
>+2014-12-08  Alberto Garcia  <berto@igalia.com>
>+
>+        [Media][GTK][EFL] Reduce style updates (painting) in controls
>+        https://bugs.webkit.org/show_bug.cgi?id=137773
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Don't update media controls if they are not visible, and
>+        initialize slider to a zero value.
>+
>+        * Modules/mediacontrols/mediaControlsBase.js:
>+        (Controller.prototype.createControls):
>+        (Controller.prototype.handleDurationChange):
>+        (Controller.prototype.updateProgress):
>+        (Controller.prototype.updateTime):
>+        * Modules/mediacontrols/mediaControlsGtk.js:
>+        (ControllerGtk.prototype.updateTime):
>+
> 2014-12-08  Chris Fleizach  <cfleizach@apple.com>
> 
>         AX: iOS: VoiceOver gets hung on some websites consistently.
>diff --git a/Source/WebCore/Modules/mediacontrols/mediaControlsBase.js b/Source/WebCore/Modules/mediacontrols/mediaControlsBase.js
>index 1ad1798..8b2133b 100644
>--- a/Source/WebCore/Modules/mediacontrols/mediaControlsBase.js
>+++ b/Source/WebCore/Modules/mediacontrols/mediaControlsBase.js
>@@ -338,6 +338,7 @@ Controller.prototype = {
>         timeline.setAttribute('aria-label', this.UIString('Duration'));
>         timeline.style.backgroundImage = '-webkit-canvas(timeline-' + this.timelineID + ')';
>         timeline.type = 'range';
>+        timeline.value = 0;
>         this.listenFor(timeline, 'input', this.handleTimelineChange);
>         this.listenFor(timeline, 'mouseover', this.handleTimelineMouseOver);
>         this.listenFor(timeline, 'mouseout', this.handleTimelineMouseOut);
>@@ -573,8 +574,8 @@ Controller.prototype = {
>     handleDurationChange: function(event)
>     {
>         this.updateDuration();
>-        this.updateTime();
>-        this.updateProgress();
>+        this.updateTime(true);
>+        this.updateProgress(true);
>     },
> 
>     handlePlay: function(event)
>@@ -939,8 +940,11 @@ Controller.prototype = {
>         return gradient;
>     },
> 
>-    updateProgress: function()
>+    updateProgress: function(forceUpdate)
>     {
>+        if (!forceUpdate && this.controlsAreHidden())
>+            return;
>+
>         this.updateTimelineMetricsIfNeeded();
> 
>         var width = this.timelineWidth;
>@@ -1036,8 +1040,11 @@ Controller.prototype = {
>         this.setNeedsTimelineMetricsUpdate();
>     },
> 
>-    updateTime: function()
>+    updateTime: function(forceUpdate)
>     {
>+        if (!forceUpdate && this.controlsAreHidden())
>+            return;
>+
>         var currentTime = this.video.currentTime;
>         var timeRemaining = currentTime - this.video.duration;
>         this.controls.currentTime.innerText = this.formatTime(currentTime);
>diff --git a/Source/WebCore/Modules/mediacontrols/mediaControlsGtk.js b/Source/WebCore/Modules/mediacontrols/mediaControlsGtk.js
>index 5ab5ac2..128ff78 100644
>--- a/Source/WebCore/Modules/mediacontrols/mediaControlsGtk.js
>+++ b/Source/WebCore/Modules/mediacontrols/mediaControlsGtk.js
>@@ -72,8 +72,11 @@ ControllerGtk.prototype = {
>     {
>     },
> 
>-    updateTime: function()
>+    updateTime: function(forceUpdate)
>     {
>+        if (!forceUpdate && this.controlsAreHidden())
>+            return;
>+
>         var currentTime = this.video.currentTime;
>         var duration = this.video.duration;
>

Flags:

cgarcia: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 137773: 242835