WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
[patch]
ROLLOUT of r176218
bug-138827-20141118024351.patch (text/plain), 113.41 KB, created by
WebKit Commit Bot
on 2014-11-18 02:43:39 PST
(
hide
)
Description:
ROLLOUT of r176218
Filename:
MIME Type:
Creator:
WebKit Commit Bot
Created:
2014-11-18 02:43:39 PST
Size:
113.41 KB
patch
obsolete
>Subversion Revision: 176252 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index e4f04eecd9ca82525e72a2a4783b8ff169ab5b6e..85faeed2e31431873b14e6309d448630f23ea9d3 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,18 @@ >+2014-11-18 Commit Queue <commit-queue@webkit.org> >+ >+ Unreviewed, rolling out r176218. >+ https://bugs.webkit.org/show_bug.cgi?id=138827 >+ >+ seems to have caused regressions on the perf bots (Requested >+ by lajava on #webkit). >+ >+ Reverted changeset: >+ >+ "[CSS Grid Layout] Upgrade align-self and align-items parsing >+ to CSS 3" >+ https://bugs.webkit.org/show_bug.cgi?id=133359 >+ http://trac.webkit.org/changeset/176218 >+ > 2014-11-17 Benjamin Poulain <bpoulain@apple.com> > > Fix a small indentation mistake in SelectorCodeGenerator::generateNthFilterTest >diff --git a/Source/WebCore/css/CSSComputedStyleDeclaration.cpp b/Source/WebCore/css/CSSComputedStyleDeclaration.cpp >index 8ba8eca84100871fdc0d1f94553f673c52bf8f5a..1ad341a5220b3a00a62ecfa22494422c683e0872 100644 >--- a/Source/WebCore/css/CSSComputedStyleDeclaration.cpp >+++ b/Source/WebCore/css/CSSComputedStyleDeclaration.cpp >@@ -296,7 +296,7 @@ static const CSSPropertyID computedProperties[] = { > CSSPropertyFlexDirection, > CSSPropertyFlexWrap, > CSSPropertyJustifyContent, >- CSSPropertyJustifySelf, >+ CSSPropertyWebkitJustifySelf, > CSSPropertyWebkitFilter, > #if ENABLE(FILTERS_LEVEL_2) > CSSPropertyWebkitBackdropFilter, >@@ -1713,15 +1713,6 @@ static PassRef<CSSValue> shapePropertyValue(const RenderStyle* style, const Shap > } > #endif > >-static PassRefPtr<CSSValueList> valueForItemPositionWithOverflowAlignment(ItemPosition itemPosition, OverflowAlignment overflowAlignment) >-{ >- RefPtr<CSSValueList> result = CSSValueList::createSpaceSeparated(); >- result->append(cssValuePool().createValue(itemPosition)); >- if (itemPosition >= ItemPositionCenter && overflowAlignment != OverflowAlignmentDefault) >- result->append(cssValuePool().createValue(overflowAlignment)); >- return result.release(); >-} >- > PassRefPtr<CSSValue> ComputedStyleExtractor::propertyValue(CSSPropertyID propertyID, EUpdateLayout updateLayout) const > { > Node* styledNode = this->styledNode(); >@@ -2065,19 +2056,15 @@ PassRefPtr<CSSValue> ComputedStyleExtractor::propertyValue(CSSPropertyID propert > case CSSPropertyAlignContent: > return cssValuePool().createValue(style->alignContent()); > case CSSPropertyAlignItems: >- return valueForItemPositionWithOverflowAlignment(style->alignItems(), style->alignItemsOverflowAlignment()); >- case CSSPropertyAlignSelf: { >- ItemPosition alignSelf = style->alignSelf(); >- OverflowAlignment overflow = style->alignSelfOverflowAlignment(); >- if (alignSelf == ItemPositionAuto) { >+ return cssValuePool().createValue(style->alignItems()); >+ case CSSPropertyAlignSelf: >+ if (style->alignSelf() == AlignAuto) { > Node* parent = styledNode->parentNode(); >- if (parent && parent->computedStyle()) { >- alignSelf = parent->computedStyle()->alignItems(); >- overflow = parent->computedStyle()->alignItemsOverflowAlignment(); >- } >+ if (parent && parent->computedStyle()) >+ return cssValuePool().createValue(parent->computedStyle()->alignItems()); >+ return cssValuePool().createValue(AlignStretch); > } >- return valueForItemPositionWithOverflowAlignment(alignSelf, overflow); >- } >+ return cssValuePool().createValue(style->alignSelf()); > case CSSPropertyFlex: > return getCSSPropertyValuesForShorthandProperties(flexShorthand()); > case CSSPropertyFlexBasis: >@@ -2094,8 +2081,13 @@ PassRefPtr<CSSValue> ComputedStyleExtractor::propertyValue(CSSPropertyID propert > return cssValuePool().createValue(style->flexWrap()); > case CSSPropertyJustifyContent: > return cssValuePool().createValue(style->justifyContent()); >- case CSSPropertyJustifySelf: >- return valueForItemPositionWithOverflowAlignment(style->justifySelf(), style->justifySelfOverflowAlignment()); >+ case CSSPropertyWebkitJustifySelf: { >+ RefPtr<CSSValueList> result = CSSValueList::createSpaceSeparated(); >+ result->append(CSSPrimitiveValue::create(style->justifySelf())); >+ if (style->justifySelf() >= JustifySelfCenter && style->justifySelfOverflowAlignment() != JustifySelfOverflowAlignmentDefault) >+ result->append(CSSPrimitiveValue::create(style->justifySelfOverflowAlignment())); >+ return result.release(); >+ } > case CSSPropertyOrder: > return cssValuePool().createValue(style->order(), CSSPrimitiveValue::CSS_NUMBER); > case CSSPropertyFloat: >diff --git a/Source/WebCore/css/CSSParser.cpp b/Source/WebCore/css/CSSParser.cpp >index 813f5a324c02caa57e8d7742b14d7c75c3aa94ff..853d872fc91fc0f1b5f463fdfe1c501c5332bb25 100644 >--- a/Source/WebCore/css/CSSParser.cpp >+++ b/Source/WebCore/css/CSSParser.cpp >@@ -865,7 +865,6 @@ static inline bool isValidKeywordPropertyAndValue(CSSPropertyID propertyId, int > if (valueID == CSSValueFlexStart || valueID == CSSValueFlexEnd || valueID == CSSValueCenter || valueID == CSSValueSpaceBetween || valueID == CSSValueSpaceAround || valueID == CSSValueStretch) > return true; > break; >-#if !ENABLE(CSS_GRID_LAYOUT) > case CSSPropertyAlignItems: > // FIXME: Per CSS alignment, this property should accept the same arguments as 'justify-self' so we should share its parsing code. > if (valueID == CSSValueFlexStart || valueID == CSSValueFlexEnd || valueID == CSSValueCenter || valueID == CSSValueBaseline || valueID == CSSValueStretch) >@@ -876,7 +875,6 @@ static inline bool isValidKeywordPropertyAndValue(CSSPropertyID propertyId, int > if (valueID == CSSValueAuto || valueID == CSSValueFlexStart || valueID == CSSValueFlexEnd || valueID == CSSValueCenter || valueID == CSSValueBaseline || valueID == CSSValueStretch) > return true; > break; >-#endif > case CSSPropertyFlexDirection: > if (valueID == CSSValueRow || valueID == CSSValueRowReverse || valueID == CSSValueColumn || valueID == CSSValueColumnReverse) > return true; >@@ -890,12 +888,10 @@ static inline bool isValidKeywordPropertyAndValue(CSSPropertyID propertyId, int > if (valueID == CSSValueFlexStart || valueID == CSSValueFlexEnd || valueID == CSSValueCenter || valueID == CSSValueSpaceBetween || valueID == CSSValueSpaceAround) > return true; > break; >-#if !ENABLE(CSS_GRID_LAYOUT) >- case CSSPropertyJustifySelf: >+ case CSSPropertyWebkitJustifySelf: > if (valueID == CSSValueAuto || valueID == CSSValueFlexStart || valueID == CSSValueFlexEnd || valueID == CSSValueCenter || valueID == CSSValueBaseline || valueID == CSSValueStretch) > return true; > break; >-#endif > case CSSPropertyWebkitFontKerning: > if (valueID == CSSValueAuto || valueID == CSSValueNormal || valueID == CSSValueNone) > return true; >@@ -1110,10 +1106,8 @@ static inline bool isKeywordPropertyID(CSSPropertyID propertyId) > case CSSPropertyColumnFill: > case CSSPropertyColumnRuleStyle: > case CSSPropertyAlignContent: >-#if !ENABLE(CSS_GRID_LAYOUT) > case CSSPropertyAlignItems: > case CSSPropertyAlignSelf: >-#endif > case CSSPropertyFlexDirection: > case CSSPropertyFlexWrap: > case CSSPropertyJustifyContent: >@@ -2636,9 +2630,9 @@ bool CSSParser::parseValue(CSSPropertyID propId, bool important) > } > return false; > } >+ case CSSPropertyWebkitJustifySelf: >+ return parseJustifySelf(propId, important); > #if ENABLE(CSS_GRID_LAYOUT) >- case CSSPropertyJustifySelf: >- return parseItemPositionOverflowPosition(propId, important); > case CSSPropertyWebkitGridAutoColumns: > case CSSPropertyWebkitGridAutoRows: > parsedValue = parseGridTrackSize(*m_valueList); >@@ -2973,13 +2967,6 @@ bool CSSParser::parseValue(CSSPropertyID propId, bool important) > parsedValue = parseImageResolution(); > break; > #endif >-#if ENABLE(CSS_GRID_LAYOUT) >- case CSSPropertyAlignSelf: >- return parseItemPositionOverflowPosition(propId, important); >- >- case CSSPropertyAlignItems: >- return parseItemPositionOverflowPosition(propId, important); >-#endif > case CSSPropertyBorderBottomStyle: > case CSSPropertyBorderCollapse: > case CSSPropertyBorderLeftStyle: >@@ -3041,11 +3028,8 @@ bool CSSParser::parseValue(CSSPropertyID propId, bool important) > case CSSPropertyColumnFill: > case CSSPropertyColumnRuleStyle: > case CSSPropertyAlignContent: >-#if !ENABLE(CSS_GRID_LAYOUT) > case CSSPropertyAlignItems: > case CSSPropertyAlignSelf: >- case CSSPropertyJustifySelf: >-#endif > case CSSPropertyFlexDirection: > case CSSPropertyFlexWrap: > case CSSPropertyJustifyContent: >@@ -3156,11 +3140,6 @@ void CSSParser::addFillValue(RefPtr<CSSValue>& lval, PassRef<CSSValue> rval) > lval = WTF::move(list); > } > >-static inline bool isBaselinePositionKeyword(CSSValueID id) >-{ >- return id == CSSValueBaseline || id == CSSValueLastBaseline; >-} >- > static bool isItemPositionKeyword(CSSValueID id) > { > return id == CSSValueStart || id == CSSValueEnd || id == CSSValueCenter >@@ -3168,7 +3147,7 @@ static bool isItemPositionKeyword(CSSValueID id) > || id == CSSValueFlexEnd || id == CSSValueLeft || id == CSSValueRight; > } > >-bool CSSParser::parseItemPositionOverflowPosition(CSSPropertyID propId, bool important) >+bool CSSParser::parseJustifySelf(CSSPropertyID propId, bool important) > { > // auto | baseline | stretch | [<item-position> && <overflow-position>? ] > // <item-position> = center | start | end | self-start | self-end | flex-start | flex-end | left | right; >@@ -3176,7 +3155,7 @@ bool CSSParser::parseItemPositionOverflowPosition(CSSPropertyID propId, bool imp > > CSSParserValue* value = m_valueList->current(); > >- if (value->id == CSSValueAuto || value->id == CSSValueStretch || isBaselinePositionKeyword(value->id)) { >+ if (value->id == CSSValueAuto || value->id == CSSValueBaseline || value->id == CSSValueStretch) { > if (m_valueList->next()) > return false; > >diff --git a/Source/WebCore/css/CSSParser.h b/Source/WebCore/css/CSSParser.h >index a0c5be48e6ad3cdbf7541ba7f11fb483b82b8914..a2a450f6c69f74803de878e73cdf858f2c9841ab 100644 >--- a/Source/WebCore/css/CSSParser.h >+++ b/Source/WebCore/css/CSSParser.h >@@ -177,7 +177,7 @@ public: > > bool parseClipShape(CSSPropertyID, bool important); > >- bool parseItemPositionOverflowPosition(CSSPropertyID, bool important); >+ bool parseJustifySelf(CSSPropertyID, bool important); > > #if ENABLE(CSS_SHAPES) > PassRefPtr<CSSValue> parseShapeProperty(CSSPropertyID); >diff --git a/Source/WebCore/css/CSSPrimitiveValueMappings.h b/Source/WebCore/css/CSSPrimitiveValueMappings.h >index f2313ed58af181a3de74a1b6fb8e2c22d6978be7..8165e3b4b8e605c186f4b990cab18a2c412cb35f 100644 >--- a/Source/WebCore/css/CSSPrimitiveValueMappings.h >+++ b/Source/WebCore/css/CSSPrimitiveValueMappings.h >@@ -1428,6 +1428,57 @@ template<> inline CSSPrimitiveValue::operator EEmptyCell() const > return SHOW; > } > >+template<> inline CSSPrimitiveValue::CSSPrimitiveValue(EAlignItems e) >+ : CSSValue(PrimitiveClass) >+{ >+ m_primitiveUnitType = CSS_VALUE_ID; >+ switch (e) { >+ case AlignAuto: >+ m_value.valueID = CSSValueAuto; >+ break; >+ case AlignFlexStart: >+ m_value.valueID = CSSValueFlexStart; >+ break; >+ case AlignFlexEnd: >+ m_value.valueID = CSSValueFlexEnd; >+ break; >+ case AlignCenter: >+ m_value.valueID = CSSValueCenter; >+ break; >+ case AlignStretch: >+ m_value.valueID = CSSValueStretch; >+ break; >+ case AlignBaseline: >+ m_value.valueID = CSSValueBaseline; >+ break; >+ } >+} >+ >+template<> inline CSSPrimitiveValue::operator EAlignItems() const >+{ >+ ASSERT(isValueID()); >+ >+ switch (m_value.valueID) { >+ case CSSValueAuto: >+ return AlignAuto; >+ case CSSValueFlexStart: >+ return AlignFlexStart; >+ case CSSValueFlexEnd: >+ return AlignFlexEnd; >+ case CSSValueCenter: >+ return AlignCenter; >+ case CSSValueStretch: >+ return AlignStretch; >+ case CSSValueBaseline: >+ return AlignBaseline; >+ default: >+ break; >+ } >+ >+ ASSERT_NOT_REACHED(); >+ return AlignFlexStart; >+} >+ > template<> inline CSSPrimitiveValue::CSSPrimitiveValue(EJustifyContent e) > : CSSValue(PrimitiveClass) > { >@@ -5031,118 +5082,116 @@ template<> inline CSSPrimitiveValue::operator CSSBoxType() const > return BoxMissing; > } > >-template<> inline CSSPrimitiveValue::CSSPrimitiveValue(ItemPosition itemPosition) >+template<> inline CSSPrimitiveValue::CSSPrimitiveValue(EJustifySelf justifySelf) > : CSSValue(PrimitiveClass) > { > m_primitiveUnitType = CSS_VALUE_ID; >- switch (itemPosition) { >- case ItemPositionAuto: >+ switch (justifySelf) { >+ case JustifySelfAuto: > m_value.valueID = CSSValueAuto; > break; >- case ItemPositionStretch: >+ case JustifySelfStretch: > m_value.valueID = CSSValueStretch; > break; >- case ItemPositionBaseline: >+ case JustifySelfBaseline: > m_value.valueID = CSSValueBaseline; > break; >- case ItemPositionLastBaseline: >- m_value.valueID = CSSValueLastBaseline; >- break; >- case ItemPositionCenter: >+ case JustifySelfCenter: > m_value.valueID = CSSValueCenter; > break; >- case ItemPositionStart: >+ case JustifySelfStart: > m_value.valueID = CSSValueStart; > break; >- case ItemPositionEnd: >+ case JustifySelfEnd: > m_value.valueID = CSSValueEnd; > break; >- case ItemPositionSelfStart: >+ case JustifySelfSelfStart: > m_value.valueID = CSSValueSelfStart; > break; >- case ItemPositionSelfEnd: >+ case JustifySelfSelfEnd: > m_value.valueID = CSSValueSelfEnd; > break; >- case ItemPositionFlexStart: >+ case JustifySelfFlexStart: > m_value.valueID = CSSValueFlexStart; > break; >- case ItemPositionFlexEnd: >+ case JustifySelfFlexEnd: > m_value.valueID = CSSValueFlexEnd; > break; >- case ItemPositionLeft: >+ case JustifySelfLeft: > m_value.valueID = CSSValueLeft; > break; >- case ItemPositionRight: >+ case JustifySelfRight: > m_value.valueID = CSSValueRight; > break; >+ default: >+ m_value.valueID = CSSValueAuto; >+ break; > } > } > >-template<> inline CSSPrimitiveValue::operator ItemPosition() const >+template<> inline CSSPrimitiveValue::operator EJustifySelf() const > { > switch (m_value.valueID) { > case CSSValueAuto: >- return ItemPositionAuto; >+ return JustifySelfAuto; > case CSSValueStretch: >- return ItemPositionStretch; >+ return JustifySelfStretch; > case CSSValueBaseline: >- return ItemPositionBaseline; >- case CSSValueLastBaseline: >- return ItemPositionLastBaseline; >+ return JustifySelfBaseline; > case CSSValueCenter: >- return ItemPositionCenter; >+ return JustifySelfCenter; > case CSSValueStart: >- return ItemPositionStart; >+ return JustifySelfStart; > case CSSValueEnd: >- return ItemPositionEnd; >+ return JustifySelfEnd; > case CSSValueSelfStart: >- return ItemPositionSelfStart; >+ return JustifySelfSelfStart; > case CSSValueSelfEnd: >- return ItemPositionSelfEnd; >+ return JustifySelfSelfEnd; > case CSSValueFlexStart: >- return ItemPositionFlexStart; >+ return JustifySelfFlexStart; > case CSSValueFlexEnd: >- return ItemPositionFlexEnd; >+ return JustifySelfFlexEnd; > case CSSValueLeft: >- return ItemPositionLeft; >+ return JustifySelfLeft; > case CSSValueRight: >- return ItemPositionRight; >+ return JustifySelfRight; > default: > break; > } > ASSERT_NOT_REACHED(); >- return ItemPositionAuto; >+ return JustifySelfAuto; > } > >-template<> inline CSSPrimitiveValue::CSSPrimitiveValue(OverflowAlignment overflowAlignment) >+template<> inline CSSPrimitiveValue::CSSPrimitiveValue(EJustifySelfOverflowAlignment overflowAlignment) > : CSSValue(PrimitiveClass) > { > m_primitiveUnitType = CSS_VALUE_ID; > switch (overflowAlignment) { >- case OverflowAlignmentDefault: >+ case JustifySelfOverflowAlignmentDefault: > m_value.valueID = CSSValueDefault; > break; >- case OverflowAlignmentTrue: >+ case JustifySelfOverflowAlignmentTrue: > m_value.valueID = CSSValueTrue; > break; >- case OverflowAlignmentSafe: >+ case JustifySelfOverflowAlignmentSafe: > m_value.valueID = CSSValueSafe; > break; > } > } > >-template<> inline CSSPrimitiveValue::operator OverflowAlignment() const >+template<> inline CSSPrimitiveValue::operator EJustifySelfOverflowAlignment() const > { > switch (m_value.valueID) { > case CSSValueTrue: >- return OverflowAlignmentTrue; >+ return JustifySelfOverflowAlignmentTrue; > case CSSValueSafe: >- return OverflowAlignmentSafe; >+ return JustifySelfOverflowAlignmentSafe; > default: > break; > } > ASSERT_NOT_REACHED(); >- return OverflowAlignmentTrue; >+ return JustifySelfOverflowAlignmentTrue; > } > > >diff --git a/Source/WebCore/css/CSSPropertyNames.in b/Source/WebCore/css/CSSPropertyNames.in >index 9c53fc16133dafb993f58a0083a0a841ffc14e70..024c7efad0eae69a8c5a7fd8d410f467a9f4d81d 100644 >--- a/Source/WebCore/css/CSSPropertyNames.in >+++ b/Source/WebCore/css/CSSPropertyNames.in >@@ -364,9 +364,9 @@ isolation [NewStyleBuilder, TypeName=Isolation] > -webkit-filter > align-content [NewStyleBuilder] > -webkit-align-content = align-content >-align-items >+align-items [NewStyleBuilder] > -webkit-align-items = align-items >-align-self >+align-self [NewStyleBuilder, TypeName=EAlignItems] > -webkit-align-self = align-self > flex > -webkit-flex = flex >@@ -387,8 +387,7 @@ justify-content [NewStyleBuilder] > #if defined(ENABLE_FILTERS_LEVEL_2) && ENABLE_FILTERS_LEVEL_2 > -webkit-backdrop-filter > #endif >-justify-self >--webkit-justify-self = justify-self >+-webkit-justify-self > -webkit-font-size-delta > #if defined(ENABLE_CSS_GRID_LAYOUT) && ENABLE_CSS_GRID_LAYOUT > -webkit-grid >diff --git a/Source/WebCore/css/CSSValueKeywords.in b/Source/WebCore/css/CSSValueKeywords.in >index 1a6495e0b06e259fccbf1e624429fd222d552d6c..66dfd3853feecde81253f94705cd14fcd9562130 100644 >--- a/Source/WebCore/css/CSSValueKeywords.in >+++ b/Source/WebCore/css/CSSValueKeywords.in >@@ -540,7 +540,6 @@ space-around > // flex-end > // center > // baseline >-last-baseline > // stretch > > // CSS_PROP_JUSTIFY_CONTENT >@@ -554,7 +553,6 @@ last-baseline > // auto > // stretch > // baseline >-// last-baseline > // center > // start > // end >diff --git a/Source/WebCore/css/StyleResolver.cpp b/Source/WebCore/css/StyleResolver.cpp >index ac2fa7457a7b2a9b25bff60d25ddb68f4aa544d7..caa6fd1a623073184da47bf3ad8f782725892a30 100644 >--- a/Source/WebCore/css/StyleResolver.cpp >+++ b/Source/WebCore/css/StyleResolver.cpp >@@ -1113,6 +1113,26 @@ static bool doesNotInheritTextDecoration(const RenderStyle& style, Element* e) > || style.isFloating() || style.hasOutOfFlowPosition(); > } > >+static bool isDisplayFlexibleBox(EDisplay display) >+{ >+ return display == FLEX || display == INLINE_FLEX; >+} >+ >+static inline bool isDisplayGridBox(EDisplay display) >+{ >+#if ENABLE(CSS_GRID_LAYOUT) >+ return display == GRID || display == INLINE_GRID; >+#else >+ UNUSED_PARAM(display); >+ return false; >+#endif >+} >+ >+static bool isDisplayFlexibleOrGridBox(EDisplay display) >+{ >+ return isDisplayFlexibleBox(display) || isDisplayGridBox(display); >+} >+ > #if ENABLE(ACCELERATED_OVERFLOW_SCROLLING) > static bool isScrollableOverflow(EOverflow overflow) > { >@@ -1215,14 +1235,14 @@ void StyleResolver::adjustRenderStyle(RenderStyle& style, const RenderStyle& par > if (style.writingMode() != TopToBottomWritingMode && (style.display() == BOX || style.display() == INLINE_BOX)) > style.setWritingMode(TopToBottomWritingMode); > >- if (parentStyle.isDisplayFlexibleOrGridBox()) { >+ if (isDisplayFlexibleOrGridBox(parentStyle.display())) { > style.setFloating(NoFloat); > style.setDisplay(equivalentBlockDisplay(style.display(), style.isFloating(), !document().inQuirksMode())); > } > } > > // Make sure our z-index value is only applied if the object is positioned. >- if (style.position() == StaticPosition && !parentStyle.isDisplayFlexibleOrGridBox()) >+ if (style.position() == StaticPosition && !isDisplayFlexibleOrGridBox(parentStyle.display())) > style.setHasAutoZIndex(); > > // Auto z-index becomes 0 for the root element and transparent objects. This prevents >@@ -1351,30 +1371,6 @@ void StyleResolver::adjustRenderStyle(RenderStyle& style, const RenderStyle& par > if ((e->hasTagName(SVGNames::foreignObjectTag) || e->hasTagName(SVGNames::textTag)) && style.isDisplayInlineType()) > style.setDisplay(BLOCK); > } >- >- // CSS Box Alignment specification requires to resolve "auto" (inital/default) values. >- adjustStyleForAlignment(style); >-} >- >-void StyleResolver::adjustStyleForAlignment(RenderStyle& style) >-{ >- // The 'auto' keyword computes to: >- // - 'stretch' for flex containers and grid containers, >- // - 'start' for everything else. (to be resolved later, during the layout) >- if (style.alignItems() == ItemPositionAuto) { >- if (style.isDisplayFlexibleOrGridBox()) >- style.setAlignItems(ItemPositionStretch); >- else >- style.setAlignItems(ItemPositionStart); >- } >- >- // The 'auto' keyword computes to 'stretch' on absolutely-positioned elements, >- // and to the computed value of align-items on the parent (minus >- // any 'legacy' keywords) on all other boxes (to be resolved during the layout). >- if (style.alignSelf() == ItemPositionAuto) { >- if ((style.position() == AbsolutePosition)) >- style.setAlignSelf(ItemPositionStretch); >- } > } > > bool StyleResolver::checkRegionStyle(Element* regionElement) >@@ -2904,61 +2900,16 @@ void StyleResolver::applyProperty(CSSPropertyID id, CSSValue* value) > return; > } > #endif /* ENABLE(CSS_GRID_LAYOUT) */ >- case CSSPropertyAlignSelf: { >- if (isInherit) { >- state.style()->setAlignSelf(state.parentStyle()->alignSelf()); >- state.style()->setAlignSelfOverflowAlignment(state.parentStyle()->alignSelfOverflowAlignment()); >- return; >- } >- if (isInitial) { >- state.style()->setAlignSelf(RenderStyle::initialAlignSelf()); >- state.style()->setAlignSelfOverflowAlignment(RenderStyle::initialAlignSelfOverflowAlignment()); >- return; >- } >- if (Pair* pairValue = primitiveValue->getPairValue()) { >- state.style()->setAlignSelf(*pairValue->first()); >- state.style()->setAlignSelfOverflowAlignment(*pairValue->second()); >- } else >- state.style()->setAlignSelf(*primitiveValue); >- return; >- } > >- case CSSPropertyAlignItems: { >- if (isInherit) { >- state.style()->setAlignItems(state.parentStyle()->alignItems()); >- state.style()->setAlignItemsOverflowAlignment(state.parentStyle()->alignItemsOverflowAlignment()); >- return; >- } >- if (isInitial) { >- state.style()->setAlignItems(RenderStyle::initialAlignItems()); >- state.style()->setAlignItemsOverflowAlignment(RenderStyle::initialAlignItemsOverflowAlignment()); >- return; >- } >- if (Pair* pairValue = primitiveValue->getPairValue()) { >- state.style()->setAlignItems(*pairValue->first()); >- state.style()->setAlignItemsOverflowAlignment(*pairValue->second()); >- } else >- state.style()->setAlignItems(*primitiveValue); >- return; >- } >- case CSSPropertyJustifySelf: { >- if (isInherit) { >- state.style()->setJustifySelf(state.parentStyle()->justifySelf()); >- state.style()->setJustifySelfOverflowAlignment(state.parentStyle()->justifySelfOverflowAlignment()); >- return; >- } >- if (isInitial) { >- state.style()->setJustifySelf(RenderStyle::initialJustifySelf()); >- state.style()->setJustifySelfOverflowAlignment(RenderStyle::initialJustifySelfOverflowAlignment()); >- return; >- } >+ case CSSPropertyWebkitJustifySelf: >+ HANDLE_INHERIT_AND_INITIAL(justifySelf, JustifySelf); > if (Pair* pairValue = primitiveValue->getPairValue()) { > state.style()->setJustifySelf(*pairValue->first()); > state.style()->setJustifySelfOverflowAlignment(*pairValue->second()); > } else > state.style()->setJustifySelf(*primitiveValue); > return; >- } >+ > #if ENABLE(CSS_SCROLL_SNAP) > case CSSPropertyWebkitScrollSnapType: > HANDLE_INHERIT_AND_INITIAL(scrollSnapType, ScrollSnapType); >@@ -3177,6 +3128,8 @@ void StyleResolver::applyProperty(CSSPropertyID id, CSSValue* value) > case CSSPropertyWebkitCursorVisibility: > #endif > case CSSPropertyAlignContent: >+ case CSSPropertyAlignItems: >+ case CSSPropertyAlignSelf: > case CSSPropertyFlexBasis: > case CSSPropertyFlexDirection: > case CSSPropertyFlexGrow: >diff --git a/Source/WebCore/css/StyleResolver.h b/Source/WebCore/css/StyleResolver.h >index f6f02be641696fc46b43344c49e1014dba17c53e..b2ca96b344309fe10989e8b71aab023eda3a17f2 100644 >--- a/Source/WebCore/css/StyleResolver.h >+++ b/Source/WebCore/css/StyleResolver.h >@@ -296,7 +296,6 @@ private: > #endif > > void adjustRenderStyle(RenderStyle& styleToAdjust, const RenderStyle& parentStyle, Element*); >- void adjustStyleForAlignment(RenderStyle& styleToAdjust); > #if ENABLE(CSS_GRID_LAYOUT) > std::unique_ptr<GridPosition> adjustNamedGridItemPosition(const NamedGridAreaMap&, const NamedGridLinesMap&, const GridPosition&, GridPositionSide) const; > #endif >diff --git a/Source/WebCore/rendering/RenderBox.cpp b/Source/WebCore/rendering/RenderBox.cpp >index 1d651afe018cec4d60ad54695cf85a973d3f9ca4..e48eb9b675dc9d21759924c8805afa0b89b49837 100644 >--- a/Source/WebCore/rendering/RenderBox.cpp >+++ b/Source/WebCore/rendering/RenderBox.cpp >@@ -2418,7 +2418,7 @@ LayoutUnit RenderBox::computeLogicalWidthInRegionUsing(SizeType widthType, Lengt > static bool flexItemHasStretchAlignment(const RenderBox& flexitem) > { > auto parent = flexitem.parent(); >- return flexitem.style().alignSelf() == ItemPositionStretch || (flexitem.style().alignSelf() == ItemPositionAuto && parent->style().alignItems() == ItemPositionStretch); >+ return flexitem.style().alignSelf() == AlignStretch || (flexitem.style().alignSelf() == AlignAuto && parent->style().alignItems() == AlignStretch); > } > > static bool isStretchingColumnFlexItem(const RenderBox& flexitem) >diff --git a/Source/WebCore/rendering/RenderFlexibleBox.cpp b/Source/WebCore/rendering/RenderFlexibleBox.cpp >index 59d4b2258671e7a6b4d186cc9f3585089cfa55de..36ad71e97c042ce3b78152f4c38b69e0c6c53529 100644 >--- a/Source/WebCore/rendering/RenderFlexibleBox.cpp >+++ b/Source/WebCore/rendering/RenderFlexibleBox.cpp >@@ -32,7 +32,6 @@ > #include "RenderFlexibleBox.h" > > #include "LayoutRepainter.h" >-#include "NotImplemented.h" > #include "RenderLayer.h" > #include "RenderView.h" > #include <limits> >@@ -187,7 +186,7 @@ int RenderFlexibleBox::firstLineBaseline() const > for (RenderBox* child = m_orderIterator.first(); child; child = m_orderIterator.next()) { > if (child->isOutOfFlowPositioned()) > continue; >- if (alignmentForChild(*child) == ItemPositionBaseline && !hasAutoMarginsInCrossAxis(*child)) { >+ if (alignmentForChild(*child) == AlignBaseline && !hasAutoMarginsInCrossAxis(*child)) { > baselineChild = child; > break; > } >@@ -228,11 +227,11 @@ int RenderFlexibleBox::inlineBlockBaseline(LineDirectionMode direction) const > return synthesizedBaselineFromContentBox(*this, direction) + marginAscent; > } > >-static ItemPosition resolveAlignment(const RenderStyle* parentStyle, const RenderStyle* childStyle) >+static EAlignItems resolveAlignment(const RenderStyle* parentStyle, const RenderStyle* childStyle) > { >- ItemPosition align = childStyle->alignSelf(); >- if (align == ItemPositionAuto) >- align = (parentStyle->alignItems() == ItemPositionAuto) ? ItemPositionStretch : parentStyle->alignItems(); >+ EAlignItems align = childStyle->alignSelf(); >+ if (align == AlignAuto) >+ align = parentStyle->alignItems(); > return align; > } > >@@ -240,12 +239,12 @@ void RenderFlexibleBox::styleDidChange(StyleDifference diff, const RenderStyle* > { > RenderBlock::styleDidChange(diff, oldStyle); > >- if (oldStyle && oldStyle->alignItems() == ItemPositionStretch && diff == StyleDifferenceLayout) { >+ if (oldStyle && oldStyle->alignItems() == AlignStretch && diff == StyleDifferenceLayout) { > // Flex items that were previously stretching need to be relayed out so we can compute new available cross axis space. > // This is only necessary for stretching since other alignment values don't change the size of the box. > for (RenderBox* child = firstChildBox(); child; child = child->nextSiblingBox()) { >- ItemPosition previousAlignment = resolveAlignment(oldStyle, &child->style()); >- if (previousAlignment == ItemPositionStretch && previousAlignment != resolveAlignment(&style(), &child->style())) >+ EAlignItems previousAlignment = resolveAlignment(oldStyle, &child->style()); >+ if (previousAlignment == AlignStretch && previousAlignment != resolveAlignment(&style(), &child->style())) > child->setChildNeedsLayout(MarkOnlyThis); > } > } >@@ -1024,18 +1023,18 @@ void RenderFlexibleBox::prepareChildForPositionedLayout(RenderBox& child, Layout > } > } > >-ItemPosition RenderFlexibleBox::alignmentForChild(RenderBox& child) const >+EAlignItems RenderFlexibleBox::alignmentForChild(RenderBox& child) const > { >- ItemPosition align = resolveAlignment(&style(), &child.style()); >+ EAlignItems align = resolveAlignment(&style(), &child.style()); > >- if (align == ItemPositionBaseline && hasOrthogonalFlow(child)) >- align = ItemPositionFlexStart; >+ if (align == AlignBaseline && hasOrthogonalFlow(child)) >+ align = AlignFlexStart; > > if (style().flexWrap() == FlexWrapReverse) { >- if (align == ItemPositionFlexStart) >- align = ItemPositionFlexEnd; >- else if (align == ItemPositionFlexEnd) >- align = ItemPositionFlexStart; >+ if (align == AlignFlexStart) >+ align = AlignFlexEnd; >+ else if (align == AlignFlexEnd) >+ align = AlignFlexStart; > } > > return align; >@@ -1054,7 +1053,7 @@ size_t RenderFlexibleBox::numberOfInFlowPositionedChildren(const OrderedFlexItem > > bool RenderFlexibleBox::needToStretchChild(RenderBox& child) > { >- if (alignmentForChild(child) != ItemPositionStretch) >+ if (alignmentForChild(child) != AlignStretch) > return false; > > Length crossAxisLength = isHorizontalFlow() ? child.style().height() : child.style().width(); >@@ -1105,7 +1104,7 @@ void RenderFlexibleBox::layoutAndPlaceChildren(LayoutUnit& crossAxisOffset, cons > updateAutoMarginsInMainAxis(child, autoMarginOffset); > > LayoutUnit childCrossAxisMarginBoxExtent; >- if (alignmentForChild(child) == ItemPositionBaseline && !hasAutoMarginsInCrossAxis(child)) { >+ if (alignmentForChild(child) == AlignBaseline && !hasAutoMarginsInCrossAxis(child)) { > LayoutUnit ascent = marginBoxAscentForChild(child); > LayoutUnit descent = (crossAxisMarginExtentForChild(child) + crossAxisExtentForChild(child)) - ascent; > >@@ -1266,32 +1265,25 @@ void RenderFlexibleBox::alignChildren(const Vector<LineContext>& lineContexts) > continue; > > switch (alignmentForChild(*child)) { >- case ItemPositionAuto: >+ case AlignAuto: > ASSERT_NOT_REACHED(); > break; >- case ItemPositionStart: >- // FIXME: https://webkit.org/b/135460 - The extended grammar is not supported >- // yet for FlexibleBox. >- // Defaulting to Stretch for now, as it what most of FlexBox based renders >- // expect as default. >- notImplemented(); >- FALLTHROUGH; >- case ItemPositionStretch: { >+ case AlignStretch: { > applyStretchAlignmentToChild(*child, lineCrossAxisExtent); > // Since wrap-reverse flips cross start and cross end, strech children should be aligned with the cross end. > if (style().flexWrap() == FlexWrapReverse) > adjustAlignmentForChild(*child, availableAlignmentSpaceForChild(lineCrossAxisExtent, *child)); > break; > } >- case ItemPositionFlexStart: >+ case AlignFlexStart: > break; >- case ItemPositionFlexEnd: >+ case AlignFlexEnd: > adjustAlignmentForChild(*child, availableAlignmentSpaceForChild(lineCrossAxisExtent, *child)); > break; >- case ItemPositionCenter: >+ case AlignCenter: > adjustAlignmentForChild(*child, availableAlignmentSpaceForChild(lineCrossAxisExtent, *child) / 2); > break; >- case ItemPositionBaseline: { >+ case AlignBaseline: { > // FIXME: If we get here in columns, we want the use the descent, except we currently can't get the ascent/descent of orthogonal children. > // https://bugs.webkit.org/show_bug.cgi?id=98076 > LayoutUnit ascent = marginBoxAscentForChild(*child); >@@ -1302,19 +1294,6 @@ void RenderFlexibleBox::alignChildren(const Vector<LineContext>& lineContexts) > minMarginAfterBaseline = std::min(minMarginAfterBaseline, availableAlignmentSpaceForChild(lineCrossAxisExtent, *child) - startOffset); > break; > } >- case ItemPositionLastBaseline: >- case ItemPositionSelfStart: >- case ItemPositionSelfEnd: >- case ItemPositionEnd: >- case ItemPositionLeft: >- case ItemPositionRight: >- // FIXME: https://webkit.org/b/135460 - The extended grammar is not supported >- // yet for FlexibleBox. >- notImplemented(); >- FALLTHROUGH; >- default: >- ASSERT_NOT_REACHED(); >- break; > } > } > minMarginAfterBaselines.append(minMarginAfterBaseline); >@@ -1330,7 +1309,7 @@ void RenderFlexibleBox::alignChildren(const Vector<LineContext>& lineContexts) > LayoutUnit minMarginAfterBaseline = minMarginAfterBaselines[lineNumber]; > for (size_t childNumber = 0; childNumber < lineContexts[lineNumber].numberOfChildren; ++childNumber, child = m_orderIterator.next()) { > ASSERT(child); >- if (alignmentForChild(*child) == ItemPositionBaseline && !hasAutoMarginsInCrossAxis(*child) && minMarginAfterBaseline) >+ if (alignmentForChild(*child) == AlignBaseline && !hasAutoMarginsInCrossAxis(*child) && minMarginAfterBaseline) > adjustAlignmentForChild(*child, minMarginAfterBaseline); > } > } >diff --git a/Source/WebCore/rendering/RenderFlexibleBox.h b/Source/WebCore/rendering/RenderFlexibleBox.h >index 3bbb6fe8079608cd442d526d640e798679f13365..2b6efac6181e6e88ee1a3eb1f61bb9cf2f8b0699 100644 >--- a/Source/WebCore/rendering/RenderFlexibleBox.h >+++ b/Source/WebCore/rendering/RenderFlexibleBox.h >@@ -118,7 +118,7 @@ private: > // FIXME: Supporting layout deltas. > void setFlowAwareLocationForChild(RenderBox& child, const LayoutPoint&); > void adjustAlignmentForChild(RenderBox& child, LayoutUnit); >- ItemPosition alignmentForChild(RenderBox& child) const; >+ EAlignItems alignmentForChild(RenderBox& child) const; > LayoutUnit mainAxisBorderAndPaddingExtentForChild(RenderBox& child) const; > LayoutUnit mainAxisScrollbarExtentForChild(RenderBox& child) const; > LayoutUnit preferredMainAxisContentExtentForChild(RenderBox& child, bool hasInfiniteLineLength); >diff --git a/Source/WebCore/rendering/RenderFullScreen.cpp b/Source/WebCore/rendering/RenderFullScreen.cpp >index 4f08d74b6a31de57eaece26c729bbad5fec842d9..e115f7fde31ec11a053a710dda89ca96af7ebfbb 100644 >--- a/Source/WebCore/rendering/RenderFullScreen.cpp >+++ b/Source/WebCore/rendering/RenderFullScreen.cpp >@@ -90,7 +90,7 @@ static PassRef<RenderStyle> createFullScreenStyle() > > fullscreenStyle.get().setDisplay(FLEX); > fullscreenStyle.get().setJustifyContent(JustifyCenter); >- fullscreenStyle.get().setAlignItems(ItemPositionCenter); >+ fullscreenStyle.get().setAlignItems(AlignCenter); > fullscreenStyle.get().setFlexDirection(FlowColumn); > > fullscreenStyle.get().setPosition(FixedPosition); >diff --git a/Source/WebCore/rendering/RenderMenuList.cpp b/Source/WebCore/rendering/RenderMenuList.cpp >index 62c4e1103cdf4ca5d4a832897af70c7d266380c9..44c8d2b3af9f57c1fa9c0d973c11f51eaf9fc1e2 100644 >--- a/Source/WebCore/rendering/RenderMenuList.cpp >+++ b/Source/WebCore/rendering/RenderMenuList.cpp >@@ -119,10 +119,10 @@ void RenderMenuList::adjustInnerStyle() > // Use margin:auto instead of align-items:center to get safe centering, i.e. > // when the content overflows, treat it the same as align-items: flex-start. > // But we only do that for the cases where html.css would otherwise use center. >- if (style().alignItems() == ItemPositionCenter) { >+ if (style().alignItems() == AlignCenter) { > innerStyle.setMarginTop(Length()); > innerStyle.setMarginBottom(Length()); >- innerStyle.setAlignSelf(ItemPositionFlexStart); >+ innerStyle.setAlignSelf(AlignFlexStart); > } > > innerStyle.setPaddingLeft(Length(theme().popupInternalPaddingLeft(style()), Fixed)); >diff --git a/Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp b/Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp >index 900a2bbc5c7b37b44104c1cf34cb113ccaaa2f42..ed209ad1a68e0647df54988e6307fd08125a2b99 100644 >--- a/Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp >+++ b/Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp >@@ -233,7 +233,7 @@ void RenderMathMLRoot::updateStyle() > auto base = baseWrapper(); > auto baseStyle = RenderStyle::createAnonymousStyleWithDisplay(&style(), FLEX); > baseStyle.get().setMarginTop(Length(0, Fixed)); // This will be updated in RenderMathMLRoot::layout(). >- baseStyle.get().setAlignItems(ItemPositionBaseline); >+ baseStyle.get().setAlignItems(AlignBaseline); > base->setStyle(WTF::move(baseStyle)); > base->setNeedsLayoutAndPrefWidthsRecalc(); > >@@ -244,7 +244,7 @@ void RenderMathMLRoot::updateStyle() > indexStyle.get().setMarginTop(Length(0, Fixed)); // This will be updated in RenderMathMLRoot::layout(). > indexStyle.get().setMarginStart(Length(kernBeforeDegree, Fixed)); > indexStyle.get().setMarginEnd(Length(kernAfterDegree, Fixed)); >- indexStyle.get().setAlignItems(ItemPositionBaseline); >+ indexStyle.get().setAlignItems(AlignBaseline); > index->setStyle(WTF::move(indexStyle)); > index->setNeedsLayoutAndPrefWidthsRecalc(); > } >diff --git a/Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp b/Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp >index 4abdfb892bc5d726dd78b04fa47b19521509ff2d..74c99e17d56864ac8720121ec8a55ed5a26925e8 100644 >--- a/Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp >+++ b/Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp >@@ -101,7 +101,7 @@ void RenderMathMLScripts::fixAnonymousStyleForSubSupPair(RenderObject* subSupPai > // The MathML specification does not specify vertical alignment of scripts. > // Let's right align prescripts and left align postscripts. > // See http://lists.w3.org/Archives/Public/www-math/2012Aug/0006.html >- scriptsStyle.setAlignItems(isPostScript ? ItemPositionFlexStart : ItemPositionFlexEnd); >+ scriptsStyle.setAlignItems(isPostScript ? AlignFlexStart : AlignFlexEnd); > > // We set the order property so that the prescripts are drawn before the base. > scriptsStyle.setOrder(isPostScript ? 0 : -1); >@@ -115,7 +115,7 @@ void RenderMathMLScripts::fixAnonymousStyles() > { > // We set the base wrapper's style so that baseHeight in layout() will be an unstretched height. > ASSERT(m_baseWrapper && m_baseWrapper->style().hasOneRef()); >- m_baseWrapper->style().setAlignSelf(ItemPositionFlexStart); >+ m_baseWrapper->style().setAlignSelf(AlignFlexStart); > > // This sets the style for postscript pairs. > RenderObject* subSupPair = m_baseWrapper; >@@ -135,7 +135,7 @@ void RenderMathMLScripts::fixAnonymousStyles() > RenderStyle& scriptsStyle = subSupPair->style(); > scriptsStyle.setFlexDirection(FlowRow); > scriptsStyle.setJustifyContent(JustifyFlexStart); >- scriptsStyle.setAlignItems(ItemPositionCenter); >+ scriptsStyle.setAlignItems(AlignCenter); > scriptsStyle.setOrder(0); > scriptsStyle.setFontSize(style().fontSize()); > } >diff --git a/Source/WebCore/rendering/style/RenderStyle.h b/Source/WebCore/rendering/style/RenderStyle.h >index 9c99c0802e0f8a5876d6cc8ecd9e0ae6566dc316..dbbda1fd8604b2d3123ea9a5b1b676066a9c35e0 100644 >--- a/Source/WebCore/rendering/style/RenderStyle.h >+++ b/Source/WebCore/rendering/style/RenderStyle.h >@@ -903,17 +903,15 @@ public: > float flexShrink() const { return rareNonInheritedData->m_flexibleBox->m_flexShrink; } > const Length& flexBasis() const { return rareNonInheritedData->m_flexibleBox->m_flexBasis; } > EAlignContent alignContent() const { return static_cast<EAlignContent>(rareNonInheritedData->m_alignContent); } >- ItemPosition alignItems() const { return static_cast<ItemPosition>(rareNonInheritedData->m_alignItems); } >- OverflowAlignment alignItemsOverflowAlignment() const { return static_cast<OverflowAlignment>(rareNonInheritedData->m_alignItemsOverflowAlignment); } >- ItemPosition alignSelf() const { return static_cast<ItemPosition>(rareNonInheritedData->m_alignSelf); } >- OverflowAlignment alignSelfOverflowAlignment() const { return static_cast<OverflowAlignment>(rareNonInheritedData->m_alignSelfOverflowAlignment); } >+ EAlignItems alignItems() const { return static_cast<EAlignItems>(rareNonInheritedData->m_alignItems); } >+ EAlignItems alignSelf() const { return static_cast<EAlignItems>(rareNonInheritedData->m_alignSelf); } > EFlexDirection flexDirection() const { return static_cast<EFlexDirection>(rareNonInheritedData->m_flexibleBox->m_flexDirection); } > bool isColumnFlexDirection() const { return flexDirection() == FlowColumn || flexDirection() == FlowColumnReverse; } > bool isReverseFlexDirection() const { return flexDirection() == FlowRowReverse || flexDirection() == FlowColumnReverse; } > EFlexWrap flexWrap() const { return static_cast<EFlexWrap>(rareNonInheritedData->m_flexibleBox->m_flexWrap); } > EJustifyContent justifyContent() const { return static_cast<EJustifyContent>(rareNonInheritedData->m_justifyContent); } >- ItemPosition justifySelf() const { return static_cast<ItemPosition>(rareNonInheritedData->m_justifySelf); } >- OverflowAlignment justifySelfOverflowAlignment() const { return static_cast<OverflowAlignment>(rareNonInheritedData->m_justifySelfOverflowAlignment); } >+ EJustifySelf justifySelf() const { return static_cast<EJustifySelf>(rareNonInheritedData->m_justifySelf); } >+ EJustifySelfOverflowAlignment justifySelfOverflowAlignment() const { return static_cast<EJustifySelfOverflowAlignment>(rareNonInheritedData->m_justifySelfOverflowAlignment); } > > #if ENABLE(CSS_GRID_LAYOUT) > const Vector<GridTrackSize>& gridColumns() const { return rareNonInheritedData->m_grid->m_gridColumns; } >@@ -1477,15 +1475,13 @@ public: > void setFlexBasis(Length length) { SET_VAR(rareNonInheritedData.access()->m_flexibleBox, m_flexBasis, WTF::move(length)); } > void setOrder(int o) { SET_VAR(rareNonInheritedData, m_order, o); } > void setAlignContent(EAlignContent p) { SET_VAR(rareNonInheritedData, m_alignContent, p); } >- void setAlignItems(ItemPosition a) { SET_VAR(rareNonInheritedData, m_alignItems, a); } >- void setAlignItemsOverflowAlignment(OverflowAlignment overflowAlignment) { SET_VAR(rareNonInheritedData, m_alignItemsOverflowAlignment, overflowAlignment); } >- void setAlignSelf(ItemPosition a) { SET_VAR(rareNonInheritedData, m_alignSelf, a); } >- void setAlignSelfOverflowAlignment(OverflowAlignment overflowAlignment) { SET_VAR(rareNonInheritedData, m_alignSelfOverflowAlignment, overflowAlignment); } >+ void setAlignItems(EAlignItems a) { SET_VAR(rareNonInheritedData, m_alignItems, a); } >+ void setAlignSelf(EAlignItems a) { SET_VAR(rareNonInheritedData, m_alignSelf, a); } > void setFlexDirection(EFlexDirection direction) { SET_VAR(rareNonInheritedData.access()->m_flexibleBox, m_flexDirection, direction); } > void setFlexWrap(EFlexWrap w) { SET_VAR(rareNonInheritedData.access()->m_flexibleBox, m_flexWrap, w); } > void setJustifyContent(EJustifyContent p) { SET_VAR(rareNonInheritedData, m_justifyContent, p); } >- void setJustifySelf(ItemPosition p) { SET_VAR(rareNonInheritedData, m_justifySelf, p); } >- void setJustifySelfOverflowAlignment(OverflowAlignment overflowAlignment) { SET_VAR(rareNonInheritedData, m_justifySelfOverflowAlignment, overflowAlignment); } >+ void setJustifySelf(EJustifySelf p) { SET_VAR(rareNonInheritedData, m_justifySelf, p); } >+ void setJustifySelfOverflowAlignment(EJustifySelfOverflowAlignment overflowAlignment) { SET_VAR(rareNonInheritedData, m_justifySelfOverflowAlignment, overflowAlignment); } > #if ENABLE(CSS_GRID_LAYOUT) > void setGridAutoColumns(const GridTrackSize& length) { SET_VAR(rareNonInheritedData.access()->m_grid, m_gridAutoColumns, length); } > void setGridAutoRows(const GridTrackSize& length) { SET_VAR(rareNonInheritedData.access()->m_grid, m_gridAutoRows, length); } >@@ -1764,7 +1760,6 @@ public: > bool isDisplayReplacedType() const { return isDisplayReplacedType(display()); } > bool isDisplayInlineType() const { return isDisplayInlineType(display()); } > bool isOriginalDisplayInlineType() const { return isDisplayInlineType(originalDisplay()); } >- bool isDisplayFlexibleOrGridBox() const { return isDisplayFlexibleOrGridBox(display()); } > bool isDisplayRegionType() const > { > return display() == BLOCK || display() == INLINE_BLOCK >@@ -1888,15 +1883,13 @@ public: > static Length initialFlexBasis() { return Length(Auto); } > static int initialOrder() { return 0; } > static EAlignContent initialAlignContent() { return AlignContentStretch; } >- static ItemPosition initialAlignItems() { return ItemPositionAuto; } >- static OverflowAlignment initialAlignItemsOverflowAlignment() { return OverflowAlignmentDefault; } >- static ItemPosition initialAlignSelf() { return ItemPositionAuto; } >- static OverflowAlignment initialAlignSelfOverflowAlignment() { return OverflowAlignmentDefault; } >+ static EAlignItems initialAlignItems() { return AlignStretch; } >+ static EAlignItems initialAlignSelf() { return AlignAuto; } > static EFlexDirection initialFlexDirection() { return FlowRow; } > static EFlexWrap initialFlexWrap() { return FlexNoWrap; } > static EJustifyContent initialJustifyContent() { return JustifyFlexStart; } >- static ItemPosition initialJustifySelf() { return ItemPositionAuto; } >- static OverflowAlignment initialJustifySelfOverflowAlignment() { return OverflowAlignmentDefault; } >+ static EJustifySelf initialJustifySelf() { return JustifySelfAuto; } >+ static EJustifySelfOverflowAlignment initialJustifySelfOverflowAlignment() { return JustifySelfOverflowAlignmentDefault; } > static int initialMarqueeLoopCount() { return -1; } > static int initialMarqueeSpeed() { return 85; } > static Length initialMarqueeIncrement() { return Length(6, Fixed); } >@@ -2082,26 +2075,6 @@ private: > return display == INLINE || isDisplayReplacedType(display); > } > >- bool isDisplayFlexibleBox(EDisplay display) const >- { >- return display == FLEX || display == INLINE_FLEX; >- } >- >- bool isDisplayGridBox(EDisplay display) const >- { >-#if ENABLE(CSS_GRID_LAYOUT) >- return display == GRID || display == INLINE_GRID; >-#else >- UNUSED_PARAM(display); >- return false; >-#endif >- } >- >- bool isDisplayFlexibleOrGridBox(EDisplay display) const >- { >- return isDisplayFlexibleBox(display) || isDisplayGridBox(display); >- } >- > // Color accessors are all private to make sure callers use visitedDependentColor instead to access them. > Color invalidColor() const { static Color invalid; return invalid; } > Color borderLeftColor() const { return surround->border.left().color(); } >diff --git a/Source/WebCore/rendering/style/RenderStyleConstants.h b/Source/WebCore/rendering/style/RenderStyleConstants.h >index 628d6f4b420d3ff6f634288a4ba597b2319efa06..582f9a9c65f691ab5ca1600e8c55092981008953 100644 >--- a/Source/WebCore/rendering/style/RenderStyleConstants.h >+++ b/Source/WebCore/rendering/style/RenderStyleConstants.h >@@ -244,11 +244,12 @@ enum EBoxDirection { BNORMAL, BREVERSE }; > // CSS3 Flexbox Properties > > enum EAlignContent { AlignContentFlexStart, AlignContentFlexEnd, AlignContentCenter, AlignContentSpaceBetween, AlignContentSpaceAround, AlignContentStretch }; >+enum EAlignItems { AlignAuto, AlignFlexStart, AlignFlexEnd, AlignCenter, AlignStretch, AlignBaseline }; > enum EFlexDirection { FlowRow, FlowRowReverse, FlowColumn, FlowColumnReverse }; > enum EFlexWrap { FlexNoWrap, FlexWrap, FlexWrapReverse }; > enum EJustifyContent { JustifyFlexStart, JustifyFlexEnd, JustifyCenter, JustifySpaceBetween, JustifySpaceAround }; >-enum ItemPosition {ItemPositionAuto, ItemPositionStretch, ItemPositionBaseline, ItemPositionLastBaseline, ItemPositionCenter, ItemPositionStart, ItemPositionEnd, ItemPositionSelfStart, ItemPositionSelfEnd, ItemPositionFlexStart, ItemPositionFlexEnd, ItemPositionLeft, ItemPositionRight}; >-enum OverflowAlignment {OverflowAlignmentDefault, OverflowAlignmentTrue, OverflowAlignmentSafe}; >+enum EJustifySelf {JustifySelfAuto, JustifySelfStretch, JustifySelfBaseline, JustifySelfCenter, JustifySelfStart, JustifySelfEnd, JustifySelfSelfStart, JustifySelfSelfEnd, JustifySelfFlexStart, JustifySelfFlexEnd, JustifySelfLeft, JustifySelfRight}; >+enum EJustifySelfOverflowAlignment {JustifySelfOverflowAlignmentDefault, JustifySelfOverflowAlignmentTrue, JustifySelfOverflowAlignmentSafe}; > > > enum ETextSecurity { >diff --git a/Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp b/Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp >index ef6740c7da7efce76131562af99bcdb9baebbe59..c524a0aeac9c8a34af82a5241c180b9f6bf373a7 100644 >--- a/Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp >+++ b/Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp >@@ -83,9 +83,7 @@ StyleRareNonInheritedData::StyleRareNonInheritedData() > , m_backfaceVisibility(RenderStyle::initialBackfaceVisibility()) > , m_alignContent(RenderStyle::initialAlignContent()) > , m_alignItems(RenderStyle::initialAlignItems()) >- , m_alignItemsOverflowAlignment(RenderStyle::initialAlignItemsOverflowAlignment()) > , m_alignSelf(RenderStyle::initialAlignSelf()) >- , m_alignSelfOverflowAlignment(RenderStyle::initialAlignSelfOverflowAlignment()) > , m_justifyContent(RenderStyle::initialJustifyContent()) > , m_justifySelf(RenderStyle::initialJustifySelf()) > , m_justifySelfOverflowAlignment(RenderStyle::initialJustifySelfOverflowAlignment()) >@@ -172,9 +170,7 @@ inline StyleRareNonInheritedData::StyleRareNonInheritedData(const StyleRareNonIn > , m_backfaceVisibility(o.m_backfaceVisibility) > , m_alignContent(o.m_alignContent) > , m_alignItems(o.m_alignItems) >- , m_alignItemsOverflowAlignment(o.m_alignItemsOverflowAlignment) > , m_alignSelf(o.m_alignSelf) >- , m_alignSelfOverflowAlignment(o.m_alignSelfOverflowAlignment) > , m_justifyContent(o.m_justifyContent) > , m_justifySelf(o.m_justifySelf) > , m_justifySelfOverflowAlignment(o.m_justifySelfOverflowAlignment) >@@ -269,9 +265,7 @@ bool StyleRareNonInheritedData::operator==(const StyleRareNonInheritedData& o) c > && m_backfaceVisibility == o.m_backfaceVisibility > && m_alignContent == o.m_alignContent > && m_alignItems == o.m_alignItems >- && m_alignItemsOverflowAlignment == o.m_alignItemsOverflowAlignment > && m_alignSelf == o.m_alignSelf >- && m_alignSelfOverflowAlignment == o.m_alignSelfOverflowAlignment > && m_justifyContent == o.m_justifyContent > && userDrag == o.userDrag > && textOverflow == o.textOverflow >diff --git a/Source/WebCore/rendering/style/StyleRareNonInheritedData.h b/Source/WebCore/rendering/style/StyleRareNonInheritedData.h >index b91c968a2facea69bfbf9e5f09594994ea2d6257..df0beb6d96c1e97ff5274795a51e7ef354afbeb9 100644 >--- a/Source/WebCore/rendering/style/StyleRareNonInheritedData.h >+++ b/Source/WebCore/rendering/style/StyleRareNonInheritedData.h >@@ -188,14 +188,12 @@ public: > unsigned m_backfaceVisibility : 1; // EBackfaceVisibility > > unsigned m_alignContent : 3; // EAlignContent >- unsigned m_alignItems : 4; // ItemPosition >- unsigned m_alignItemsOverflowAlignment : 2; // OverflowAlignment >- unsigned m_alignSelf : 4; // ItemPosition >- unsigned m_alignSelfOverflowAlignment : 2; // OverflowAlignment >+ unsigned m_alignItems : 3; // EAlignItems >+ unsigned m_alignSelf : 3; // EAlignItems > unsigned m_justifyContent : 3; // EJustifyContent > >- unsigned m_justifySelf : 4; // ItemPosition >- unsigned m_justifySelfOverflowAlignment : 2; // OverflowAlignment >+ unsigned m_justifySelf : 4; // EJustifySelf >+ unsigned m_justifySelfOverflowAlignment : 2; // EJustifySelfOverflowAlignment > > unsigned userDrag : 2; // EUserDrag > unsigned textOverflow : 1; // Whether or not lines that spill out should be truncated with "..." >diff --git a/Source/WebCore/style/StyleResolveTree.cpp b/Source/WebCore/style/StyleResolveTree.cpp >index d43ffbc5e3cd61053ead986fb9c200066b886287..446ee51bff751413c5f25ba8017bdcaf1aec25d6 100644 >--- a/Source/WebCore/style/StyleResolveTree.cpp >+++ b/Source/WebCore/style/StyleResolveTree.cpp >@@ -121,8 +121,6 @@ Change determineChange(const RenderStyle& s1, const RenderStyle& s2) > // a separate render region object. > if (s1.hasFlowFrom() && (s1.specifiesColumns() != s2.specifiesColumns())) > return Detach; >- if (s1.alignItems() != s2.alignItems()) >- return Detach; > > if (s1 != s2) { > if (s1.inheritedNotEqual(&s2)) >diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog >index e890f82840c548fb2b94cbb7ef57587c16957468..a016d8120cd314e620f55a6b7803d34c0f31ac27 100644 >--- a/LayoutTests/ChangeLog >+++ b/LayoutTests/ChangeLog >@@ -1,3 +1,18 @@ >+2014-11-18 Commit Queue <commit-queue@webkit.org> >+ >+ Unreviewed, rolling out r176218. >+ https://bugs.webkit.org/show_bug.cgi?id=138827 >+ >+ seems to have caused regressions on the perf bots (Requested >+ by lajava on #webkit). >+ >+ Reverted changeset: >+ >+ "[CSS Grid Layout] Upgrade align-self and align-items parsing >+ to CSS 3" >+ https://bugs.webkit.org/show_bug.cgi?id=133359 >+ http://trac.webkit.org/changeset/176218 >+ > 2014-11-17 Sukolsak Sakshuwong <sukolsak@gmail.com> > > Add parsing for :role() >diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations >index f7254a0daa6487171796f0a0cf20ea407cd26e53..dcbe18bc43b6c57361f2e6724a865b24ff6873f8 100644 >--- a/LayoutTests/TestExpectations >+++ b/LayoutTests/TestExpectations >@@ -67,10 +67,6 @@ webkit.org/b/127860 [ Debug ] js/function-apply-aliased.html [ Skip ] > # This test verifies dynamic manipulation of the mroot and msqrt elements. > mathml/roots-removeChild.html [ ImageOnlyFailure ] > >-webkit.org/b/133359 mathml/presentation/style-changed.html [ ImageOnlyFailure ] >-webkit.org/b/136291 platform/mac/accessibility/webkit-alt-for-css-content.html [ Failure ] >-webkit.org/b/136291 platform/mac/accessibility/alt-for-css-content.html [ Failure ] >- > # This test verifies that a mismatch reftest will fail as intended if both results are same. (introduced in r93187) > fast/harness/sample-fail-mismatch-reftest.html [ WontFix ImageOnlyFailure ] > >diff --git a/LayoutTests/css3/flexbox/css-properties-expected.txt b/LayoutTests/css3/flexbox/css-properties-expected.txt >index f32934e42bb6200bf3df2ba8879571e3c42c77cc..16ab20e835c3bc53a381900ded4be99c658945e5 100644 >--- a/LayoutTests/css3/flexbox/css-properties-expected.txt >+++ b/LayoutTests/css3/flexbox/css-properties-expected.txt >@@ -29,12 +29,11 @@ PASS window.getComputedStyle(flexbox, null).webkitJustifyContent is "space-betwe > PASS flexbox.style.webkitJustifyContent is "" > PASS window.getComputedStyle(flexbox, null).webkitJustifyContent is "flex-start" > PASS flexbox.style.webkitAlignSelf is "" >-PASS window.getComputedStyle(flexbox, null).webkitAlignSelf is "start" >-PASS window.getComputedStyle(document.documentElement, null).webkitAlignSelf is "auto" >+PASS window.getComputedStyle(flexbox, null).webkitAlignSelf is "stretch" >+PASS window.getComputedStyle(document.documentElement, null).webkitAlignSelf is "stretch" > PASS flexbox.style.webkitAlignSelf is "" >-PASS window.getComputedStyle(flexbox, null).webkitAlignSelf is "start" > PASS flexbox.style.webkitAlignSelf is "auto" >-PASS window.getComputedStyle(flexbox, null).webkitAlignSelf is "start" >+PASS window.getComputedStyle(flexbox, null).webkitAlignSelf is "stretch" > PASS flexbox.style.webkitAlignSelf is "flex-start" > PASS window.getComputedStyle(flexbox, null).webkitAlignSelf is "flex-start" > PASS flexbox.style.webkitAlignSelf is "flex-end" >@@ -46,21 +45,15 @@ PASS window.getComputedStyle(flexbox, null).webkitAlignSelf is "stretch" > PASS flexbox.style.webkitAlignSelf is "baseline" > PASS window.getComputedStyle(flexbox, null).webkitAlignSelf is "baseline" > PASS flexbox.style.webkitAlignSelf is "" >-PASS window.getComputedStyle(flexbox, null).webkitAlignSelf is "start" >+PASS window.getComputedStyle(flexbox, null).webkitAlignSelf is "stretch" > PASS flexbox.style.webkitAlignItems is "" >-PASS flexitem.style.webkitAlignSelf is "" > PASS window.getComputedStyle(flexbox, null).webkitAlignItems is "stretch" > PASS window.getComputedStyle(flexitem, null).webkitAlignSelf is "stretch" > PASS flexbox.style.webkitAlignItems is "" >-PASS flexitem.style.webkitAlignSelf is "" >-PASS window.getComputedStyle(flexbox, null).webkitAlignItems is "stretch" >-PASS window.getComputedStyle(flexitem, null).webkitAlignSelf is "stretch" >-PASS flexbox.style.webkitAlignItems is "auto" >-PASS flexitem.style.webkitAlignSelf is "" >+PASS flexbox.style.webkitAlignItems is "" > PASS window.getComputedStyle(flexbox, null).webkitAlignItems is "stretch" > PASS window.getComputedStyle(flexitem, null).webkitAlignSelf is "stretch" > PASS flexbox.style.webkitAlignItems is "flex-start" >-PASS flexitem.style.webkitAlignSelf is "" > PASS window.getComputedStyle(flexbox, null).webkitAlignItems is "flex-start" > PASS window.getComputedStyle(flexitem, null).webkitAlignSelf is "flex-start" > PASS flexbox.style.webkitAlignItems is "flex-end" >@@ -79,8 +72,8 @@ PASS flexbox.style.webkitAlignItems is "" > PASS window.getComputedStyle(flexbox, null).webkitAlignItems is "stretch" > PASS window.getComputedStyle(flexitem, null).webkitAlignSelf is "stretch" > PASS flexbox.style.webkitAlignItems is "" >-PASS window.getComputedStyle(flexbox, null).webkitAlignItems is "start" >-PASS window.getComputedStyle(flexitem, null).webkitAlignSelf is "start" >+PASS window.getComputedStyle(flexbox, null).webkitAlignItems is "stretch" >+PASS window.getComputedStyle(flexitem, null).webkitAlignSelf is "stretch" > PASS window.getComputedStyle(detachedFlexbox, null).webkitAlignSelf is "" > PASS window.getComputedStyle(detachedFlexItem, null).webkitAlignSelf is "" > PASS flexbox.style.webkitFlexDirection is "" >diff --git a/LayoutTests/css3/flexbox/css-properties.html b/LayoutTests/css3/flexbox/css-properties.html >index 51a0a68d080258217a815f58f0309ed73a99bd7d..d721efc872a3d13a0f75087113079d0a40fcf619 100644 >--- a/LayoutTests/css3/flexbox/css-properties.html >+++ b/LayoutTests/css3/flexbox/css-properties.html >@@ -78,20 +78,18 @@ flexbox.style.webkitJustifyContent = ''; > shouldBeEqualToString('flexbox.style.webkitJustifyContent', ''); > shouldBeEqualToString('window.getComputedStyle(flexbox, null).webkitJustifyContent', 'flex-start'); > >-flexbox.style.display = '-webkit-flex'; > > shouldBeEqualToString('flexbox.style.webkitAlignSelf', ''); >-// The initial value is 'auto', which will be resolved depending on parent's style (except for the 'document' element). >-shouldBeEqualToString('window.getComputedStyle(flexbox, null).webkitAlignSelf', 'start'); >-shouldBeEqualToString('window.getComputedStyle(document.documentElement, null).webkitAlignSelf', 'auto'); >+// The initial value is 'stretch'. >+shouldBeEqualToString('window.getComputedStyle(flexbox, null).webkitAlignSelf', 'stretch'); >+shouldBeEqualToString('window.getComputedStyle(document.documentElement, null).webkitAlignSelf', 'stretch'); > > flexbox.style.webkitAlignSelf = 'foo'; > shouldBeEqualToString('flexbox.style.webkitAlignSelf', ''); >-shouldBeEqualToString('window.getComputedStyle(flexbox, null).webkitAlignSelf', 'start'); > > flexbox.style.webkitAlignSelf = 'auto'; > shouldBeEqualToString('flexbox.style.webkitAlignSelf', 'auto'); >-shouldBeEqualToString('window.getComputedStyle(flexbox, null).webkitAlignSelf', 'start'); >+shouldBeEqualToString('window.getComputedStyle(flexbox, null).webkitAlignSelf', 'stretch'); > > flexbox.style.webkitAlignSelf = 'flex-start'; > shouldBeEqualToString('flexbox.style.webkitAlignSelf', 'flex-start'); >@@ -115,29 +113,23 @@ shouldBeEqualToString('window.getComputedStyle(flexbox, null).webkitAlignSelf', > > flexbox.style.webkitAlignSelf = ''; > shouldBeEqualToString('flexbox.style.webkitAlignSelf', ''); >-shouldBeEqualToString('window.getComputedStyle(flexbox, null).webkitAlignSelf', 'start'); >+shouldBeEqualToString('window.getComputedStyle(flexbox, null).webkitAlignSelf', 'stretch'); > > shouldBeEqualToString('flexbox.style.webkitAlignItems', ''); >-shouldBeEqualToString('flexitem.style.webkitAlignSelf', ''); >-// The initial value is 'auto', which will be resolved to 'stretch' in case of flexbox containers. >+// The initial value is 'stretch'. > shouldBeEqualToString('window.getComputedStyle(flexbox, null).webkitAlignItems', 'stretch'); > shouldBeEqualToString('window.getComputedStyle(flexitem, null).webkitAlignSelf', 'stretch'); > > flexbox.style.webkitAlignItems = 'foo'; > shouldBeEqualToString('flexbox.style.webkitAlignItems', ''); >-shouldBeEqualToString('flexitem.style.webkitAlignSelf', ''); >-shouldBeEqualToString('window.getComputedStyle(flexbox, null).webkitAlignItems', 'stretch'); >-shouldBeEqualToString('window.getComputedStyle(flexitem, null).webkitAlignSelf', 'stretch'); > > flexbox.style.webkitAlignItems = 'auto'; >-shouldBeEqualToString('flexbox.style.webkitAlignItems', 'auto'); >-shouldBeEqualToString('flexitem.style.webkitAlignSelf', ''); >+shouldBeEqualToString('flexbox.style.webkitAlignItems', ''); > shouldBeEqualToString('window.getComputedStyle(flexbox, null).webkitAlignItems', 'stretch'); > shouldBeEqualToString('window.getComputedStyle(flexitem, null).webkitAlignSelf', 'stretch'); > > flexbox.style.webkitAlignItems = 'flex-start'; > shouldBeEqualToString('flexbox.style.webkitAlignItems', 'flex-start'); >-shouldBeEqualToString('flexitem.style.webkitAlignSelf', ''); > shouldBeEqualToString('window.getComputedStyle(flexbox, null).webkitAlignItems', 'flex-start'); > shouldBeEqualToString('window.getComputedStyle(flexitem, null).webkitAlignSelf', 'flex-start'); > >@@ -168,8 +160,8 @@ shouldBeEqualToString('window.getComputedStyle(flexitem, null).webkitAlignSelf', > > flexbox.style.display = 'none'; > shouldBeEqualToString('flexbox.style.webkitAlignItems', ''); >-shouldBeEqualToString('window.getComputedStyle(flexbox, null).webkitAlignItems', 'start'); >-shouldBeEqualToString('window.getComputedStyle(flexitem, null).webkitAlignSelf', 'start'); >+shouldBeEqualToString('window.getComputedStyle(flexbox, null).webkitAlignItems', 'stretch'); >+shouldBeEqualToString('window.getComputedStyle(flexitem, null).webkitAlignSelf', 'stretch'); > flexbox.style.display = ''; > > >diff --git a/LayoutTests/css3/parse-align-items-expected.txt b/LayoutTests/css3/parse-align-items-expected.txt >deleted file mode 100644 >index d5ed30e86ceceb82a86dc1d154f9d043c521ff6e..0000000000000000000000000000000000000000 >--- a/LayoutTests/css3/parse-align-items-expected.txt >+++ /dev/null >@@ -1,137 +0,0 @@ >-Test that setting and getting align-items works as expected >- >-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". >- >- >-Test getting align-items set through CSS >-PASS getComputedStyle(alignItemsBaseline, '').getPropertyValue('-webkit-align-items') is 'baseline' >-PASS getComputedStyle(alignItemsLastBaseline, '').getPropertyValue('-webkit-align-items') is 'last-baseline' >-PASS getComputedStyle(alignItemsStretch, '').getPropertyValue('-webkit-align-items') is 'stretch' >-PASS getComputedStyle(alignItemsStart, '').getPropertyValue('-webkit-align-items') is 'start' >-PASS getComputedStyle(alignItemsEnd, '').getPropertyValue('-webkit-align-items') is 'end' >-PASS getComputedStyle(alignItemsCenter, '').getPropertyValue('-webkit-align-items') is 'center' >-PASS getComputedStyle(alignItemsSelfEnd, '').getPropertyValue('-webkit-align-items') is 'self-end' >-PASS getComputedStyle(alignItemsSelfStart, '').getPropertyValue('-webkit-align-items') is 'self-start' >-PASS getComputedStyle(alignItemsLeft, '').getPropertyValue('-webkit-align-items') is 'left' >-PASS getComputedStyle(alignItemsRight, '').getPropertyValue('-webkit-align-items') is 'right' >-PASS getComputedStyle(alignItemsFlexStart, '').getPropertyValue('-webkit-align-items') is 'flex-start' >-PASS getComputedStyle(alignItemsFlexEnd, '').getPropertyValue('-webkit-align-items') is 'flex-end' >-PASS getComputedStyle(alignItemsEndTrue, '').getPropertyValue('-webkit-align-items') is 'end true' >-PASS getComputedStyle(alignItemsCenterTrue, '').getPropertyValue('-webkit-align-items') is 'center true' >-PASS getComputedStyle(alignItemsSelfEndSafe, '').getPropertyValue('-webkit-align-items') is 'self-end safe' >-PASS getComputedStyle(alignItemsSelfStartSafe, '').getPropertyValue('-webkit-align-items') is 'self-start safe' >-PASS getComputedStyle(alignItemsRightSafe, '').getPropertyValue('-webkit-align-items') is 'right safe' >-PASS getComputedStyle(alignItemsLeftTrue, '').getPropertyValue('-webkit-align-items') is 'left true' >-PASS getComputedStyle(alignItemsFlexStartTrue, '').getPropertyValue('-webkit-align-items') is 'flex-start true' >-PASS getComputedStyle(alignItemsFlexEndSafe, '').getPropertyValue('-webkit-align-items') is 'flex-end safe' >- >-Test initial value of align-items through JS >-PASS getComputedStyle(element, '').getPropertyValue('-webkit-align-items') is 'start' >- >-Test getting and setting align-items through JS >-PASS element.style.webkitAlignItems is "center" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-items') is "center" >-PASS element.style.webkitAlignItems is "start true" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-items') is "start true" >-PASS element.style.webkitAlignItems is "flex-end safe" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-items') is "flex-end safe" >-PASS element.style.webkitAlignItems is "right" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-items') is "right" >-PASS element.style.webkitAlignItems is "center" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-items') is "center" >-PASS element.style.webkitAlignItems is "self-start" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-items') is "self-start" >-PASS element.style.webkitAlignItems is "auto" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-items') is "start" >-PASS element.style.webkitAlignItems is "auto" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-items') is "stretch" >-PASS element.style.webkitAlignItems is "auto" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-items') is "stretch" >-PASS element.style.webkitAlignItems is "self-end" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-items') is "self-end" >- >-Test bad combinations of align-items >-PASS element.style.webkitAlignItems is "" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-items') is "start" >-PASS element.style.webkitAlignItems is "" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-items') is "start" >-PASS element.style.webkitAlignItems is "" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-items') is "start" >-PASS element.style.webkitAlignItems is "" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-items') is "start" >-PASS element.style.webkitAlignItems is "" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-items') is "start" >-PASS element.style.webkitAlignItems is "" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-items') is "start" >-PASS element.style.webkitAlignItems is "" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-items') is "start" >-PASS element.style.webkitAlignItems is "" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-items') is "start" >-PASS element.style.webkitAlignItems is "" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-items') is "start" >-PASS element.style.webkitAlignItems is "" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-items') is "start" >-PASS element.style.webkitAlignItems is "" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-items') is "start" >-PASS element.style.webkitAlignItems is "" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-items') is "start" >-PASS element.style.webkitAlignItems is "" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-items') is "start" >-PASS element.style.webkitAlignItems is "" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-items') is "start" >-PASS element.style.webkitAlignItems is "" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-items') is "start" >-PASS element.style.webkitAlignItems is "" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-items') is "start" >-PASS element.style.webkitAlignItems is "" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-items') is "start" >-PASS element.style.webkitAlignItems is "" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-items') is "start" >-PASS element.style.webkitAlignItems is "" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-items') is "start" >-PASS element.style.webkitAlignItems is "" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-items') is "start" >-PASS element.style.webkitAlignItems is "" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-items') is "start" >-PASS element.style.webkitAlignItems is "" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-items') is "start" >-PASS element.style.webkitAlignItems is "" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-items') is "start" >-PASS element.style.webkitAlignItems is "" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-items') is "start" >- >-Test the value 'initial' >-PASS element.style.webkitAlignItems is "center" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-items') is "center" >-PASS element.style.webkitAlignItems is "initial" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-items') is "start" >- >-Test the value 'initial' for grid containers >-PASS element.style.webkitAlignItems is "left safe" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-items') is "left safe" >-PASS element.style.webkitAlignItems is "initial" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-items') is "stretch" >- >-Test the value 'initial' for flex containers >-PASS element.style.webkitAlignItems is "right true" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-items') is "right true" >-PASS element.style.webkitAlignItems is "initial" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-items') is "stretch" >- >-Test the value 'inherit' >-PASS element.style.webkitAlignItems is "end" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-items') is "end" >-PASS element.style.webkitAlignItems is "inherit" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-items') is "end" >-PASS element.style.webkitAlignItems is "left safe" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-items') is "left safe" >-PASS element.style.webkitAlignItems is "inherit" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-items') is "left safe" >-PASS element.style.webkitAlignItems is "center true" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-items') is "center true" >-PASS element.style.webkitAlignItems is "inherit" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-items') is "center true" >-PASS successfullyParsed is true >- >-TEST COMPLETE >- >diff --git a/LayoutTests/css3/parse-align-items.html b/LayoutTests/css3/parse-align-items.html >deleted file mode 100644 >index d6f1dabdceadbe911da24b3f99a584f7100240ee..0000000000000000000000000000000000000000 >--- a/LayoutTests/css3/parse-align-items.html >+++ /dev/null >@@ -1,270 +0,0 @@ >-<!DOCTYPE html> >-<html> >-<head> >-<style> >-#alignItemsBaseline { >- -webkit-align-items: baseline; >-} >- >-#alignItemsLastBaseline { >- -webkit-align-items: last-baseline; >-} >- >-#alignItemsStretch { >- -webkit-align-items: stretch; >-} >- >-#alignItemsStart { >- -webkit-align-items: start; >-} >- >-#alignItemsEnd { >- -webkit-align-items: end; >-} >- >-#alignItemsCenter { >- -webkit-align-items: center; >-} >- >-#alignItemsSelfStart { >- -webkit-align-items: self-start; >-} >- >-#alignItemsSelfEnd { >- -webkit-align-items: self-end; >-} >- >-#alignItemsLeft { >- -webkit-align-items: left; >-} >- >-#alignItemsRight { >- -webkit-align-items: right; >-} >- >-#alignItemsFlexStart { >- -webkit-align-items: flex-start; >-} >- >-#alignItemsFlexEnd { >- -webkit-align-items: flex-end; >-} >- >-#alignItemsEndTrue { >- -webkit-align-items: end true; >-} >- >-#alignItemsCenterTrue { >- -webkit-align-items: center true; >-} >- >-#alignItemsSelfEndSafe { >- -webkit-align-items: self-end safe; >-} >- >-#alignItemsSelfStartSafe { >- -webkit-align-items: self-start safe; >-} >- >-#alignItemsRightSafe { >- -webkit-align-items: right safe; >-} >- >-#alignItemsLeftTrue { >- -webkit-align-items: left true; >-} >- >-#alignItemsFlexStartTrue { >- -webkit-align-items: flex-start true; >-} >- >-#alignItemsFlexEndSafe { >- -webkit-align-items: flex-end safe; >-} >- >-</style> >-<script src="../resources/js-test.js"></script> >-</head> >-<body> >-<div id="alignItemsBaseline"></div> >-<div id="alignItemsLastBaseline"></div> >-<div id="alignItemsStretch"></div> >-<div id="alignItemsStart"></div> >-<div id="alignItemsEnd"></div> >-<div id="alignItemsCenter"></div> >-<div id="alignItemsSelfStart"></div> >-<div id="alignItemsSelfEnd"></div> >-<div id="alignItemsLeft"></div> >-<div id="alignItemsRight"></div> >-<div id="alignItemsFlexStart"></div> >-<div id="alignItemsFlexEnd"></div> >- >-<div id="alignItemsEndTrue"></div> >-<div id="alignItemsCenterTrue"></div> >-<div id="alignItemsSelfEndSafe"></div> >-<div id="alignItemsSelfStartSafe"></div> >-<div id="alignItemsRightSafe"></div> >-<div id="alignItemsLeftTrue"></div> >-<div id="alignItemsFlexStartTrue"></div> >-<div id="alignItemsFlexEndSafe"></div> >-<script src="resources/alignment-parsing-utils.js"></script> >-<script> >-description('Test that setting and getting align-items works as expected'); >- >-debug("Test getting align-items set through CSS"); >-var alignItemsBaseline = document.getElementById("alignItemsBaseline"); >-shouldBe("getComputedStyle(alignItemsBaseline, '').getPropertyValue('-webkit-align-items')", "'baseline'"); >- >-var alignItemsLastBaseline = document.getElementById("alignItemsLastBaseline"); >-shouldBe("getComputedStyle(alignItemsLastBaseline, '').getPropertyValue('-webkit-align-items')", "'last-baseline'"); >- >-var alignItemsStretch = document.getElementById("alignItemsStretch"); >-shouldBe("getComputedStyle(alignItemsStretch, '').getPropertyValue('-webkit-align-items')", "'stretch'"); >- >-var alignItemsStart = document.getElementById("alignItemsStart"); >-shouldBe("getComputedStyle(alignItemsStart, '').getPropertyValue('-webkit-align-items')", "'start'"); >- >-var alignItemsEnd = document.getElementById("alignItemsEnd"); >-shouldBe("getComputedStyle(alignItemsEnd, '').getPropertyValue('-webkit-align-items')", "'end'"); >- >-var alignItemsCenter = document.getElementById("alignItemsCenter"); >-shouldBe("getComputedStyle(alignItemsCenter, '').getPropertyValue('-webkit-align-items')", "'center'"); >- >-var alignItemsSelfEnd = document.getElementById("alignItemsSelfEnd"); >-shouldBe("getComputedStyle(alignItemsSelfEnd, '').getPropertyValue('-webkit-align-items')", "'self-end'"); >- >-var alignItemsSelfStart = document.getElementById("alignItemsSelfStart"); >-shouldBe("getComputedStyle(alignItemsSelfStart, '').getPropertyValue('-webkit-align-items')", "'self-start'"); >- >-var alignItemsLeft = document.getElementById("alignItemsLeft"); >-shouldBe("getComputedStyle(alignItemsLeft, '').getPropertyValue('-webkit-align-items')", "'left'"); >- >-var alignItemsRight = document.getElementById("alignItemsRight"); >-shouldBe("getComputedStyle(alignItemsRight, '').getPropertyValue('-webkit-align-items')", "'right'"); >- >-var alignItemsFlexStart = document.getElementById("alignItemsFlexStart"); >-shouldBe("getComputedStyle(alignItemsFlexStart, '').getPropertyValue('-webkit-align-items')", "'flex-start'"); >- >-var alignItemsFlexEnd = document.getElementById("alignItemsFlexEnd"); >-shouldBe("getComputedStyle(alignItemsFlexEnd, '').getPropertyValue('-webkit-align-items')", "'flex-end'"); >- >-var alignItemsEndTrue = document.getElementById("alignItemsEndTrue"); >-shouldBe("getComputedStyle(alignItemsEndTrue, '').getPropertyValue('-webkit-align-items')", "'end true'"); >- >-var alignItemsCenterTrue = document.getElementById("alignItemsCenterTrue"); >-shouldBe("getComputedStyle(alignItemsCenterTrue, '').getPropertyValue('-webkit-align-items')", "'center true'"); >- >-var alignItemsSelfEndSafe = document.getElementById("alignItemsSelfEndSafe"); >-shouldBe("getComputedStyle(alignItemsSelfEndSafe, '').getPropertyValue('-webkit-align-items')", "'self-end safe'"); >- >-var alignItemsSelfStartSafe = document.getElementById("alignItemsSelfStartSafe"); >-shouldBe("getComputedStyle(alignItemsSelfStartSafe, '').getPropertyValue('-webkit-align-items')", "'self-start safe'"); >- >-var alignItemsRightSafe = document.getElementById("alignItemsRightSafe"); >-shouldBe("getComputedStyle(alignItemsRightSafe, '').getPropertyValue('-webkit-align-items')", "'right safe'"); >- >-var alignItemsLeftTrue = document.getElementById("alignItemsLeftTrue"); >-shouldBe("getComputedStyle(alignItemsLeftTrue, '').getPropertyValue('-webkit-align-items')", "'left true'"); >- >-var alignItemsFlexStartTrue = document.getElementById("alignItemsFlexStartTrue"); >-shouldBe("getComputedStyle(alignItemsFlexStartTrue, '').getPropertyValue('-webkit-align-items')", "'flex-start true'"); >- >-var alignItemsFlexEndSafe = document.getElementById("alignItemsFlexEndSafe"); >-shouldBe("getComputedStyle(alignItemsFlexEndSafe, '').getPropertyValue('-webkit-align-items')", "'flex-end safe'"); >- >-debug(""); >-debug("Test initial value of align-items through JS"); >-element = document.createElement("div"); >-document.body.appendChild(element); >-shouldBe("getComputedStyle(element, '').getPropertyValue('-webkit-align-items')", "'start'"); >- >-debug(""); >-debug("Test getting and setting align-items through JS"); >-element = document.createElement("div"); >-document.body.appendChild(element); >-element.style.webkitAlignItems = "center"; >-checkValues(element, "webkitAlignItems", "-webkit-align-items", "center", "center"); >- >-element.style.webkitAlignItems = "true start"; >-checkValues(element, "webkitAlignItems", "-webkit-align-items", "start true", "start true"); >- >-element.style.webkitAlignItems = "flex-end safe"; >-checkValues(element, "webkitAlignItems", "-webkit-align-items", "flex-end safe", "flex-end safe"); >- >-element.style.webkitAlignItems = "right"; >-checkValues(element, "webkitAlignItems", "-webkit-align-items", "right", "right"); >- >-element.style.webkitAlignItems = "center"; >-checkValues(element, "webkitAlignItems", "-webkit-align-items", "center", "center"); >- >-element.style.webkitAlignItems = "self-start"; >-checkValues(element, "webkitAlignItems", "-webkit-align-items", "self-start", "self-start"); >- >-element.style.webkitAlignItems = "auto"; >-checkValues(element, "webkitAlignItems", "-webkit-align-items", "auto", "start"); >- >-element.style.display = "-webkit-flex"; >-element.style.webkitAlignItems = "auto"; >-checkValues(element, "webkitAlignItems", "-webkit-align-items", "auto", "stretch"); >- >-element.style.display = "-webkit-grid"; >-element.style.webkitAlignItems = "auto"; >-checkValues(element, "webkitAlignItems", "-webkit-align-items", "auto", "stretch"); >- >-element.style.webkitAlignItems = "self-end"; >-checkValues(element, "webkitAlignItems", "-webkit-align-items", "self-end", "self-end"); >- >-debug(""); >-debug("Test bad combinations of align-items"); >-element = document.createElement("div"); >-document.body.appendChild(element); >- >-checkBadValues(element, "webkitAlignItems", "-webkit-align-items", "true auto"); >-checkBadValues(element, "webkitAlignItems", "-webkit-align-items", "auto safe"); >-checkBadValues(element, "webkitAlignItems", "-webkit-align-items", "auto left"); >-checkBadValues(element, "webkitAlignItems", "-webkit-align-items", "baseline safe"); >-checkBadValues(element, "webkitAlignItems", "-webkit-align-items", "baseline center"); >-checkBadValues(element, "webkitAlignItems", "-webkit-align-items", "stretch true"); >-checkBadValues(element, "webkitAlignItems", "-webkit-align-items", "stretch right"); >-checkBadValues(element, "webkitAlignItems", "-webkit-align-items", "true true"); >-checkBadValues(element, "webkitAlignItems", "-webkit-align-items", "true safe"); >-checkBadValues(element, "webkitAlignItems", "-webkit-align-items", "center start"); >-checkBadValues(element, "webkitAlignItems", "-webkit-align-items", "stretch true"); >-checkBadValues(element, "webkitAlignItems", "-webkit-align-items", "safe stretch"); >-checkBadValues(element, "webkitAlignItems", "-webkit-align-items", "baseline safe"); >-checkBadValues(element, "webkitAlignItems", "-webkit-align-items", "true baseline"); >-checkBadValues(element, "webkitAlignItems", "-webkit-align-items", "true safe left"); >-checkBadValues(element, "webkitAlignItems", "-webkit-align-items", "true left safe"); >-checkBadValues(element, "webkitAlignItems", "-webkit-align-items", "left safe true safe"); >-checkBadValues(element, "webkitAlignItems", "-webkit-align-items", "legacy start"); >-checkBadValues(element, "webkitAlignItems", "-webkit-align-items", "legacy end"); >-checkBadValues(element, "webkitAlignItems", "-webkit-align-items", "legacy right true"); >-checkBadValues(element, "webkitAlignItems", "-webkit-align-items", "legacy auto"); >-checkBadValues(element, "webkitAlignItems", "-webkit-align-items", "legacy stretch"); >-checkBadValues(element, "webkitAlignItems", "-webkit-align-items", "legacy"); >-checkBadValues(element, "webkitAlignItems", "-webkit-align-items", "legacy left right"); >- >-debug(""); >-debug("Test the value 'initial'"); >-element.style.display = ""; >-checkInitialValues(element, "webkitAlignItems", "-webkit-align-items", "center", "start"); >- >-debug(""); >-debug("Test the value 'initial' for grid containers"); >-element.style.display = "-webkit-grid"; >-checkInitialValues(element, "webkitAlignItems", "-webkit-align-items", "left safe", "stretch"); >- >-debug(""); >-debug("Test the value 'initial' for flex containers"); >-element.style.display = "-webkit-flex"; >-checkInitialValues(element, "webkitAlignItems", "-webkit-align-items", "right true", "stretch"); >- >-debug(""); >-debug("Test the value 'inherit'"); >-checkInheritValues("webkitAlignItems", "-webkit-align-items", "end"); >-checkInheritValues("webkitAlignItems", "-webkit-align-items", "left safe"); >-checkInheritValues("webkitAlignItems", "-webkit-align-items", "center true"); >- >-</script> >-</body> >-</html> >diff --git a/LayoutTests/css3/parse-align-self-expected.txt b/LayoutTests/css3/parse-align-self-expected.txt >deleted file mode 100644 >index 4a1f1615d0eb7bd0a5595e05ad7d1f1bf8427f9b..0000000000000000000000000000000000000000 >--- a/LayoutTests/css3/parse-align-self-expected.txt >+++ /dev/null >@@ -1,155 +0,0 @@ >-Test that setting and getting align-self works as expected >- >-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". >- >- >-Test getting align-self set through CSS >-PASS getComputedStyle(alignSelfBaseline, '').getPropertyValue('-webkit-align-self') is 'baseline' >-PASS getComputedStyle(alignSelfLastBaseline, '').getPropertyValue('-webkit-align-self') is 'last-baseline' >-PASS getComputedStyle(alignSelfStretch, '').getPropertyValue('-webkit-align-self') is 'stretch' >-PASS getComputedStyle(alignSelfStart, '').getPropertyValue('-webkit-align-self') is 'start' >-PASS getComputedStyle(alignSelfEnd, '').getPropertyValue('-webkit-align-self') is 'end' >-PASS getComputedStyle(alignSelfCenter, '').getPropertyValue('-webkit-align-self') is 'center' >-PASS getComputedStyle(alignSelfSelfEnd, '').getPropertyValue('-webkit-align-self') is 'self-end' >-PASS getComputedStyle(alignSelfSelfStart, '').getPropertyValue('-webkit-align-self') is 'self-start' >-PASS getComputedStyle(alignSelfLeft, '').getPropertyValue('-webkit-align-self') is 'left' >-PASS getComputedStyle(alignSelfRight, '').getPropertyValue('-webkit-align-self') is 'right' >-PASS getComputedStyle(alignSelfFlexStart, '').getPropertyValue('-webkit-align-self') is 'flex-start' >-PASS getComputedStyle(alignSelfFlexEnd, '').getPropertyValue('-webkit-align-self') is 'flex-end' >-PASS getComputedStyle(alignSelfEndTrue, '').getPropertyValue('-webkit-align-self') is 'end true' >-PASS getComputedStyle(alignSelfCenterTrue, '').getPropertyValue('-webkit-align-self') is 'center true' >-PASS getComputedStyle(alignSelfSelfEndSafe, '').getPropertyValue('-webkit-align-self') is 'self-end safe' >-PASS getComputedStyle(alignSelfSelfStartSafe, '').getPropertyValue('-webkit-align-self') is 'self-start safe' >-PASS getComputedStyle(alignSelfRightSafe, '').getPropertyValue('-webkit-align-self') is 'right safe' >-PASS getComputedStyle(alignSelfLeftTrue, '').getPropertyValue('-webkit-align-self') is 'left true' >-PASS getComputedStyle(alignSelfFlexStartTrue, '').getPropertyValue('-webkit-align-self') is 'flex-start true' >-PASS getComputedStyle(alignSelfFlexEndSafe, '').getPropertyValue('-webkit-align-self') is 'flex-end safe' >- >-Test initial value of align-self through JS >-PASS getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is 'start' >- >-Test getting and setting align-self through JS >-PASS element.style.webkitAlignSelf is "center" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "center" >-PASS element.style.webkitAlignSelf is "start true" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "start true" >-PASS element.style.webkitAlignSelf is "flex-end safe" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "flex-end safe" >-PASS element.style.webkitAlignSelf is "right" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "right" >-PASS element.style.webkitAlignSelf is "center" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "center" >-PASS element.style.webkitAlignSelf is "self-start" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "self-start" >-PASS element.style.webkitAlignSelf is "auto" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "start" >-PASS element.style.webkitAlignSelf is "auto" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "stretch" >-PASS element.style.webkitAlignSelf is "auto" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "stretch" >-PASS element.style.webkitAlignSelf is "self-end" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "self-end" >- >-Test bad combinations of align-self >-PASS element.style.webkitAlignSelf is "" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "start" >-PASS element.style.webkitAlignSelf is "" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "start" >-PASS element.style.webkitAlignSelf is "" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "start" >-PASS element.style.webkitAlignSelf is "" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "start" >-PASS element.style.webkitAlignSelf is "" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "start" >-PASS element.style.webkitAlignSelf is "" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "start" >-PASS element.style.webkitAlignSelf is "" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "start" >-PASS element.style.webkitAlignSelf is "" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "start" >-PASS element.style.webkitAlignSelf is "" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "start" >-PASS element.style.webkitAlignSelf is "" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "start" >-PASS element.style.webkitAlignSelf is "" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "start" >-PASS element.style.webkitAlignSelf is "" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "start" >-PASS element.style.webkitAlignSelf is "" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "start" >-PASS element.style.webkitAlignSelf is "" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "start" >-PASS element.style.webkitAlignSelf is "" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "start" >-PASS element.style.webkitAlignSelf is "" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "start" >-PASS element.style.webkitAlignSelf is "" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "start" >-PASS element.style.webkitAlignSelf is "" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "start" >-PASS element.style.webkitAlignSelf is "" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "start" >-PASS element.style.webkitAlignSelf is "" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "start" >-PASS element.style.webkitAlignSelf is "" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "start" >-PASS element.style.webkitAlignSelf is "" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "start" >-PASS element.style.webkitAlignSelf is "" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "start" >-PASS element.style.webkitAlignSelf is "" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "start" >- >-Test the value 'initial' >-PASS element.style.webkitAlignSelf is "center" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "center" >-PASS element.style.webkitAlignSelf is "initial" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "start" >- >-Test the value 'initial' for grid containers >-PASS element.style.webkitAlignSelf is "left safe" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "left safe" >-PASS element.style.webkitAlignSelf is "initial" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "stretch" >- >-Test the value 'initial' for flex containers >-PASS element.style.webkitAlignSelf is "right true" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "right true" >-PASS element.style.webkitAlignSelf is "initial" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "stretch" >- >-Test the value 'initial' for positioned elements >-PASS element.style.webkitAlignSelf is "left" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "left" >-PASS element.style.webkitAlignSelf is "initial" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "stretch" >- >-Test the value 'initial' for positioned elements in grid containers >-PASS element.style.webkitAlignSelf is "right" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "right" >-PASS element.style.webkitAlignSelf is "initial" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "stretch" >- >-Test the value 'initial' for positioned elements in grid containers >-PASS element.style.webkitAlignSelf is "end" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "end" >-PASS element.style.webkitAlignSelf is "initial" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "stretch" >- >-Test the value 'inherit' >-PASS element.style.webkitAlignSelf is "end" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "end" >-PASS element.style.webkitAlignSelf is "inherit" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "end" >-PASS element.style.webkitAlignSelf is "left safe" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "left safe" >-PASS element.style.webkitAlignSelf is "inherit" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "left safe" >-PASS element.style.webkitAlignSelf is "center true" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "center true" >-PASS element.style.webkitAlignSelf is "inherit" >-PASS window.getComputedStyle(element, '').getPropertyValue('-webkit-align-self') is "center true" >-PASS successfullyParsed is true >- >-TEST COMPLETE >- >diff --git a/LayoutTests/css3/parse-align-self.html b/LayoutTests/css3/parse-align-self.html >deleted file mode 100644 >index aa83209dc3c96a50f304e442f65914aac258f6f0..0000000000000000000000000000000000000000 >--- a/LayoutTests/css3/parse-align-self.html >+++ /dev/null >@@ -1,291 +0,0 @@ >-<!DOCTYPE html> >-<html> >-<head> >-<style> >-#alignSelfBaseline { >- -webkit-align-self: baseline; >-} >- >-#alignSelfLastBaseline { >- -webkit-align-self: last-baseline; >-} >- >-#alignSelfStretch { >- -webkit-align-self: stretch; >-} >- >-#alignSelfStart { >- -webkit-align-self: start; >-} >- >-#alignSelfEnd { >- -webkit-align-self: end; >-} >- >-#alignSelfCenter { >- -webkit-align-self: center; >-} >- >-#alignSelfSelfStart { >- -webkit-align-self: self-start; >-} >- >-#alignSelfSelfEnd { >- -webkit-align-self: self-end; >-} >- >-#alignSelfLeft { >- -webkit-align-self: left; >-} >- >-#alignSelfRight { >- -webkit-align-self: right; >-} >- >-#alignSelfFlexStart { >- -webkit-align-self: flex-start; >-} >- >-#alignSelfFlexEnd { >- -webkit-align-self: flex-end; >-} >- >-#alignSelfEndTrue { >- -webkit-align-self: end true; >-} >- >-#alignSelfCenterTrue { >- -webkit-align-self: center true; >-} >- >-#alignSelfSelfEndSafe { >- -webkit-align-self: self-end safe; >-} >- >-#alignSelfSelfStartSafe { >- -webkit-align-self: self-start safe; >-} >- >-#alignSelfRightSafe { >- -webkit-align-self: right safe; >-} >- >-#alignSelfLeftTrue { >- -webkit-align-self: left true; >-} >- >-#alignSelfFlexStartTrue { >- -webkit-align-self: flex-start true; >-} >- >-#alignSelfFlexEndSafe { >- -webkit-align-self: flex-end safe; >-} >-</style> >-<script src="../resources/js-test.js"></script> >-</head> >-<body> >-<div id="alignSelfBaseline"></div> >-<div id="alignSelfLastBaseline"></div> >-<div id="alignSelfStretch"></div> >-<div id="alignSelfStart"></div> >-<div id="alignSelfEnd"></div> >-<div id="alignSelfCenter"></div> >-<div id="alignSelfSelfStart"></div> >-<div id="alignSelfSelfEnd"></div> >-<div id="alignSelfLeft"></div> >-<div id="alignSelfRight"></div> >-<div id="alignSelfFlexStart"></div> >-<div id="alignSelfFlexEnd"></div> >- >-<div id="alignSelfEndTrue"></div> >-<div id="alignSelfCenterTrue"></div> >-<div id="alignSelfSelfEndSafe"></div> >-<div id="alignSelfSelfStartSafe"></div> >-<div id="alignSelfRightSafe"></div> >-<div id="alignSelfLeftTrue"></div> >-<div id="alignSelfFlexStartTrue"></div> >-<div id="alignSelfFlexEndSafe"></div> >-<script src="resources/alignment-parsing-utils.js"></script> >-<script> >-description('Test that setting and getting align-self works as expected'); >- >-debug("Test getting align-self set through CSS"); >-var alignSelfBaseline = document.getElementById("alignSelfBaseline"); >-shouldBe("getComputedStyle(alignSelfBaseline, '').getPropertyValue('-webkit-align-self')", "'baseline'"); >- >-var alignSelfLastBaseline = document.getElementById("alignSelfLastBaseline"); >-shouldBe("getComputedStyle(alignSelfLastBaseline, '').getPropertyValue('-webkit-align-self')", "'last-baseline'"); >- >-var alignSelfStretch = document.getElementById("alignSelfStretch"); >-shouldBe("getComputedStyle(alignSelfStretch, '').getPropertyValue('-webkit-align-self')", "'stretch'"); >- >-var alignSelfStart = document.getElementById("alignSelfStart"); >-shouldBe("getComputedStyle(alignSelfStart, '').getPropertyValue('-webkit-align-self')", "'start'"); >- >-var alignSelfEnd = document.getElementById("alignSelfEnd"); >-shouldBe("getComputedStyle(alignSelfEnd, '').getPropertyValue('-webkit-align-self')", "'end'"); >- >-var alignSelfCenter = document.getElementById("alignSelfCenter"); >-shouldBe("getComputedStyle(alignSelfCenter, '').getPropertyValue('-webkit-align-self')", "'center'"); >- >-var alignSelfSelfEnd = document.getElementById("alignSelfSelfEnd"); >-shouldBe("getComputedStyle(alignSelfSelfEnd, '').getPropertyValue('-webkit-align-self')", "'self-end'"); >- >-var alignSelfSelfStart = document.getElementById("alignSelfSelfStart"); >-shouldBe("getComputedStyle(alignSelfSelfStart, '').getPropertyValue('-webkit-align-self')", "'self-start'"); >- >-var alignSelfLeft = document.getElementById("alignSelfLeft"); >-shouldBe("getComputedStyle(alignSelfLeft, '').getPropertyValue('-webkit-align-self')", "'left'"); >- >-var alignSelfRight = document.getElementById("alignSelfRight"); >-shouldBe("getComputedStyle(alignSelfRight, '').getPropertyValue('-webkit-align-self')", "'right'"); >- >-var alignSelfFlexStart = document.getElementById("alignSelfFlexStart"); >-shouldBe("getComputedStyle(alignSelfFlexStart, '').getPropertyValue('-webkit-align-self')", "'flex-start'"); >- >-var alignSelfFlexEnd = document.getElementById("alignSelfFlexEnd"); >-shouldBe("getComputedStyle(alignSelfFlexEnd, '').getPropertyValue('-webkit-align-self')", "'flex-end'"); >- >-var alignSelfEndTrue = document.getElementById("alignSelfEndTrue"); >-shouldBe("getComputedStyle(alignSelfEndTrue, '').getPropertyValue('-webkit-align-self')", "'end true'"); >- >-var alignSelfCenterTrue = document.getElementById("alignSelfCenterTrue"); >-shouldBe("getComputedStyle(alignSelfCenterTrue, '').getPropertyValue('-webkit-align-self')", "'center true'"); >- >-var alignSelfSelfEndSafe = document.getElementById("alignSelfSelfEndSafe"); >-shouldBe("getComputedStyle(alignSelfSelfEndSafe, '').getPropertyValue('-webkit-align-self')", "'self-end safe'"); >- >-var alignSelfSelfStartSafe = document.getElementById("alignSelfSelfStartSafe"); >-shouldBe("getComputedStyle(alignSelfSelfStartSafe, '').getPropertyValue('-webkit-align-self')", "'self-start safe'"); >- >-var alignSelfRightSafe = document.getElementById("alignSelfRightSafe"); >-shouldBe("getComputedStyle(alignSelfRightSafe, '').getPropertyValue('-webkit-align-self')", "'right safe'"); >- >-var alignSelfLeftTrue = document.getElementById("alignSelfLeftTrue"); >-shouldBe("getComputedStyle(alignSelfLeftTrue, '').getPropertyValue('-webkit-align-self')", "'left true'"); >- >-var alignSelfFlexStartTrue = document.getElementById("alignSelfFlexStartTrue"); >-shouldBe("getComputedStyle(alignSelfFlexStartTrue, '').getPropertyValue('-webkit-align-self')", "'flex-start true'"); >- >-var alignSelfFlexEndSafe = document.getElementById("alignSelfFlexEndSafe"); >-shouldBe("getComputedStyle(alignSelfFlexEndSafe, '').getPropertyValue('-webkit-align-self')", "'flex-end safe'"); >- >-debug(""); >-debug("Test initial value of align-self through JS"); >-element = document.createElement("div"); >-document.body.appendChild(element); >-shouldBe("getComputedStyle(element, '').getPropertyValue('-webkit-align-self')", "'start'"); >- >-debug(""); >-debug("Test getting and setting align-self through JS"); >-container = document.createElement("div"); >-element = document.createElement("div"); >-container.appendChild(element); >-document.body.appendChild(container); >-element.style.webkitAlignSelf = "center"; >-checkValues(element, "webkitAlignSelf", "-webkit-align-self", "center", "center"); >- >-element.style.webkitAlignSelf = "true start"; >-checkValues(element, "webkitAlignSelf", "-webkit-align-self", "start true", "start true"); >- >-element.style.webkitAlignSelf = "flex-end safe"; >-checkValues(element, "webkitAlignSelf", "-webkit-align-self", "flex-end safe", "flex-end safe"); >- >-element.style.webkitAlignSelf = "right"; >-checkValues(element, "webkitAlignSelf", "-webkit-align-self", "right", "right"); >- >-element.style.webkitAlignSelf = "center"; >-checkValues(element, "webkitAlignSelf", "-webkit-align-self", "center", "center"); >- >-element.style.webkitAlignSelf = "self-start"; >-checkValues(element, "webkitAlignSelf", "-webkit-align-self", "self-start", "self-start"); >- >-element.style.webkitAlignSelf = "auto"; >-checkValues(element, "webkitAlignSelf", "-webkit-align-self", "auto", "start"); >- >-container.style.display = "-webkit-flex"; >-element.style.webkitAlignSelf = "auto"; >-checkValues(element, "webkitAlignSelf", "-webkit-align-self", "auto", "stretch"); >- >-container.style.display = "-webkit-grid"; >-element.style.webkitAlignSelf = "auto"; >-checkValues(element, "webkitAlignSelf", "-webkit-align-self", "auto", "stretch"); >- >-element.style.webkitAlignSelf = "self-end"; >-checkValues(element, "webkitAlignSelf", "-webkit-align-self", "self-end", "self-end"); >- >-debug(""); >-debug("Test bad combinations of align-self"); >-container = document.createElement("div"); >-element = document.createElement("div"); >-container.appendChild(element); >-document.body.appendChild(container); >- >-checkBadValues(element, "webkitAlignSelf", "-webkit-align-self", "true auto"); >-checkBadValues(element, "webkitAlignSelf", "-webkit-align-self", "auto safe"); >-checkBadValues(element, "webkitAlignSelf", "-webkit-align-self", "auto left"); >-checkBadValues(element, "webkitAlignSelf", "-webkit-align-self", "baseline safe"); >-checkBadValues(element, "webkitAlignSelf", "-webkit-align-self", "baseline center"); >-checkBadValues(element, "webkitAlignSelf", "-webkit-align-self", "stretch true"); >-checkBadValues(element, "webkitAlignSelf", "-webkit-align-self", "stretch right"); >-checkBadValues(element, "webkitAlignSelf", "-webkit-align-self", "true true"); >-checkBadValues(element, "webkitAlignSelf", "-webkit-align-self", "true safe"); >-checkBadValues(element, "webkitAlignSelf", "-webkit-align-self", "center start"); >-checkBadValues(element, "webkitAlignSelf", "-webkit-align-self", "stretch true"); >-checkBadValues(element, "webkitAlignSelf", "-webkit-align-self", "safe stretch"); >-checkBadValues(element, "webkitAlignSelf", "-webkit-align-self", "baseline safe"); >-checkBadValues(element, "webkitAlignSelf", "-webkit-align-self", "true baseline"); >-checkBadValues(element, "webkitAlignSelf", "-webkit-align-self", "true safe left"); >-checkBadValues(element, "webkitAlignSelf", "-webkit-align-self", "true left safe"); >-checkBadValues(element, "webkitAlignSelf", "-webkit-align-self", "left safe true safe"); >-checkBadValues(element, "webkitAlignSelf", "-webkit-align-self", "legacy start"); >-checkBadValues(element, "webkitAlignSelf", "-webkit-align-self", "legacy end"); >-checkBadValues(element, "webkitAlignSelf", "-webkit-align-self", "legacy right true"); >-checkBadValues(element, "webkitAlignSelf", "-webkit-align-self", "legacy auto"); >-checkBadValues(element, "webkitAlignSelf", "-webkit-align-self", "legacy stretch"); >-checkBadValues(element, "webkitAlignSelf", "-webkit-align-self", "legacy"); >-checkBadValues(element, "webkitAlignSelf", "-webkit-align-self", "legacy left right"); >- >-debug(""); >-debug("Test the value 'initial'"); >-container.style.display = ""; >-checkInitialValues(element, "webkitAlignSelf", "-webkit-align-self", "center", "start"); >- >-debug(""); >-debug("Test the value 'initial' for grid containers"); >-container.style.display = "-webkit-grid"; >-checkInitialValues(element, "webkitAlignSelf", "-webkit-align-self", "left safe", "stretch"); >- >-debug(""); >-debug("Test the value 'initial' for flex containers"); >-container.style.display = "-webkit-flex"; >-checkInitialValues(element, "webkitAlignSelf", "-webkit-align-self", "right true", "stretch"); >- >-debug(""); >-debug("Test the value 'initial' for positioned elements"); >-container.style.display = ""; >-element.style.position = "absolute"; >-checkInitialValues(element, "webkitAlignSelf", "-webkit-align-self", "left", "stretch"); >- >-debug(""); >-debug("Test the value 'initial' for positioned elements in grid containers"); >-container.style.display = "-webkit-grid"; >-element.style.position = "absolute"; >-checkInitialValues(element, "webkitAlignSelf", "-webkit-align-self", "right", "stretch"); >- >-debug(""); >-debug("Test the value 'initial' for positioned elements in grid containers"); >-container.style.display = "-webkit-flex"; >-element.style.position = "absolute"; >-checkInitialValues(element, "webkitAlignSelf", "-webkit-align-self", "end", "stretch"); >- >-debug(""); >-debug("Test the value 'inherit'"); >-checkInheritValues("webkitAlignSelf", "-webkit-align-self", "end"); >-checkInheritValues("webkitAlignSelf", "-webkit-align-self", "left safe"); >-checkInheritValues("webkitAlignSelf", "-webkit-align-self", "center true"); >- >-</script> >-</body> >-</html> >diff --git a/LayoutTests/css3/resources/alignment-parsing-utils.js b/LayoutTests/css3/resources/alignment-parsing-utils.js >deleted file mode 100644 >index b97022a88c65762a347e2686428d51a24d38ed82..0000000000000000000000000000000000000000 >--- a/LayoutTests/css3/resources/alignment-parsing-utils.js >+++ /dev/null >@@ -1,46 +0,0 @@ >-function checkValues(element, property, propertyID, value, computedValue) >-{ >- window.element = element; >- var elementID = element.id || "element"; >- shouldBeEqualToString("element.style." + property, value); >- shouldBeEqualToString("window.getComputedStyle(" + elementID + ", '').getPropertyValue('" + propertyID + "')", computedValue); >-} >- >-function checkBadValues(element, property, propertyID, value) >-{ >- element.style[property] = value; >- checkValues(element, property, propertyID, "", "start"); >-} >- >-function checkInitialValues(element, property, propertyID, value, initial) >-{ >- element.style[property] = value; >- checkValues(element, property, propertyID, value, value); >- element.style[property] = "initial"; >- checkValues(element, property, propertyID, "initial", initial); >-} >- >-function checkInheritValues(property, propertyID, value) >-{ >- var parentElement = document.createElement("div"); >- document.body.appendChild(parentElement); >- parentElement.style[property] = value; >- checkValues(parentElement, property, propertyID, value, value); >- >- var element = document.createElement("div"); >- parentElement.appendChild(element); >- element.style[property] = "inherit"; >- checkValues(element, property, propertyID, "inherit", value); >-} >- >-function checkLegacyValues(property, propertyID, value) >-{ >- var parentElement = document.createElement("div"); >- document.body.appendChild(parentElement); >- parentElement.style[property] = value; >- checkValues(parentElement, property, propertyID, value, value); >- >- var element = document.createElement("div"); >- parentElement.appendChild(element); >- checkValues(element, property, propertyID, "", value); >-} >diff --git a/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt b/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt >index 686bf6a95ff44b9abdcff684c38c703b50de5d5c..9fad3beceda9a98cc5ab76a0945873fa210bf4ea 100644 >--- a/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt >+++ b/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt >@@ -144,12 +144,11 @@ column-rule-width: 0px; > column-span: none; > column-width: auto; > align-content: stretch; >-align-items: start; >-align-self: start; >+align-items: stretch; >+align-self: stretch; > flex-direction: row; > flex-wrap: nowrap; > justify-content: flex-start; >-justify-self: auto; > -webkit-font-kerning: auto; > -webkit-font-smoothing: auto; > -webkit-font-variant-ligatures: normal; >diff --git a/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt b/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt >index 30d30db767eb38ba05933285a190a78c425195aa..56354f867ef7109964e0a3dc9d685afa578e82e7 100644 >--- a/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt >+++ b/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt >@@ -143,12 +143,11 @@ column-rule-width: 0px > column-span: none > column-width: auto > align-content: stretch >-align-items: start >-align-self: start >+align-items: stretch >+align-self: stretch > flex-direction: row > flex-wrap: nowrap > justify-content: flex-start >-justify-self: auto > -webkit-font-kerning: auto > -webkit-font-smoothing: auto > -webkit-font-variant-ligatures: normal >diff --git a/LayoutTests/fast/css/getComputedStyle/resources/property-names.js b/LayoutTests/fast/css/getComputedStyle/resources/property-names.js >index d7e20fe00bf17d11cd1c2b4b1136cada53b4df12..4ac0a80db664ce1e01f71c4bbc738ffcb6c0907c 100644 >--- a/LayoutTests/fast/css/getComputedStyle/resources/property-names.js >+++ b/LayoutTests/fast/css/getComputedStyle/resources/property-names.js >@@ -65,7 +65,6 @@ var propertiesToTest = { > "-webkit-hyphenate-limit-lines": true, > "-webkit-hyphens": true, > "justify-content": true, >- "justify-self": true, > "-webkit-line-align": true, > "-webkit-line-box-contain": true, > "-webkit-line-break": true, >diff --git a/LayoutTests/svg/css/getComputedStyle-basic-expected.txt b/LayoutTests/svg/css/getComputedStyle-basic-expected.txt >index 92c09b82be11ad989407df97bb4c63cd5f88c4ca..89d6474d903ca8f5e676328b4c551e74acfde125 100644 >--- a/LayoutTests/svg/css/getComputedStyle-basic-expected.txt >+++ b/LayoutTests/svg/css/getComputedStyle-basic-expected.txt >@@ -286,18 +286,16 @@ rect: style.getPropertyValue(column-width) : auto > rect: style.getPropertyCSSValue(column-width) : [object CSSPrimitiveValue] > rect: style.getPropertyValue(align-content) : stretch > rect: style.getPropertyCSSValue(align-content) : [object CSSPrimitiveValue] >-rect: style.getPropertyValue(align-items) : start >-rect: style.getPropertyCSSValue(align-items) : [object CSSValueList] >-rect: style.getPropertyValue(align-self) : start >-rect: style.getPropertyCSSValue(align-self) : [object CSSValueList] >+rect: style.getPropertyValue(align-items) : stretch >+rect: style.getPropertyCSSValue(align-items) : [object CSSPrimitiveValue] >+rect: style.getPropertyValue(align-self) : stretch >+rect: style.getPropertyCSSValue(align-self) : [object CSSPrimitiveValue] > rect: style.getPropertyValue(flex-direction) : row > rect: style.getPropertyCSSValue(flex-direction) : [object CSSPrimitiveValue] > rect: style.getPropertyValue(flex-wrap) : nowrap > rect: style.getPropertyCSSValue(flex-wrap) : [object CSSPrimitiveValue] > rect: style.getPropertyValue(justify-content) : flex-start > rect: style.getPropertyCSSValue(justify-content) : [object CSSPrimitiveValue] >-rect: style.getPropertyValue(justify-self) : auto >-rect: style.getPropertyCSSValue(justify-self) : [object CSSValueList] > rect: style.getPropertyValue(-webkit-font-kerning) : auto > rect: style.getPropertyCSSValue(-webkit-font-kerning) : [object CSSPrimitiveValue] > rect: style.getPropertyValue(-webkit-font-smoothing) : auto >@@ -800,18 +798,16 @@ g: style.getPropertyValue(column-width) : auto > g: style.getPropertyCSSValue(column-width) : [object CSSPrimitiveValue] > g: style.getPropertyValue(align-content) : stretch > g: style.getPropertyCSSValue(align-content) : [object CSSPrimitiveValue] >-g: style.getPropertyValue(align-items) : start >-g: style.getPropertyCSSValue(align-items) : [object CSSValueList] >-g: style.getPropertyValue(align-self) : start >-g: style.getPropertyCSSValue(align-self) : [object CSSValueList] >+g: style.getPropertyValue(align-items) : stretch >+g: style.getPropertyCSSValue(align-items) : [object CSSPrimitiveValue] >+g: style.getPropertyValue(align-self) : stretch >+g: style.getPropertyCSSValue(align-self) : [object CSSPrimitiveValue] > g: style.getPropertyValue(flex-direction) : row > g: style.getPropertyCSSValue(flex-direction) : [object CSSPrimitiveValue] > g: style.getPropertyValue(flex-wrap) : nowrap > g: style.getPropertyCSSValue(flex-wrap) : [object CSSPrimitiveValue] > g: style.getPropertyValue(justify-content) : flex-start > g: style.getPropertyCSSValue(justify-content) : [object CSSPrimitiveValue] >-g: style.getPropertyValue(justify-self) : auto >-g: style.getPropertyCSSValue(justify-self) : [object CSSValueList] > g: style.getPropertyValue(-webkit-font-kerning) : auto > g: style.getPropertyCSSValue(-webkit-font-kerning) : [object CSSPrimitiveValue] > g: style.getPropertyValue(-webkit-font-smoothing) : auto
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 138827
: 241774