Attachment 240888 Details for Bug 138335 – Patch

[patch] Patch

bug-138335-20141103173919.patch (text/plain), 2.43 KB, created by Chris Dumez on 2014-11-03 17:39:09 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Dumez

Created: 2014-11-03 17:39:09 PST

Size: 2.43 KB

patch

obsolete

>Subversion Revision: 175490
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index b78bdaffd56416e6f3aa65e438253c1901e736fd..3429f8d3eb72970c0810c00584cde9871e099867 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,21 @@
>+2014-11-03  Chris Dumez  <cdumez@apple.com>
>+
>+        Fix jquery/manipulation.html flakiness on debug builds
>+        https://bugs.webkit.org/show_bug.cgi?id=138335
>+
>+        Reviewed by Alexey Proskuryakov.
>+
>+        Update jquery's qunit config to not refresh the test results
>+        regularly as this is not useful as part of layout testing.
>+
>+        This was causing qunit to set a timer every 13ms to check if
>+        results should be updated and this timer would sometimes get
>+        throttled after r175441.
>+
>+        * TestExpectations:
>+        * jquery/resources/test/qunit/qunit/qunit.js:
>+        (.):
>+
> 2014-11-03  Joseph Pecoraro  <pecoraro@apple.com>
> 
>         Web Inspector: Show Selector's Specificity
>diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
>index f19e4d8af8712573a6c3a5fe0739141877318d17..c1b5e0ace81b8447e9d4175965c76c143429f367 100644
>--- a/LayoutTests/TestExpectations
>+++ b/LayoutTests/TestExpectations
>@@ -196,9 +196,6 @@ webkit.org/b/136754 css3/flexbox/csswg/ttwf-reftest-flex-order.html [ ImageOnlyF
> webkit.org/b/136754 css3/flexbox/csswg/ttwf-reftest-flex-wrap-reverse.html [ ImageOnlyFailure ]
> webkit.org/b/136754 css3/flexbox/csswg/ttwf-reftest-flex-wrap.html [ ImageOnlyFailure ]
> 
>-# This test is currently slow on Debug builds due to timer throttling.
>-webkit.org/b/138262 [ Debug ] jquery/manipulation.html [ Failure Pass ]
>-
> # nth-child tests takes long time and Debug build sometimes timeouts because there are many test cases.
> webkit.org/b/137149 fast/selectors/nth-child-of-basics.html [ Slow ]
> 
>diff --git a/LayoutTests/jquery/resources/test/qunit/qunit/qunit.js b/LayoutTests/jquery/resources/test/qunit/qunit/qunit.js
>index ee6fb8f06d2976928deae56d438648ad53aaba76..cb5d7ac533ec482126a24a38a7484b9863986bf4 100644
>--- a/LayoutTests/jquery/resources/test/qunit/qunit/qunit.js
>+++ b/LayoutTests/jquery/resources/test/qunit/qunit/qunit.js
>@@ -494,7 +494,7 @@ extend(QUnit, {
> 			stats: { all: 0, bad: 0 },
> 			moduleStats: { all: 0, bad: 0 },
> 			started: +new Date,
>-			updateRate: 1000,
>+			updateRate: 0, // Do not update results regularly as this is not needed for layout tests.
> 			blocking: false,
> 			autostart: true,
> 			autorun: false,

Actions: View | Formatted Diff | Diff

Attachments on bug 138335: 240882 | 240888