Attachment 240722 Details for Bug 138238 – Patch

[patch] Patch

bug-138238-20141031123510.patch (text/plain), 3.54 KB, created by Gyuyoung Kim on 2014-10-30 20:35:02 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Gyuyoung Kim

Created: 2014-10-30 20:35:02 PDT

Size: 3.54 KB

patch

obsolete

>Subversion Revision: 175402
>diff --git a/Source/WebKit2/ChangeLog b/Source/WebKit2/ChangeLog
>index cc3cbcb3c005576cdf7d6ba2be20bb269c89e169..37f3fa22fec9fc71f3852338a98f11ef6afe729e 100644
>--- a/Source/WebKit2/ChangeLog
>+++ b/Source/WebKit2/ChangeLog
>@@ -1,3 +1,15 @@
>+2014-10-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
>+
>+        Use std::unique_ptr instead of OwnPtr in CoordinatorDrawingProxy
>+        https://bugs.webkit.org/show_bug.cgi?id=138238
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp:
>+        (WebKit::CoordinatedDrawingAreaProxy::CoordinatedDrawingAreaProxy): Use std::make_unique.
>+        (WebKit::CoordinatedDrawingAreaProxy::enterAcceleratedCompositingMode):
>+        * UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.h: Use std::unique_ptr instead of OwnPtr.
>+
> 2014-10-30  Jer Noble  <jer.noble@apple.com>
> 
>         [EME] Add Setting for accessing storage location for MediaKeys data
>diff --git a/Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp b/Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp
>index 4b5d64817ae70570b64bcb4e456ad5f8f2c070c1..c31de2be7c97cadd7f9b7a3dd4ceea2a1b757247 100644
>--- a/Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp
>+++ b/Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp
>@@ -55,7 +55,7 @@ CoordinatedDrawingAreaProxy::CoordinatedDrawingAreaProxy(WebPageProxy& webPagePr
> {
>     // Construct the proxy early to allow messages to be sent to the web process while AC is entered there.
>     if (webPageProxy.pageGroup().preferences().forceCompositingMode())
>-        m_coordinatedLayerTreeHostProxy = adoptPtr(new CoordinatedLayerTreeHostProxy(this));
>+        m_coordinatedLayerTreeHostProxy = std::make_unique<CoordinatedLayerTreeHostProxy>(this);
> }
> 
> CoordinatedDrawingAreaProxy::~CoordinatedDrawingAreaProxy()
>@@ -324,7 +324,7 @@ void CoordinatedDrawingAreaProxy::enterAcceleratedCompositingMode(const LayerTre
>     m_layerTreeContext = layerTreeContext;
>     m_webPageProxy.enterAcceleratedCompositingMode(layerTreeContext);
>     if (!m_coordinatedLayerTreeHostProxy)
>-        m_coordinatedLayerTreeHostProxy = adoptPtr(new CoordinatedLayerTreeHostProxy(this));
>+        m_coordinatedLayerTreeHostProxy = std::make_unique<CoordinatedLayerTreeHostProxy>(this);
> }
> 
> void CoordinatedDrawingAreaProxy::setVisibleContentsRect(const WebCore::FloatRect& visibleContentsRect, const WebCore::FloatPoint& trajectoryVector)
>diff --git a/Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.h b/Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.h
>index 6199351830dca5a5f0cfa18769683c4e695d8f72..7b54de1d79f176db1b1e7c315cb7f27b205d1c08 100644
>--- a/Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.h
>+++ b/Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.h
>@@ -32,7 +32,6 @@
> #include "BackingStore.h"
> #include "DrawingAreaProxy.h"
> #include "LayerTreeContext.h"
>-#include <wtf/OwnPtr.h>
> #include <wtf/RunLoop.h>
> 
> namespace WebCore {
>@@ -93,7 +92,7 @@ private:
>     void discardBackingStoreSoon();
>     void discardBackingStore();
> 
>-    OwnPtr<CoordinatedLayerTreeHostProxy> m_coordinatedLayerTreeHostProxy;
>+    std::unique_ptr<CoordinatedLayerTreeHostProxy> m_coordinatedLayerTreeHostProxy;
> 
>     // The state ID corresponding to our current backing store. Updated whenever we allocate
>     // a new backing store. Any messages received that correspond to an earlier state are ignored,

Actions: View | Formatted Diff | Diff

Attachments on bug 138238: 240722