Attachment 240002 Details for Bug 137809 – Patch

[patch] Patch

bug-137809-20141017161254.patch (text/plain), 3.06 KB, created by Gyuyoung Kim on 2014-10-17 00:12:50 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Gyuyoung Kim

Created: 2014-10-17 00:12:50 PDT

Size: 3.06 KB

patch

obsolete

>Subversion Revision: 174805
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index c55f49662528c53b222622909325b7bc8f926d88..ba9e63e15f56c3af9dae9ace26c81171cf069594 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,19 @@
>+2014-10-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
>+
>+        Use WTF::move() instead of std::move() to help ensure move semantics in JavaScriptCore
>+        https://bugs.webkit.org/show_bug.cgi?id=137809
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Substitution of WTF::move() for std::move(). Clean up std::move() in JavaScriptCore.
>+
>+        * bytecode/GetByIdStatus.cpp:
>+        (JSC::GetByIdStatus::computeForStubInfo):
>+        * bytecode/PutByIdStatus.cpp:
>+        (JSC::PutByIdStatus::computeForStubInfo):
>+        * bytecode/PutByIdVariant.cpp:
>+        (JSC::PutByIdVariant::setter):
>+
> 2014-10-15  Oliver Hunt  <oliver@apple.com>
> 
>         Use a single allocation for the Arguments object
>diff --git a/Source/JavaScriptCore/bytecode/GetByIdStatus.cpp b/Source/JavaScriptCore/bytecode/GetByIdStatus.cpp
>index 356cfacd7f7d316fe0ff0010a620ee4a74d83b43..113347a5c4a813bc6c847f00be14ff8a24cbc559 100644
>--- a/Source/JavaScriptCore/bytecode/GetByIdStatus.cpp
>+++ b/Source/JavaScriptCore/bytecode/GetByIdStatus.cpp
>@@ -201,7 +201,7 @@ GetByIdStatus GetByIdStatus::computeForStubInfo(
>                  
>                 GetByIdVariant variant(
>                     StructureSet(structure), complexGetStatus.offset(), complexGetStatus.chain(),
>-                    std::move(callLinkStatus));
>+                    WTF::move(callLinkStatus));
>                  
>                 if (!result.appendVariant(variant))
>                     return GetByIdStatus(slowPathState, true);
>diff --git a/Source/JavaScriptCore/bytecode/PutByIdStatus.cpp b/Source/JavaScriptCore/bytecode/PutByIdStatus.cpp
>index 75cf2f1443b07f1c90886dda62e2c4024e2ae959..f2ac18c63a2b9a2f6e45784dbf56f195821a0b72 100644
>--- a/Source/JavaScriptCore/bytecode/PutByIdStatus.cpp
>+++ b/Source/JavaScriptCore/bytecode/PutByIdStatus.cpp
>@@ -249,7 +249,7 @@ PutByIdStatus PutByIdStatus::computeForStubInfo(
>                     
>                     variant = PutByIdVariant::setter(
>                         structure, complexGetStatus.offset(), complexGetStatus.chain(),
>-                        std::move(callLinkStatus));
>+                        WTF::move(callLinkStatus));
>                 } }
>                 break;
>             }
>diff --git a/Source/JavaScriptCore/bytecode/PutByIdVariant.cpp b/Source/JavaScriptCore/bytecode/PutByIdVariant.cpp
>index caa82a182f4412e44e4480c42942a7880cf4c04d..e9d10df673b5d9d7a082ad89ee3063f8a41be7e7 100644
>--- a/Source/JavaScriptCore/bytecode/PutByIdVariant.cpp
>+++ b/Source/JavaScriptCore/bytecode/PutByIdVariant.cpp
>@@ -88,7 +88,7 @@ PutByIdVariant PutByIdVariant::setter(
>         result.m_alternateBase = chain->terminalPrototype();
>     }
>     result.m_offset = offset;
>-    result.m_callLinkStatus = std::move(callLinkStatus);
>+    result.m_callLinkStatus = WTF::move(callLinkStatus);
>     return result;
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 137809: 240002