Attachment 238611 Details for Bug 133019 – WIP

[patch] WIP

bug-133019-20140924151611.patch (text/plain), 2.29 KB, created by Brian Burg on 2014-09-24 15:16:17 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Brian Burg

Created: 2014-09-24 15:16:17 PDT

Size: 2.29 KB

patch

obsolete

>Subversion Revision: 173802
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 9eb30502c41d0f4496ccaf9c78c42f7fe1ed143c..c38e55367d3d0e865f457324f7567c105ca7e1fe 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,21 @@
>+2014-09-13  Brian J. Burg  <burg@cs.washington.edu>
>+
>+        Web Replay: ASSERTION FAILED: withinEventLoopInputExtent != m_withinEventLoopInputExtent
>+        https://bugs.webkit.org/show_bug.cgi?id=133019
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This assertion is slightly wrong because it does not account for nested run loops.
>+        We can be within two input extents when a nested run loop processes additional
>+        user inputs while the debugger is paused.
>+
>+        This should only be the case when execution is being neither captured or
>+        replayed. The debugger should not pause when capturing, and we should not replay
>+        event loop inputs while in a nested run loop.
>+
>+        * replay/InputCursor.h:
>+        (JSC::InputCursor::setWithinEventLoopInputExtent): Fix the assertion.
>+
> 2014-08-19  Brian J. Burg  <burg@cs.washington.edu>
> 
>         Web Replay: Check event loop extents during replaying
>diff --git a/Source/JavaScriptCore/replay/InputCursor.h b/Source/JavaScriptCore/replay/InputCursor.h
>index 2f40040bf531b296139ea6f25e990e6d61cd876d..5c2a85e9a037cb7d252b8dfa484cf3dc86d6d491 100644
>--- a/Source/JavaScriptCore/replay/InputCursor.h
>+++ b/Source/JavaScriptCore/replay/InputCursor.h
>@@ -52,9 +52,11 @@ public:
> 
>     void setWithinEventLoopInputExtent(bool withinEventLoopInputExtent)
>     {
>-        // We cannot enter more than one extent at a time, since they represent
>-        // a single run loop's work on behalf of the Page.
>-        ASSERT(withinEventLoopInputExtent != m_withinEventLoopInputExtent);
>+        // We can be within two input extents when a nested run loop
>+        // processes additional user inputs while the debugger is paused.
>+        // However, the debugger should not pause when capturing, and we
>+        // should not replay event loop inputs while in a nested run loop.
>+        ASSERT(m_withinEventLoopInputExtent != withinEventLoopInputExtent || !(isCapturing() || isReplaying()));
>         m_withinEventLoopInputExtent = withinEventLoopInputExtent;
>     }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 133019: 238611