Attachment 237196 Details for Bug 134420 – Summary diff between patch 3 and 4

[patch] Summary diff between patch 3 and 4

diff-diff.patch (text/plain), 1.52 KB, created by Mark Lam on 2014-08-26 20:34:31 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Lam

Created: 2014-08-26 20:34:31 PDT

Size: 1.52 KB

patch

obsolete

>193a194
>> +    slot.setThisValue(JSValue(thisObject));
>205a207
>> +    slot.setThisValue(JSValue(thisObject));
>568a571,611
>> Index: Source/JavaScriptCore/runtime/PropertySlot.h
>> ===================================================================
>> --- Source/JavaScriptCore/runtime/PropertySlot.h	(revision 172971)
>> +++ Source/JavaScriptCore/runtime/PropertySlot.h	(working copy)
>> @@ -204,6 +204,11 @@ public:
>>          m_offset = offset;
>>      }
>>  
>> +    void setThisValue(JSValue thisValue)
>> +    {
>> +        m_thisValue = thisValue;
>> +    }
>> +
>>      void setUndefined()
>>      {
>>          m_data.value = JSValue::encode(jsUndefined());
>> @@ -235,7 +240,7 @@ private:
>>  
>>      PropertyType m_propertyType;
>>      PropertyOffset m_offset;
>> -    const JSValue m_thisValue;
>> +    JSValue m_thisValue;
>>      JSObject* m_slotBase;
>>      WatchpointSet* m_watchpointSet;
>>      CacheabilityType m_cacheability;
>> Index: Source/JavaScriptCore/runtime/PutPropertySlot.h
>> ===================================================================
>> --- Source/JavaScriptCore/runtime/PutPropertySlot.h	(revision 172971)
>> +++ Source/JavaScriptCore/runtime/PutPropertySlot.h	(working copy)
>> @@ -80,6 +80,11 @@ namespace JSC {
>>              m_offset = offset;
>>          }
>>  
>> +        void setThisValue(JSValue thisValue)
>> +        {
>> +            m_thisValue = thisValue;
>> +        }
>> +
>>          PutValueFunc customSetter() const { return m_putFunction; }
>>  
>>          Context context() const { return static_cast<Context>(m_context); }

Actions: View | Formatted Diff | Diff

Attachments on bug 134420: 234038 | 234198 | 234219 | 237195 | 237196 | 237328