Attachment 233590 Details for Bug 133849 – Patch

[patch] Patch

patch.txt (text/plain), 1.50 KB, created by Michal Debski on 2014-06-23 03:19:01 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Michal Debski

Created: 2014-06-23 03:19:01 PDT

Size: 1.50 KB

patch

obsolete

>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 9e03894..502777b 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,20 @@
>+2014-06-13  Michal Debski  <m.debski@samsung.com>
>+
>+        Add double in JSValueTraits for array conversion.
>+        https://bugs.webkit.org/show_bug.cgi?id=133849
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Conversion for double type was missing in JSValueTraits. double arrays
>+        could not be created. JSValueTraits<double> added. Double is required
>+        in latest HTML5 Gamepad API.
>+        http://www.w3.org/TR/gamepad/
>+
>+        No new tests.
>+
>+        * bindings/js/JSDOMBinding.h:
>+        (WebCore::JSValueTraits<double>::arrayJSValue):
>+
> 2014-06-22  Zalan Bujtas  <zalan@apple.com>
> 
>         Make offset from ancestor computation explicit by moving it to the callers.
>diff --git a/Source/WebCore/bindings/js/JSDOMBinding.h b/Source/WebCore/bindings/js/JSDOMBinding.h
>index 7992c75..884e7c6 100644
>--- a/Source/WebCore/bindings/js/JSDOMBinding.h
>+++ b/Source/WebCore/bindings/js/JSDOMBinding.h
>@@ -423,6 +423,13 @@ template<> struct JSValueTraits<float> {
>     }
> };
> 
>+template<> struct JSValueTraits<double> {
>+    static JSC::JSValue arrayJSValue(JSC::ExecState*, JSDOMGlobalObject*, const double& value)
>+    {
>+        return JSC::jsNumber(value);
>+    }
>+};
>+
> template<> struct JSValueTraits<unsigned long> {
>     static JSC::JSValue arrayJSValue(JSC::ExecState*, JSDOMGlobalObject*, const unsigned long& value)
>     {

Actions: View | Formatted Diff | Diff

Attachments on bug 133849: 233590