Attachment 231565 Details for Bug 132983 – Patch

[patch] Patch

bug-132983-20140516195631.patch (text/plain), 2.95 KB, created by Gyuyoung Kim on 2014-05-16 03:56:56 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Gyuyoung Kim

Created: 2014-05-16 03:56:56 PDT

Size: 2.95 KB

patch

obsolete

>Subversion Revision: 168925
>diff --git a/Source/WebKit2/ChangeLog b/Source/WebKit2/ChangeLog
>index 0cec2d4d2b1fb391a601c1525b5d83516ea67091..14d99ebf43a6b8e9687d6a6189413db5ca621926 100644
>--- a/Source/WebKit2/ChangeLog
>+++ b/Source/WebKit2/ChangeLog
>@@ -1,3 +1,16 @@
>+2014-05-16  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
>+
>+        [EFL][WK2] test_ewk2_view is failed
>+        https://bugs.webkit.org/show_bug.cgi?id=132983
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Remove duplicated title change checking test.
>+
>+        * PlatformEfl.cmake: Unskip test_ewk2_view test.
>+        * UIProcess/API/efl/tests/test_ewk2_view.cpp:
>+        (TEST_F):
>+
> 2014-05-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
> 
>         [EFL][WK2] Skip failing unit tests
>diff --git a/Source/WebKit2/PlatformEfl.cmake b/Source/WebKit2/PlatformEfl.cmake
>index f84fad9723b66191971a79938330bde4c5ab2141..37f4782e85bff0492dab122eef109ce3dd7aed88 100644
>--- a/Source/WebKit2/PlatformEfl.cmake
>+++ b/Source/WebKit2/PlatformEfl.cmake
>@@ -479,6 +479,7 @@ set(EWK2UnitTests_BINARIES
>     test_ewk2_settings
>     test_ewk2_ssl
>     test_ewk2_storage_manager
>+    test_ewk2_view
>     test_ewk2_window_features
> )
> 
>diff --git a/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp b/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp
>index 9b6824f46270474a13951dbb2e5f444b2f5a4798..de66caa0d2f38ff413d0a79dc0084cc9cfa17037 100644
>--- a/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp
>+++ b/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp
>@@ -479,22 +479,22 @@ TEST_F(EWK2ViewTest, ewk_view_title_changed)
>     const char* titleChangedHTML =
>         "<!doctype html><head><title>Title before changed</title></head>"
>         "<body onload=\"document.title='Title after changed';\"></body>";
>-    ewk_view_html_string_load(webView(), titleChangedHTML, 0, 0);
>-    EXPECT_TRUE(waitUntilTitleChangedTo("Title after changed"));
>+    ewk_view_html_string_load(webView(), titleChangedHTML, "file:///", 0);
>+    EXPECT_TRUE(waitUntilLoadFinished());
>     EXPECT_STREQ("Title after changed", ewk_view_title_get(webView()));
> 
>     titleChangedHTML =
>         "<!doctype html><head><title>Title before changed</title></head>"
>         "<body onload=\"document.title='';\"></body>";
>-    ewk_view_html_string_load(webView(), titleChangedHTML, 0, 0);
>-    EXPECT_TRUE(waitUntilTitleChangedTo(""));
>+    ewk_view_html_string_load(webView(), titleChangedHTML, "file:///", 0);
>+    EXPECT_TRUE(waitUntilLoadFinished());
>     EXPECT_STREQ("", ewk_view_title_get(webView()));
> 
>     titleChangedHTML =
>         "<!doctype html><head><title>Title before changed</title></head>"
>         "<body onload=\"document.title=null;\"></body>";
>-    ewk_view_html_string_load(webView(), titleChangedHTML, 0, 0);
>-    EXPECT_TRUE(waitUntilTitleChangedTo(""));
>+    ewk_view_html_string_load(webView(), titleChangedHTML, "file:///", 0);
>+    EXPECT_TRUE(waitUntilLoadFinished());
>     EXPECT_STREQ("", ewk_view_title_get(webView()));
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 132983: 231565 | 239026