Attachment 230817 Details for Bug 132561 – Patch

[patch] Patch

bug-132561-20140505125508.patch (text/plain), 10.38 KB, created by Grzegorz Czajkowski on 2014-05-05 03:55:32 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Grzegorz Czajkowski

Created: 2014-05-05 03:55:32 PDT

Size: 10.38 KB

patch

obsolete

>Subversion Revision: 168256
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 27fdf56bbfa83f8b68c723fa0634018cf3848c8a..c7401240ed35c41923a0cae4153bfeaa89f5c459 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,26 @@
>+2014-05-05  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
>+
>+        Share mac/editing/spelling/delete-into-misspelled-word.html with other platforms
>+        https://bugs.webkit.org/show_bug.cgi?id=132561
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This test does not use Mac specific features and
>+        can be run by other platforms as well.
>+
>+        Due to bug 125689, this test starts using asynchronous spellchecking.
>+
>+        * editing/spelling/delete-into-misspelled-word-expected.txt:
>+        Renamed from LayoutTests/platform/mac/editing/spelling/delete-into-misspelled-word-expected.txt
>+        * editing/spelling/delete-into-misspelled-word.html:
>+        Renamed from LayoutTests/platform/mac/editing/spelling/delete-into-misspelled-word.html
>+
>+        * platform/gtk/TestExpectations:
>+        * platform/mac-wk2/TestExpectations:
>+        * platform/win/TestExpectations:
>+        Mark delete-into-misspelled-word.html as failing since those
>+        platforms didn't turn on asynchronous spellchecking.
>+
> 2014-05-04  Andreas Kling  <akling@apple.com>
> 
>         Unreviewed, rolling out r168254.
>diff --git a/LayoutTests/editing/spelling/delete-into-misspelled-word-expected.txt b/LayoutTests/editing/spelling/delete-into-misspelled-word-expected.txt
>new file mode 100644
>index 0000000000000000000000000000000000000000..7295585be41439b9b5d5d25050a7ab8a6ff8b7fc
>--- /dev/null
>+++ b/LayoutTests/editing/spelling/delete-into-misspelled-word-expected.txt
>@@ -0,0 +1,14 @@
>+This test verifies if the misspelled word still remains spelling markers when user pressed the backspace key to move the caret at the end of the word or delete key to move the caret at the beginning of the word. This test succeeds when a word "meagesga" has red underline.
>+
>+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
>+
>+
>+PASS internals.hasSpellingMarker(7, 8) became true
>+execDeleteCommand()
>+PASS internals.hasSpellingMarker(7, 8) became true
>+execForwardDeleteCommand()
>+PASS internals.hasSpellingMarker(7, 8) became true
>+PASS successfullyParsed is true
>+
>+TEST COMPLETE
>+
>diff --git a/LayoutTests/editing/spelling/delete-into-misspelled-word.html b/LayoutTests/editing/spelling/delete-into-misspelled-word.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..a3eb695071a38537a5731db126b869f72fa59fc6
>--- /dev/null
>+++ b/LayoutTests/editing/spelling/delete-into-misspelled-word.html
>@@ -0,0 +1,79 @@
>+<html>
>+<head>
>+<script src="../editing.js"></script>
>+</head>
>+<body>
>+<script src="../../resources/js-test-pre.js"></script>
>+<textarea id="testElement"></textarea>
>+<script type="text/javascript">
>+description('This test verifies if the misspelled word still remains spelling markers '
>+    + 'when user pressed the backspace key to move the caret at the end of the word or delete key to move '
>+    + 'the caret at the beginning of the word. '
>+    + 'This test succeeds when a word "meagesga" has red underline.');
>+
>+jsTestIsAsync = true;
>+
>+if (window.internals) {
>+    internals.settings.setUnifiedTextCheckerEnabled(true);
>+    internals.settings.setAsynchronousSpellCheckingEnabled(true);
>+}
>+
>+document.getElementById('testElement').focus();
>+typeCharacterCommand('i');
>+typeCharacterCommand('t');
>+typeCharacterCommand('\'');
>+typeCharacterCommand('s');
>+typeCharacterCommand(' ');
>+typeCharacterCommand('a');
>+typeCharacterCommand(' ');
>+typeCharacterCommand('m');
>+typeCharacterCommand('e');
>+typeCharacterCommand('a');
>+typeCharacterCommand('g');
>+typeCharacterCommand('e');
>+typeCharacterCommand('s');
>+typeCharacterCommand('g');
>+typeCharacterCommand('a');
>+typeCharacterCommand(' ');
>+
>+function checkSpellingMarker()
>+{
>+    if (window.internals)
>+        shouldBecomeEqual('internals.hasSpellingMarker(7, 8)', 'true', done);
>+}
>+
>+function checkSpellingMarkerAfterDeleteCommand()
>+{
>+    evalAndLog('execDeleteCommand()');
>+    checkSpellingMarker();
>+}
>+
>+function checkSpellingMarkerAfterForwardDelete()
>+{
>+    textarea = document.getElementById('testElement');
>+    textarea.setSelectionRange(6, 6);
>+    typeCharacterCommand(' ');
>+    evalAndLog('execForwardDeleteCommand()');
>+
>+    checkSpellingMarker();
>+}
>+
>+var tests = [
>+    function() { checkSpellingMarker(); },
>+    function() { checkSpellingMarkerAfterDeleteCommand(); },
>+    function() { checkSpellingMarkerAfterForwardDelete(); }
>+];
>+
>+function done()
>+{
>+    var next = tests.shift();
>+    if (next)
>+        return window.setTimeout(next, 0);
>+
>+    finishJSTest();
>+}
>+done();
>+</script>
>+<script src="../../resources/js-test-post.js"></script>
>+</body>
>+</html>
>diff --git a/LayoutTests/platform/gtk/TestExpectations b/LayoutTests/platform/gtk/TestExpectations
>index d93de2fd2d458654e1ad29f2cc179d4de25496a6..e0518aa146a4760321334b9d22932dbcc9f99204 100644
>--- a/LayoutTests/platform/gtk/TestExpectations
>+++ b/LayoutTests/platform/gtk/TestExpectations
>@@ -1138,6 +1138,7 @@ webkit.org/b/42194 fast/events/5056619.html [ Failure ]
> webkit.org/b/42194 http/tests/security/drag-drop-same-unique-origin.html [ Failure ]
> 
> # Missing TextChecker::requestCheckingOfString() implementation for Gtk.
>+webkit.org/b/73003 editing/spelling/delete-into-misspelled-word.html [ Skip ]
> webkit.org/b/73003 editing/spelling/spellcheck-async-mutation.html [ Skip ]
> webkit.org/b/73003 editing/spelling/spellcheck-async-remove-frame.html [ Skip ]
> webkit.org/b/73003 editing/spelling/spellcheck-async.html [ Skip ]
>diff --git a/LayoutTests/platform/mac-wk2/TestExpectations b/LayoutTests/platform/mac-wk2/TestExpectations
>index 75ae69dca184b4f930da0a3efe9fc72239e1c5ac..ac3bdcb512a5fb73f15c0ae356145f5f6ffd5537 100644
>--- a/LayoutTests/platform/mac-wk2/TestExpectations
>+++ b/LayoutTests/platform/mac-wk2/TestExpectations
>@@ -118,6 +118,7 @@ platform/mac/fast/forms/listbox-scrollbar-hit-test.html
> # [WK2] [Mac] Spellcheck tests don't seem to work
> webkit.org/b/105616 editing/spelling/context-menu-suggestions-multiword-selection.html
> webkit.org/b/105616 editing/spelling/context-menu-suggestions-subword-selection.html
>+webkit.org/b/105616 editing/spelling/delete-into-misspelled-word.html
> webkit.org/b/105616 editing/inserting/inserting-slash-inside-url-with-smart-link.html
> webkit.org/b/105616 editing/spelling/spelling-changed-text.html
> webkit.org/b/105616 editing/spelling/spelling-backspace-between-lines.html
>diff --git a/LayoutTests/platform/mac/editing/spelling/delete-into-misspelled-word-expected.txt b/LayoutTests/platform/mac/editing/spelling/delete-into-misspelled-word-expected.txt
>deleted file mode 100644
>index 28825f4d9a158f6e3b995104a37ebbe6e754cac3..0000000000000000000000000000000000000000
>--- a/LayoutTests/platform/mac/editing/spelling/delete-into-misspelled-word-expected.txt
>+++ /dev/null
>@@ -1,6 +0,0 @@
>-The test verified that if user use delete to move caret to the end, or use forward delete to move caret to the beginning of, a word that is marked as misspelled, the misspell underline will remain. You should see phrase "it's a meagesga", in which the word 'meagesga' has red underline.
>-
>-
>-SUCCESS
>-SUCCESS
>-
>diff --git a/LayoutTests/platform/mac/editing/spelling/delete-into-misspelled-word.html b/LayoutTests/platform/mac/editing/spelling/delete-into-misspelled-word.html
>deleted file mode 100644
>index 0d4f5db5601abff3566733f94e410efead468e69..0000000000000000000000000000000000000000
>--- a/LayoutTests/platform/mac/editing/spelling/delete-into-misspelled-word.html
>+++ /dev/null
>@@ -1,57 +0,0 @@
>-<html>
>-<head>
>-<script src=../../../../editing/editing.js language="javascript" type="text/javascript"></script>
>-<title>Editing Test</title> 
>-</head> 
>-<body>
>-<p>The test verified that if user use delete to move caret to the end, or use forward delete to move
>-caret to the beginning of, a word that is marked as misspelled, the misspell underline will remain. 
>-You should see phrase "it's a meagesga", in which the word 'meagesga' has red underline.</p>
>-<textarea id="test" cols="80" rows="10"></textarea>
>-<div id="console"></div>
>-<script language="javascript" type="text/javascript">
>-if (window.testRunner) {
>-    testRunner.dumpAsText();
>-}
>-
>-document.getElementById('test').focus();
>-typeCharacterCommand('i');
>-typeCharacterCommand('t');
>-typeCharacterCommand('\'');
>-typeCharacterCommand('s');
>-typeCharacterCommand(' ');
>-typeCharacterCommand('a');
>-typeCharacterCommand(' ');
>-typeCharacterCommand('m');
>-typeCharacterCommand('e');
>-typeCharacterCommand('a');
>-typeCharacterCommand('g');
>-typeCharacterCommand('e');
>-typeCharacterCommand('s');
>-typeCharacterCommand('g');
>-typeCharacterCommand('a');
>-typeCharacterCommand(' ');
>-execDeleteCommand();
>-if (window.internals && window.internals.hasSpellingMarker) {
>-    if (window.internals.hasSpellingMarker(7,8) == 1) {
>-        document.getElementById('console').innerHTML = 'SUCCESS<br>';
>-    } else {
>-        document.getElementById('console').innerHTML = "FAILURE. The word 'meagesga' does not have underline.<br>";
>-    }
>-}
>-
>-textarea = document.getElementById('test');
>-textarea.setSelectionRange(6, 6);
>-textarea.focus();
>-typeCharacterCommand(' ');
>-execForwardDeleteCommand();
>-if (window.internals && window.internals.hasSpellingMarker) {
>-    if (window.internals.hasSpellingMarker(7,8) == 1) {
>-        document.getElementById('console').innerHTML = document.getElementById('console').innerHTML + 'SUCCESS<br>';
>-    } else {
>-        document.getElementById('console').innerHTML = document.getElementById('console').innerHTML + "FAILURE. The word 'meagesga' does not have underline.<br>";
>-    }
>-}
>-</script>
>-</body>
>-</html>
>diff --git a/LayoutTests/platform/win/TestExpectations b/LayoutTests/platform/win/TestExpectations
>index 8a2daec16f439fdb93d69e560eeaee8cf9ab47d1..1258e00500774e1f4c523c27215917188cfbfa31 100644
>--- a/LayoutTests/platform/win/TestExpectations
>+++ b/LayoutTests/platform/win/TestExpectations
>@@ -1932,6 +1932,7 @@ svg/css/shadow-changes.svg [ Failure ]
> # End temporary skips
> 
> # Spellchecker behavior tests.
>+webkit.org/b/108370 editing/spelling/delete-into-misspelled-word.html [ Failure ]
> webkit.org/b/108370 editing/spelling/design-mode-spellcheck-off.html [ Failure ]
> webkit.org/b/108370 editing/spelling/context-menu-suggestions-multiword-selection.html [ Failure ]
> webkit.org/b/108370 editing/spelling/context-menu-suggestions-subword-selection.html [ Failure ]

Actions: View | Formatted Diff | Diff

Attachments on bug 132561: 230817