Attachment 230143 Details for Bug 131889 – Patch

[patch] Patch

bug-131889-20140425091621.patch (text/plain), 3.83 KB, created by Ion Rosca on 2014-04-24 23:16:44 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ion Rosca

Created: 2014-04-24 23:16:44 PDT

Size: 3.83 KB

patch

obsolete

>Subversion Revision: 167749
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 7cbb003130c4d34e436f1bae95d903ea346f45fb..adc1192fd30b325b11214ee2291f3b4712d5ba22 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,21 @@
>+2014-04-24  Ion Rosca  <rosca@adobe.com>
>+
>+        Incomplete body painting when using blend modes
>+        https://bugs.webkit.org/show_bug.cgi?id=131889
>+
>+        The incomplete painting was caused by the transparency layer created for
>+        the root renderer. We can safely skip creating this transparency layer at
>+        the root level, as there is nothing else being painted behind this layer that
>+        could be used erroneously as a backdrop.
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Test: css3/compositing/blend-mode-with-body.html
>+
>+        * rendering/RenderLayer.h:
>+        Changing RenderLayer::paintsWithTransparency so that it will not
>+        return true when the root renderer needs to isolate blending.
>+
> 2014-04-23  Darin Adler  <darin@apple.com>
> 
>         [Cocoa] fix CF leaks found by code inspection
>diff --git a/Source/WebCore/rendering/RenderLayer.h b/Source/WebCore/rendering/RenderLayer.h
>index 4a2df2674951b8bcb1cc42459cf1355634b8093c..00f6dd2da9a13c0e4293f9180d654b744801a0db 100644
>--- a/Source/WebCore/rendering/RenderLayer.h
>+++ b/Source/WebCore/rendering/RenderLayer.h
>@@ -833,7 +833,7 @@ public:
> 
>     bool paintsWithTransparency(PaintBehavior paintBehavior) const
>     {
>-        return (isTransparent() || hasBlendMode() || isolatesBlending()) && ((paintBehavior & PaintBehaviorFlattenCompositingLayers) || !isComposited());
>+        return (isTransparent() || hasBlendMode() || (isolatesBlending() && !renderer().isRoot())) && ((paintBehavior & PaintBehaviorFlattenCompositingLayers) || !isComposited());
>     }
> 
>     bool paintsWithTransform(PaintBehavior) const;
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 04212f27264d23dc82d57546acc29358dd8ab1ec..958b5ee77bb68c31e5985c9d5dfffdcc9615d391 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,13 @@
>+2014-04-24  Ion Rosca  <rosca@adobe.com>
>+
>+        Incomplete body painting when using blend modes
>+        https://bugs.webkit.org/show_bug.cgi?id=131889
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * css3/compositing/blend-mode-with-body-expected.html: Added.
>+        * css3/compositing/blend-mode-with-body.html: Added.
>+
> 2014-04-23  Alexey Proskuryakov  <ap@apple.com>
> 
>         Eliminate internals.setMockScrollbarsEnabled()
>diff --git a/LayoutTests/css3/compositing/blend-mode-with-body-expected.html b/LayoutTests/css3/compositing/blend-mode-with-body-expected.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..4ba7772fdc6030ff56e23dbb69670d03375da966
>--- /dev/null
>+++ b/LayoutTests/css3/compositing/blend-mode-with-body-expected.html
>@@ -0,0 +1,16 @@
>+<!DOCTYPE HTML>
>+<head>
>+    <style>
>+    	body {
>+            background-color: #0000ff;
>+        }
>+        div {
>+            width: 100px;
>+            height: 100px;
>+        }
>+    </style>
>+</head>
>+<body>
>+	<p>This test passes if background-color fills the entire view port.</p>
>+    <div></div>
>+</body>
>diff --git a/LayoutTests/css3/compositing/blend-mode-with-body.html b/LayoutTests/css3/compositing/blend-mode-with-body.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..e950a683496f596d97fba441c92c025b06fa67be
>--- /dev/null
>+++ b/LayoutTests/css3/compositing/blend-mode-with-body.html
>@@ -0,0 +1,17 @@
>+<!DOCTYPE HTML>
>+<head>
>+    <style>
>+        body {
>+            background-color: #0000ff;
>+        }
>+        div {
>+            width: 100px;
>+            height: 100px;
>+            mix-blend-mode: difference;
>+        }
>+    </style>
>+</head>
>+<body>
>+    <p>This test passes if background-color fills the entire view port.</p>
>+    <div></div>
>+</body>

Actions: View | Formatted Diff | Diff

Attachments on bug 131889: 229736 | 229781 | 230143